cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity
osmo-pcu/src
History
Max b3a17d6074 cosmetic: clarify coding scheme and puncturing 
* use appropriate types for coding scheme parameters
* add comment regarding possible number of RLCMAC blocks

The code in create_dl_acked_block() has underlying assumption that
rlc.num_data_blocks can never be more than 2, which is true and is
enforced by appropriate asserts but is not obvious when looking at the
function code alone. It's equally hard for Coverity which leads to false
positives in scan.

Lets' make this assumption explicit by putting it into for(;;) condition
alongside with corresponding comment.

Fixes: CID143070
Change-Id: If599a6c8a6ef56d847604fcf41bb71decccd8a78
 		2018-01-04 16:35:55 +00:00
..
osmo-bts-litecell15 PCU: Fix TA adjustment 2017-11-16 10:06:41 -05:00
osmo-bts-sysmo PCU: Fix TA adjustment 2017-11-16 10:06:41 -05:00
.gitignore Adding .gitignore to source directory 2012-06-27 17:45:15 +02:00
Makefile.am Move multislot table to separate file 2017-11-21 10:45:24 +00:00
bts.cpp TBF: log timer invocation source 2018-01-02 07:26:05 +00:00
bts.h Fix compiler warning 2017-12-01 17:19:04 +01:00
csn1.cpp remove pcu own bitvector implementation 2017-05-15 12:46:33 +00:00
csn1.h remove pcu own bitvector implementation 2017-05-15 12:46:33 +00:00
cxx_linuxlist.h llist: Add missing const qualifier in llist cast method 2015-08-24 12:23:50 +02:00
decoding.cpp Add debugging log for RLC data block decoding 2016-12-02 09:15:53 +00:00
decoding.h Add header type 1 support for EGPRS uplink 2016-06-16 14:32:07 +00:00
egprs_rlc_compression.cpp remove pcu own bitvector implementation 2017-05-15 12:46:33 +00:00
egprs_rlc_compression.h Add compression support in EGPRS PUAN 2017-01-23 12:26:09 +00:00
encoding.cpp window: move encoding into functions 2018-01-04 10:15:59 +00:00
encoding.h window: move encoding into functions 2018-01-04 10:15:59 +00:00
gprs_bssgp_pcu.cpp Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_bssgp_pcu.h bssgp: Use measured leak rate for flow control 2015-09-11 11:52:02 +02:00
gprs_codel.c llc: Add CoDel AQM implementation 2015-07-21 19:22:32 +02:00
gprs_codel.h llc: Add CoDel AQM implementation 2015-07-21 19:22:32 +02:00
gprs_coding_scheme.cpp cosmetic: clarify coding scheme and puncturing 2018-01-04 16:35:55 +00:00
gprs_coding_scheme.h cosmetic: clarify coding scheme and puncturing 2018-01-04 16:35:55 +00:00
gprs_debug.cpp Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_debug.h Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_ms.cpp Assert valid CS 2017-09-08 12:51:03 +02:00
gprs_ms.h Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_ms_storage.cpp pcu: Fix memory corruption bugs (ASAN) 2016-02-01 13:56:32 +01:00
gprs_ms_storage.h pcu: Fix memory corruption bugs (ASAN) 2016-02-01 13:56:32 +01:00
gprs_rlcmac.cpp Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_rlcmac.h Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
gprs_rlcmac_meas.cpp cosmetic: convert explicit warnings to fixme/todo 2017-09-04 13:06:01 +00:00
gprs_rlcmac_sched.cpp cosmetic: convert explicit warnings to fixme/todo 2017-09-04 13:06:01 +00:00
gprs_rlcmac_ts_alloc.cpp Move multislot table to separate file 2017-11-21 10:45:24 +00:00
gsm_rlcmac.cpp remove pcu own bitvector implementation 2017-05-15 12:46:33 +00:00
gsm_rlcmac.h rlc: Add decode_gsm_ra_cap to decode Radio Access Caps 2016-02-08 00:45:36 +01:00
gsm_timer.cpp bts: Move the frame_number into the BTS sructure 2013-10-30 21:20:45 +01:00
gsm_timer.h move everything to src/ subdirectory 2012-06-14 20:48:42 +08:00
llc.cpp Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
llc.h Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
mslot_class.c Add function to get max supported MS class 2017-12-21 15:13:25 +01:00
mslot_class.h Add function to get max supported MS class 2017-12-21 15:13:25 +01:00
osmobts_sock.cpp Print error cause of pcu socket connect failure 2017-12-05 18:44:06 +01:00
pcu_l1_if.cpp Support receiving SI13 from BTS 2017-09-01 11:08:06 +02:00
pcu_l1_if.h PCU: Fix TA adjustment 2017-11-16 10:06:41 -05:00
pcu_main.cpp Support receiving SI13 from BTS 2017-09-01 11:08:06 +02:00
pcu_utils.h Add tests for pcu_lsb() 2017-12-22 14:20:05 +01:00
pcu_vty.c vty: skip installing cmds now always installed by default 2017-11-01 00:51:51 +01:00
pcu_vty.h Support receiving SI13 from BTS 2017-09-01 11:08:06 +02:00
pcu_vty_functions.cpp window: move encoding into functions 2018-01-04 10:15:59 +00:00
pcu_vty_functions.h tbf: Use LListHead instead of llist_pods 2016-02-01 13:58:13 +01:00
poll_controller.cpp Cleanup FN scheduling 2017-05-26 07:55:52 +00:00
poll_controller.h poll: Add a max_delay parameter to PollController::expireTimedout 2015-08-28 12:23:07 +02:00
rlc.cpp cosmetic: clarify coding scheme and puncturing 2018-01-04 16:35:55 +00:00
rlc.h cosmetic: clarify coding scheme and puncturing 2018-01-04 16:35:55 +00:00
sba.cpp Cleanup FN scheduling 2017-05-26 07:55:52 +00:00
sba.h Remove unused includes and forward declarations 2017-12-18 22:05:22 +00:00
tbf.cpp Fix llc_queue_size() type 2018-01-03 12:00:36 +01:00
tbf.h window: move encoding into functions 2018-01-04 10:15:59 +00:00
tbf.txt Doc: Update on README and tbf.txt 2012-12-18 10:04:03 +01:00
tbf_dl.cpp cosmetic: clarify coding scheme and puncturing 2018-01-04 16:35:55 +00:00
tbf_ul.cpp TBF: log timer invocation source 2018-01-02 07:26:05 +00:00