cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-11-15 11:35:03 +00:00 committed by Gerrit Code Review
parent 870c910cc5
commit 75f1c34f12
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
1d19fe3c7afd701e78a3364deef764abef14a64e
View File

@ -34,6 +34,24 @@
"parentUuid": "3f3ba062_f4b67149",
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "b067e8c2_cd38a3ea",
"filename": "src/libmsc/sdp_msg.c",
"patchSetId": 1
},
"lineNbr": 271,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-15T11:35:03Z",
"side": 1,
"message": "\"\"\"\n#define foreach_sdp_audio_codec(/* struct sdp_audio_codec* */ CODEC, \\\n\t\t\t\t/* struct sdp_audio_codecs* */ AC) \\\n\tfor (CODEC \u003d (AC)-\u003ecodec; \\\n\t (CODEC - (AC)-\u003ecodec) \u003c OSMO_MIN((AC)-\u003ecount, ARRAY_SIZE((AC)-\u003ecodec)); \\\n\t CODEC++)\n\n\"\"\"\n\n\"\"\"\nbool sdp_audio_codec_is_set(const struct sdp_audio_codec *a)\n{\n\treturn a \u0026\u0026 a-\u003esubtype_name[0];\n}\n\"\"\"\n\nCan \"codec\" be really NULL here? I don\u0027t think so (maybe if \u0026sdp-\u003eaudio_codecs-\u003ecodec\u003d\u003dNULL, but is that really possible?)",
"parentUuid": "4309fc95_0ff23a4f",
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}