cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
This commit is contained in:
Gerrit User 1000004 2022-11-14 19:38:10 +00:00 committed by Gerrit Code Review
parent 53afdd1df3
commit 870c910cc5
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
1d19fe3c7afd701e78a3364deef764abef14a64e
View File

@ -16,6 +16,24 @@
"message": "Isn\u0027t sdp_audio_codec_is_set() implemented by checking codec-\u003esubtype_name[0] like before? what\u0027s changing in this patch? I\u0027m missing something?",
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4309fc95_0ff23a4f",
"filename": "src/libmsc/sdp_msg.c",
"patchSetId": 1
},
"lineNbr": 271,
"author": {
"id": 1000004
},
"writtenOn": "2022-11-14T19:38:10Z",
"side": 1,
"message": "the previous code did not check if codec-\u003esubtype was a valid pointer at all, and unconditionally dereferenced it. The new code is now checkign for a valid pointer, and whether the first character is non-NUL.",
"parentUuid": "3f3ba062_f4b67149",
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}