Update patch set 2

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Label: Code-Review=-1, 26c760fbae67c1f2e2a26f2dddc4ad9fcf75b79d
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}

534847cc6505e23f2c3f3f06cc55b58fa95880a9

@@ -34,6 +34,24 @@
       "parentUuid": "4aa80512_47c6604e",
       "revId": "534847cc6505e23f2c3f3f06cc55b58fa95880a9",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f7dc4591_64bc1ed4",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-12-21T01:47:03Z",
+      "side": 1,
+      "message": "Neels: I think you\u0027re right. Changed to CR-1.\n\nThe problem with adding new fields is that we enlarge the MNCC PDU. While it may be fine sending a larger PDU to a peer; we may have problems when a peer is sending a shorter PDU than we expect.\n\nIf you\u0027re sure this works fine and:\n\n* an older version of osmo-sip-connector can still \"talk\" to recent osmo-msc,\n* an older version of osmo-msc can still \"talk\" to recent osmo-sip-connector,\n\nas long as they \"speak\" the same MNCC protocol version, we must be absolutely sure that this would not cause any fallout for the respective TTCN-3 testsuites.",
+      "parentUuid": "e75f110b_1d5cd836",
+      "revId": "534847cc6505e23f2c3f3f06cc55b58fa95880a9",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }