57 lines
2.3 KiB
Plaintext
57 lines
2.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4aa80512_47c6604e",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-12-19T16:54:56Z",
|
|
"side": 1,
|
|
"message": "We cannot add new fields to the MNCC protocol without bumping the protocol version.",
|
|
"revId": "534847cc6505e23f2c3f3f06cc55b58fa95880a9",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e75f110b_1d5cd836",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2023-12-21T00:04:04Z",
|
|
"side": 1,
|
|
"message": "@vyanitskiy@sysmocom.de a vote of -2 is sticky and means \"the idea of this patch is flawed and we will never merge this no matter what\" ... I guess instead you mean to -1 until the version number is bumped along with this patch?",
|
|
"parentUuid": "4aa80512_47c6604e",
|
|
"revId": "534847cc6505e23f2c3f3f06cc55b58fa95880a9",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f7dc4591_64bc1ed4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-12-21T01:47:03Z",
|
|
"side": 1,
|
|
"message": "Neels: I think you\u0027re right. Changed to CR-1.\n\nThe problem with adding new fields is that we enlarge the MNCC PDU. While it may be fine sending a larger PDU to a peer; we may have problems when a peer is sending a shorter PDU than we expect.\n\nIf you\u0027re sure this works fine and:\n\n* an older version of osmo-sip-connector can still \"talk\" to recent osmo-msc,\n* an older version of osmo-msc can still \"talk\" to recent osmo-sip-connector,\n\nas long as they \"speak\" the same MNCC protocol version, we must be absolutely sure that this would not cause any fallout for the respective TTCN-3 testsuites.",
|
|
"parentUuid": "e75f110b_1d5cd836",
|
|
"revId": "534847cc6505e23f2c3f3f06cc55b58fa95880a9",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |