Commit Graph

6115 Commits

Author SHA1 Message Date
Alexander Couzens c56f68abd7 git-version-gen: revert to same version as libosmocore
OpenBSC required additional care because of an unusal .git location.
This is not need anymore for osmo-mgw

Change-Id: I5aad67612026947ad52cdc9477b603732c146e7a
2017-08-08 17:19:15 +02:00
Alexander Couzens 01fc7fb239 reword debian packages support
Remove old leftover from split of osmo-mgw out of openbsc.

Change-Id: I96a6a56c401833d053d48908872fb0474f5aec53
2017-08-08 17:18:40 +02:00
Neels Hofmeyr 370f4e3867 mgcp client: allow getting actual conf from opaque struct 2017-07-26 14:21:15 +02:00
Neels Hofmeyr 3acaadd44d prune public mgcpgw_client api 2017-07-26 14:21:15 +02:00
Neels Hofmeyr f6a9cd53f4 split off osmo-mgw: remove files, apply build, rename
Add vty and logging previously used from libcommon

Rename libmgcp to libosmo-legacy-mgcp and install.

Use DLMGCP, not DMGCP.

Change-Id: I71a0a16ebaaef881c34235849601fc40aa12cfd7
Depends: libosmocore I09c587e2d59472cbde852d467d457254746d9e67
2017-07-26 14:21:15 +02:00
Neels Hofmeyr f81151bd3f iudummy: remove public ranap_ue_conn_ctx_alloc
This function has been removed in osmo-iuh.
2017-07-25 15:32:42 +02:00
Neels Hofmeyr 9c0bab9b48 add msg type to SMS rx logging
Change-Id: I73ea4eebe57b2d1008045a27f174072178b9f077
2017-07-25 15:32:41 +02:00
Neels Hofmeyr 2fa9279702 set require IMEI by default
Change-Id: I91d8f3e79cdaa206f8cd32b42bd7c23933f9631a
2017-07-25 15:32:41 +02:00
Neels Hofmeyr a622828806 msc_vlr tests: add IMEISV tests
Change-Id: I752afef2ae3ce04e813c7e9fea0e883e607c0e14
2017-07-25 15:32:41 +02:00
Neels Hofmeyr 2ab3af5263 vlr: LU FSM: enable Retrieve_IMEISV_If_Required
Change-Id: I121b95ad6d5ecb7603815eece2b43008de487a8a
2017-07-25 15:24:42 +02:00
Neels Hofmeyr 8571981205 vlr: place comments on if (0) cases 2017-07-25 15:24:42 +02:00
Neels Hofmeyr 2930c2d8ad .gitignore: cosmetic: use globs to ignore test binaries
Change-Id: I840e4333a4cad646d751ebafe7e0ef23e7a9c708
2017-07-25 15:24:42 +02:00
Neels Hofmeyr 6cd30366be move libiu to osmo-iuh/libosmo-ranap
Remove libiu here, use the functions from libosmo-ranap instead, by applying
the ranap_ / RANAP_ prefix.

Corresponding change-id in osmo-iuh.git is I6a3f7ad15be03fb94689b4af6ccfa828c25f45c0

Change-Id: Ib8c4fcdb4766c5e575618b95ce16dce51063206b
2017-07-25 15:24:41 +02:00
Neels Hofmeyr ffb3e8d2ec MSC,SGSN: use OSMO_GSUP_PORT == 4222 instead of 2222
In SGSN, actually place the port in the SGSN config by default, so that the
gsup port may now be omitted in the VTY config (the IP address suffices).

Adjust the osmo-sgsn.cfg example.

Depends: I4222e21686c823985be8ff1f16b1182be8ad6175 (libosmocore)
Change-Id: I50f2040e2eb0baacb43849e93cfed10cbc2fc156
2017-07-25 15:18:48 +02:00
Neels Hofmeyr b3f606a826 msc_vlr_tests: properly check BSSAP Clear and Iu Release
Change-Id: Ice8125decc1a663d95ae70418e151bff559b983b
2017-07-25 15:18:43 +02:00
Neels Hofmeyr 838a381b49 cosmetic: msc_vlr_tests: better place clear_cmd wrap, adjust printed msg
Change-Id: Iec6f03f97803b2604f0094260cba256e72ee67bd
2017-07-25 15:15:22 +02:00
Neels Hofmeyr c5aed8c10e fix release upon IMSI Detach
In case of an IMSI Detach, we don't have a conn_fsm, yet we still need to send
release messages. Hence directly release the conn in msc_subscr_conn_close()
when there is no conn_fsm present.

Move the conn release actions from the conn_fsm cleanup function to new
function msc_subscr_conn_release_all(). From the FSM cleanup, call
msc_subscr_conn_close(), and invoke msc_subscr_conn_release_all() from there.

Document msc_subscr_conn_close() behavior.

Change-Id: Ied6981099605ad803f8ffed38f23ed8203a97727
2017-07-25 15:15:22 +02:00
Neels Hofmeyr 5b2283ba68 cosmetic: add info log for Iu Release tx
Change-Id: Ia64bc937d7f37ef6209efbdf884de61008f8816d
2017-07-25 15:15:22 +02:00
Neels Hofmeyr f42457ec98 cosmetic: remove obsolete comment
Change-Id: Ie60e00e07b2129ac4bb3cac94921bf3c8d9cd861
2017-07-25 15:15:22 +02:00
Philipp Maier 09db3b69ed a-iface: move clear command to subscriber_conn.c
The clear command is currently triggered from the wrong place.
This is a fixup that corrects that. However, it will introduce
another problem: The clear command is not sent on detach.

Adjust test expectations.

Change-Id: Ia27d7e94cb11adf351457b3b0e98a5c9d5070fbf
2017-07-25 15:15:22 +02:00
Philipp Maier 4ebab46847 vty: Fixup sccp/ss7 configuration
The sccp/ss7 configuration is now fixed. The cs7 instance id is
implicitly detected from the bsc_addr or the msc_addr. Depending
on what is listed last. (I am not sure if that is wise, maybe
we should only use the local/bsc address to do the lookup).

Remove cs7-instance vty command

Modify VTY commands, so that the fixed API is used

Set msc->a.cs7_instance from the VTY to when msc/bsc addr is parsed

Fix the initalization to use osmo_sccp_simple_client_on_ss7_id() and
pass the cs7-instance id we determined from the vty.

The whole thing is not waterproof yet. We are still not at the
point where we allow to leave the local address out. This would
be fine, but when it is left out, the only way to determine the
cs7 instance is to use the msc_addr then.

We also might want to make sure to reach a state where all cs7
related config may be left out (like with the MSC)
2017-07-25 15:15:22 +02:00
Philipp Maier 19c4fd0562 fixup for: mgcp: display properly mgcp-messages in log 2017-07-25 15:15:22 +02:00
Philipp Maier e198087a15 msc-vty-complete 2017-07-25 15:15:22 +02:00
Philipp Maier 50643e419d msc_vlr: Fix tests: accomodate a_iface_tx_clear_cmd()
msc_vlr_tests.c: wrap a_iface_tx_clear_cmd(), adjust test expectations.

Change-Id: I01c099e62b3e3d74c4f567c0654e748d9d7e45d4
2017-07-25 15:14:16 +02:00
Philipp Maier e21c93fc96 osmo_msc: only clear A-Interface connections for GSM calls
The clear command is sent via the A-Interface for both,
A and IuCS connections. This is wrong.

Only send the clear command for connections related to
the A-Interface, which means only for connections where
the RAN is set to GERAN
2017-07-25 15:14:16 +02:00
Philipp Maier 956a2eb418 fixup: fix typo 2017-07-25 15:14:16 +02:00
Philipp Maier 90835e0083 mncc: make external mncc work
The external mncc currently does not work properly since the
MNCC_RTP_CREATE commands are removed due to the MSC-Split. It
is possible to operate without these commands, but then it is
not possible to route the RTP streams to an outside leg. Only
internal bridging is currenlty possible. This method is used
when the internal MNCC is enabled.

Add the missing MNCC_RTP_CREATE implementation.
Add logic to keep the old bridging mode working.
2017-07-25 15:14:16 +02:00
Philipp Maier 8643faad59 mgcp: display properly mgcp-messages in log
The generated mgcp messages are not displayed properly (stray
newlines). Also, the messages we receive are not displayed
at all.

Display generated and received messages in logtext, reformat
the strings properly so that the logtext does not get messed
up
2017-07-25 15:14:16 +02:00
Philipp Maier 03e1d5c7c5 fixup for: a_iface: fix missing clear command 2017-07-25 15:14:15 +02:00
Neels Hofmeyr 5bc821566f cosmetic: tweak error log in osmo_bsc_sigtran_init()
Change-Id: Iec3dbeb0ee1421129aaf9e313d616757955bee48
2017-07-25 15:14:15 +02:00
Philipp Maier b67fb4fc63 a_iface: fix missing clear command
When a subscriber connection is freed on the MSC side (the
conversion is over) the MSC should send a clear command to
the BSC in order to inform the BSC that the connection is
over. Currently this step is missing. Instead we wait for
the BSC to issue a clear request. This is not as it should
be, connections should be actively cleared by the MSC.

Add the missing clear command
2017-07-25 15:14:15 +02:00
Philipp Maier 4b36c7a34e a_iface: fix missing log output 2017-07-25 15:14:15 +02:00
Philipp Maier 15b06b9d3c a_iface: fix missing const 2017-07-25 15:14:15 +02:00
Philipp Maier 241f119d8e a_iface: add missing static 2017-07-25 15:14:15 +02:00
Philipp Maier 5938727956 msc_ifaces: add checks for nullpointers 2017-07-25 15:14:15 +02:00
Neels Hofmeyr ec49e842fe fixup: remove allocation/usage of iu struct again.
The allocation and usage of the iu struct was accidentally
re-introduced into a_iface_bssap.c.

Remove the allocation and the usage of iu struct.

Related to:
aoip: don't use iu struct: do not allocate unnecessary ue_conn_ctx
2017-07-25 15:14:15 +02:00
Philipp Maier 3ae6040afd osmo-bsc change bsc_handle_dt1() to bsc_handle_dt()
_dt1() is not applicable with the current setup, _dt() is
more accurate
2017-07-25 15:14:15 +02:00
Philipp Maier 9b0db3860c osmo-bsc: fix sccp name string
Change-Id: I4caf935fbeacc23d7a10766112ab844d6fc367ea
2017-07-25 15:14:15 +02:00
Philipp Maier 0317b106fe a_iface: remove unused variable
Change-Id: If964ac5344fa0275c07755b5a43d37ce186d3ca2
2017-07-25 15:14:15 +02:00
Philipp Maier 920420284c osmo-msc/a_iface/reset: add missing const
Change-Id: Id75918dfd891d9407a62a0b7cd9590932c858093
2017-07-25 15:14:15 +02:00
Philipp Maier ae33266f6c osmo-bsc/sigtran: add missing const
Change-Id: I36404b34b8a85fc98670a3eeb8aaf29a4a6f10ea
2017-07-25 15:14:15 +02:00
Philipp Maier ea452c93ca osmo-msc/a_iface: add missing assertions
Change-Id: If9eac28f70522edc42a9f169a7d12fed5936fb62
2017-07-25 15:14:15 +02:00
Philipp Maier 195cab61ab osmo-bsc: add missing comment
Change-Id: Iac59f2ff2f10997c636a8ac19427ed4a95dc99b5
2017-07-25 15:14:15 +02:00
Philipp Maier 23880357f2 osmo-bsc: add missing assertion
Change-Id: Ia7d4b0bff697acfa71ef616a12d78d17e3af4c20
2017-07-25 15:14:15 +02:00
Philipp Maier 2fd3a60ed8 osmo-msc: remove orphanned struct members
Change-Id: I229946cfe4ffa6de982586b1c2fa1117c3260e3a
2017-07-25 15:14:15 +02:00
Philipp Maier 569335bc34 osmo-msc: rename called/calling address in struct a_conn_info
Change-Id: I1b28652662d83f52db21cb78b512c501c7adf4bb
2017-07-25 15:14:15 +02:00
Philipp Maier 4c098cfb32 osmo-bsc: use better msc identifier
Using the MSC numbers in the logtext is not very expressive,
ise the SCCP-Addresses instead.

When creating the sccp instance and user, use more parseable
string than "MSC No.: n"

Change-Id: Ib56134193ba95538f63e09dc702dc3ff0e827a02
2017-07-25 15:14:15 +02:00
Philipp Maier d3f2ae8d6a osmo-bsc: fix typo
Change-Id: I154db5bcaada8f5503ca8700644abf00f511ff6e
2017-07-25 15:14:15 +02:00
Philipp Maier faa1b9dd0a osmo-bsc: vty: fix error message
The warning message that is displayed when a non standard SSN is
set is confusing.

Make warning message more expressive.

Change-Id: I5283bcc5acf4739d468fe43937f0e59f44dee3d9
2017-07-25 15:14:15 +02:00
Neels Hofmeyr f85f656b18 build: osmo-bsc_nat: add missing sigtran LDADD
Change-Id: Ia3031232a3a44b8e8a665610a2fd1cf0a7e55b22
2017-07-25 15:14:15 +02:00