cellular-infrastructure
/
osmo-mgw
mirror of https://gerrit.osmocom.org/osmo-mgw
10
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000005 2023-12-23 06:13:02 +00:00 committed by Gerrit Code Review
parent 1e98e175c5
commit d1491b0cdf
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
3ea1382637b19d895a79cddcbf242c171f66ccf6
View File

@ -16,6 +16,41 @@
"message": "So now this log line can be dropped? it makes no sense to print twice imho.",
"revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "5eb76095_3dbdd07e",
"filename": "src/libosmo-mgcp-client/mgcp_client.c",
"patchSetId": 1
},
"lineNbr": 376,
"author": {
"id": 1000005
},
"writtenOn": "2023-12-23T06:13:02Z",
"side": 1,
"message": "it would be the other one below, with the \"_pt:\" label...",
"parentUuid": "0ec36c09_ca30d24f",
"revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9dcb8c57_78d220c1",
"filename": "src/libosmo-mgcp-client/mgcp_client.c",
"patchSetId": 1
},
"lineNbr": 382,
"author": {
"id": 1000005
},
"writtenOn": "2023-12-23T06:13:02Z",
"side": 1,
"message": "...this one.\nI think it\u0027s not harmful to also print the SDP string that failed to parse.\nIf you think it\u0027s too verbose for LOGL_ERROR, then we can put either the above or this one on DEBUG log...?",
"revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}