From d1491b0cdf5c83f07da7c895c66fd29610f3bc75 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326> Date: Sat, 23 Dec 2023 06:13:02 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (2 comments) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"} --- 3ea1382637b19d895a79cddcbf242c171f66ccf6 | 35 ++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/3ea1382637b19d895a79cddcbf242c171f66ccf6 b/3ea1382637b19d895a79cddcbf242c171f66ccf6 index 1547a5231..96749d126 100644 --- a/3ea1382637b19d895a79cddcbf242c171f66ccf6 +++ b/3ea1382637b19d895a79cddcbf242c171f66ccf6 @@ -16,6 +16,41 @@ "message": "So now this log line can be dropped? it makes no sense to print twice imho.", "revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "5eb76095_3dbdd07e", + "filename": "src/libosmo-mgcp-client/mgcp_client.c", + "patchSetId": 1 + }, + "lineNbr": 376, + "author": { + "id": 1000005 + }, + "writtenOn": "2023-12-23T06:13:02Z", + "side": 1, + "message": "it would be the other one below, with the \"_pt:\" label...", + "parentUuid": "0ec36c09_ca30d24f", + "revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "9dcb8c57_78d220c1", + "filename": "src/libosmo-mgcp-client/mgcp_client.c", + "patchSetId": 1 + }, + "lineNbr": 382, + "author": { + "id": 1000005 + }, + "writtenOn": "2023-12-23T06:13:02Z", + "side": 1, + "message": "...this one.\nI think it\u0027s not harmful to also print the SDP string that failed to parse.\nIf you think it\u0027s too verbose for LOGL_ERROR, then we can put either the above or this one on DEBUG log...?", + "revId": "3ea1382637b19d895a79cddcbf242c171f66ccf6", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file