Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004 2023-11-22 12:10:16 +00:00 committed by Gerrit Code Review
parent a2c727fa18
commit 39200c23bd
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"message": "maybe add an else path here that logs an error and goes to free_ret?",
"revId": "fed4bf196a3f96ceaf02b549f2fb72df82d9e08b",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "e35133bc_44e59877",
"filename": "src/osmo-hnodeb/rtp.c",
"patchSetId": 2
},
"lineNbr": 335,
"author": {
"id": 1000004
},
"writtenOn": "2023-11-22T12:10:16Z",
"side": 1,
"message": "why/where / what should that clause do? The existing code in rtp_get_bound_addr \"does the right thing\" for local INADDR_ANY/IN6ADDR_ANY. In all other cases, conn-\u003eloc_addr already contains a specific local address and hence there\u0027s nothing to do.",
"parentUuid": "bc31ae2f_eaeaa871",
"revId": "fed4bf196a3f96ceaf02b549f2fb72df82d9e08b",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}