osmo-hnodeb/fed4bf196a3f96ceaf02b549f2f...

39 lines
1.2 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "bc31ae2f_eaeaa871",
"filename": "src/osmo-hnodeb/rtp.c",
"patchSetId": 2
},
"lineNbr": 335,
"author": {
"id": 1000147
},
"writtenOn": "2023-11-22T07:55:16Z",
"side": 1,
"message": "maybe add an else path here that logs an error and goes to free_ret?",
"revId": "fed4bf196a3f96ceaf02b549f2fb72df82d9e08b",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "e35133bc_44e59877",
"filename": "src/osmo-hnodeb/rtp.c",
"patchSetId": 2
},
"lineNbr": 335,
"author": {
"id": 1000004
},
"writtenOn": "2023-11-22T12:10:16Z",
"side": 1,
"message": "why/where / what should that clause do? The existing code in rtp_get_bound_addr \"does the right thing\" for local INADDR_ANY/IN6ADDR_ANY. In all other cases, conn-\u003eloc_addr already contains a specific local address and hence there\u0027s nothing to do.",
"parentUuid": "bc31ae2f_eaeaa871",
"revId": "fed4bf196a3f96ceaf02b549f2fb72df82d9e08b",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}