cellular-infrastructure
/
osmo-hlr
mirror of https://gerrit.osmocom.org/osmo-hlr
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000230 \u003c1000230@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000230\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000230\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000230 2023-09-18 18:29:54 +00:00 committed by Gerrit Code Review
parent 4838d34036
commit 1d49a0cef3
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
da05bc066ebc94eda14dfcf364a30e50211010bc
View File

@ -88,6 +88,24 @@
"revId": "da05bc066ebc94eda14dfcf364a30e50211010bc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "c974108c_a1eacc3b",
"filename": "include/osmocom/hlr/hlr_sms.h",
"patchSetId": 2
},
"lineNbr": 17,
"author": {
"id": 1000230
},
"writtenOn": "2023-09-18T18:29:54Z",
"side": 1,
"message": "The existing euse_del() and ussd_route_del() functions don\u0027t have those \"free\" semantics you just stated: instead they require the pointer to be valid (not NULL) and they perform the llist_del() step (unlinking from the global lists of EUSEs and USSD routes) before the final talloc_free(). My new smsc_del() and smsc_route_del() functions are exactly the same.",
"parentUuid": "c3f853fa_dd6d58db",
"revId": "da05bc066ebc94eda14dfcf364a30e50211010bc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {