cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

inter-BSC HO incoming: drop old/wrong RTP port code 

Drop nonsensical legacy code.

The Circuit Identifier Code in A/SCCPlite does *not* indicate the RTP port to
use. Rather, it indicates the MGW endpoint name to use when configuring the
BSC's side of the MGW endpoint, and only the MGW will ever know the RTP port.

Change-Id: I471bd5e5cc2a083dd37290aeaae5c334ca5f7eed
This commit is contained in:
Neels Hofmeyr 2018-08-27 21:50:47 +02:00
parent 4c6d3ea513
commit d8b41fc677
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/osmo-bsc/handover_fsm.c
View File

@ -487,25 +487,8 @@ static bool parse_ho_request(struct gsm_subscriber_connection *conn, const struc
OSMO_STRLCPY_ARRAY(req->cell_id_target_name, gsm0808_cell_id_name(&req->cell_id_target));
if ((e = TLVP_GET(tp, GSM0808_IE_CIRCUIT_IDENTITY_CODE))) {
int timeslot;
int multiplex;
/* CIC is permitted in both AoIP and SCCPlite */
req->msc_assigned_cic = osmo_load16be(e->val);
/* For SCCPlite, the CIC implies the RTP port to use */
if (sccplite) {
timeslot = req->msc_assigned_cic & 0x1f;
multiplex = (req->msc_assigned_cic & ~0x1f) >> 5;
req->msc_assigned_rtp_port = mgcp_timeslot_to_port(multiplex, timeslot,
conn->sccp.msc->rtp_base);
LOG_HO(conn, LOGL_DEBUG, "Derived RTP port from MSC assigned CIC:"
" CIC=0x%x (timeslot=%d multiplex=%d) rtp_base=%d=0x%x RTP-port=%u\n",
req->msc_assigned_cic, timeslot, multiplex,
conn->sccp.msc->rtp_base, conn->sccp.msc->rtp_base,
req->msc_assigned_rtp_port);
}
} else if (sccplite) {
/* no CIC but SCCPlite: illegal */
LOG_HO(conn, LOGL_ERROR, "SCCPlite MSC, but no CIC in incoming inter-BSC Handover\n");