cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

inter-BSC HO incoming: continue despite missing Classmark 

3GPP mandates either Classmark Information 1 or 2 in BSSMAP Handover Request,
but an SCCPlite MSC currently tested does not pass either of them. Make this
missing IE a non-fatal error, continuing anyway should work out.

See 3GPP TS 48.008, 3.2.1.8 HANDOVER REQUEST, where it says "Classmark
Information 1 or Classmark Information 2" with note 6: "One of these two
elements is sent."

Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11
This commit is contained in:
Neels Hofmeyr 2018-08-27 21:49:18 +02:00
parent 4122c15ea9
commit 4c6d3ea513
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/osmo-bsc/handover_fsm.c
View File

@ -424,10 +424,10 @@ static bool parse_ho_request(struct gsm_subscriber_connection *conn, const struc
}
memcpy(&req->classmark.classmark2, e->val, len);
req->classmark.classmark2_len = len;
} else {
LOG_HO(conn, LOGL_ERROR, "Missing IE: either Classmark Information 1 or 2 required\n");
return false;
}
} else
LOG_HO(conn, LOGL_INFO,
"Missing mandatory IE: 3GPP mandates either Classmark Information 1 or 2"
" in BSSMAP Handover Request, but neither are present. Will continue without.\n");
if (TLVP_PRESENT(tp, GSM0808_IE_AOIP_TRASP_ADDR)) {
int rc;