cellular-infrastructure
/
libasn1c
mirror of https://gerrit.osmocom.org/libasn1c
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+2

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000147 <1000147@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2, a69f91bcb12593452de834cf121ab57d6651a44d
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000147\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000147\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000147 2023-03-21 15:24:34 +00:00 committed by Gerrit Code Review
parent 720e87e9af
commit 11aa8fc753
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
6fa00c35f906b164a5f3eab946edebdf4da8212d
View File

@ -16,6 +16,24 @@
"message": "Did you try moving that +\u003d before the loop and see if it improves?",
"revId": "6fa00c35f906b164a5f3eab946edebdf4da8212d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "358149af_0045c1c3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2023-03-21T15:24:34Z",
"side": 1,
"message": "Same behavior:\n\n```\nINTEGER.c: In function ‘asn_int642INTEGER’:\nINTEGER.c:1341:8: error: array subscript 0 is outside array bounds of ‘int64_t[1]’ {aka ‘long int[1]’} [-Werror\u003darray-bounds]\n 1341 | pend1 +\u003d add;\n | ~~~~~~^~~~~~\nINTEGER.c:1296:42: note: while referencing ‘value’\n 1296 | asn_int642INTEGER(INTEGER_t *st, int64_t value) {\n | ~~~~~~~~^~~~~\n```",
"parentUuid": "01955287_edbde7dc",
"revId": "6fa00c35f906b164a5f3eab946edebdf4da8212d",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}