Commit Graph

203 Commits

Author SHA1 Message Date
Harald Welte dff765869c WIP: contrib/jenkins.sh: Verify build with and without dahdi trunkdev
Change-Id: I36a1b5b4ee2c797e53f816c5ac99adf985987f02
2023-09-13 15:50:28 +02:00
Pau Espin faedcec65c Bump version: 0.5.0.11-b7c9-dirty → 0.6.0
Change-Id: I8d5e3ffd928fa65bc3d3b43553fcd6774a7812dc
2023-09-12 13:30:07 +02:00
Harald Welte b7c963f209 octoi: Add force-send-all-ts mode
This new mode (can be enabled per account) will force the E1OIP
protocol to always send all timeslots, i.e. not do any of the
suppression of timeslots that do not exhibit any change to the
previous E1 frame.

Change-Id: I6d17d3829b2c1c62e701a1d8c021d93d93593613
2023-08-14 07:54:10 +02:00
Harald Welte f07d38a6eb e1d-ts-pipe: Assert that osmo_fd_register() succeeds
Fixes: CID#307497: Unchecked return value (CHECKED_RETURN)
Change-Id: Ie2abd580e37d7d58c507d12105ec2130fb533ed9
2023-07-18 14:04:14 +02:00
Harald Welte 27cfff6ad0 octoi: Fix missing check of osmo_fsm_register() return value
Fixes: CID#307511: Unchecked return value (CHECKED_RETURN)
Change-Id: Ia474a6c078f1aec3d04be494a888ffe87b199f5a
2023-07-18 14:02:02 +02:00
Harald Welte 3dabaf3636 proto_srv: Fix file descriptor and memory leak in error paths
Fixes: CID#307517
Change-Id: I44e349eee5b0b54843762db8cadd6b9b1758faa4
2023-07-18 14:00:09 +02:00
Harald Welte 06ab6a991f Check return code of fcntl() in several plaaces
Fixes: CID#307539, CID#307533
Change-Id: I46843174eb4699a59421dc3f3b900a3894c67081
2023-07-18 13:57:21 +02:00
Oliver Smith cd813cde13 systemd: depend on networking-online.target
Related: SYS#6400
Change-Id: I29e547242b2ed1cfc4750c7d7e5f8636c2e8f3dc
2023-05-26 14:10:44 +02:00
Philipp Maier 580bb374ae proto_clnt: use osmo_fd_close to close the socket on connection loss
When the socket is closed due to a connection loss, we currently use
close(). This is not enough since this will not remove the file
descriptor from the select loop. Let's use osmo_fd_close.

Related: OS#5983
Change-Id: I702b944baf2ebbcc84b6a211e245a4a41627bde6
2023-05-02 15:36:20 +02:00
Oliver Smith daaa2fedcb debian: set compat level to 10
Related: OS#5958
Change-Id: Id0f168a7d3c2ae6869121397e65ca1d0cfea30d3
2023-04-25 16:48:21 +02:00
Philipp Maier 9f55c47e7b proto_clnt: close osmo-e1d control socket on connection loss
When osmo-e1d is terminated the socket file descriptor on the client
side will get permanent POLLHUP events. This means that the registered
callback gets called with flags OSMO_FD_READ but the received data will
be of length zero. We must detect this situations and close the file
descriptor on connection loss. Otherwise we would get called over and
over again in an endless loop, resulting in 100% CPU usage.

Related: OS#5983
Change-Id: I3e1a29a9701a9432f58ef7cfedc32c916203017a
2023-04-20 14:38:17 +02:00
Philipp Maier 28c437675f proto_clnt: fix function prototype
The function prototype for osmo_e1dp_client_destroy has a different
parameter name in its signature in proto_clnt.h than in prto_clnt.c,
let's rename it so that both are coherent. (srv -> clnt)

Change-Id: I8bd4fbdf2bda332870da1b915a7898c396a85b0f
2023-04-20 14:34:46 +02:00
Oliver Smith d20d82442a Run struct_endianness.py
Ensure there is no diff to prepare to run this in CI.

Related: OS#5884
Change-Id: If070a3204d47f71d47e01276fe16323f8af8cb4a
2023-02-20 10:46:00 +01:00
Pau Espin 7d2df40c69 Bump version: 0.4.0.26-8aba-dirty → 0.5.0
Change-Id: I178d34a67cba0359b16fe27fa30b2145703a2909
2023-02-07 11:57:43 +01:00
Harald Welte 8aba31092f DAHDI trunkdev support
DAHDI trunkdev is a newly-introduced 'virtual trunk' character device
which is used instead of a real hardware driver. This means that an
application (such as osmo-e1d) can implement a virtual E1 trunk and
receive and transmit E1 frame data which is exposed to DAHDI users
just like the data from a real physical E1 span.

In order to build DAHDI trunkdev support into osmo-e1d, you will need
a special fork of dahdi containing the required support, currently
the laforge/trunkdev branch of the following repository:
	https://gitea.osmocom.org/retronetworking/dahdi-linux

Change-Id: Ib15a7313fcd63e1ed9f2f5b349df967bc4335ec2
2023-02-01 11:24:49 +01:00
Christoph Lauter 632517011d Increasing max FIFO size for feature request 5875, adapting tests
Change-Id: Iae76d87cf436c80c005a2f8fce5a30f74f7e4545
2023-01-26 09:45:45 -07:00
arehbein ad15cf4397 osmo-e1d: Transition to use of 'telnet_init_default'
Related: OS#5809
Change-Id: I68fafc519d7c7ca9788bfcad7be1fadbb208cebe
2022-12-19 22:34:39 +01:00
Oliver Smith df67b3535a contrib/spec: add /etc/osmocom/osmo-e1d.cfg
Fix that the file only got installed to /usr/share as example, but not
to /etc/osmocom in the rpm packaging.

Related: OS#5817
Change-Id: I4ffa23f7ab26b7ed3cba04aed4f57eeaa3edca31
2022-12-08 15:59:47 +01:00
Oliver Smith f42b490064 doc/examples: only install osmo-e1d.cfg to /etc
Adjust OSMOCONF_FILES, so only osmo-e1d.cfg of the examples gets
installed to /etc/osmocom/. All other examples still get installed to
/usr/share, as it is intended.

Related: OS#5817
Change-Id: Ic449b7d38ed50add0164f056574d4da47530eb49
2022-12-08 15:59:28 +01:00
Harald Welte 4c81e74199 update .gitignore with files from manuals + doxygen
Change-Id: I952574e4b29db69ca767138b77b0aac4dbfd8973
2022-11-10 02:07:19 +01:00
Harald Welte 20419bdf55 doxygen API documentation for libosmo-e1d
If we actually expect 3rd party applications to use libosmo-e1d to talk
to osmo-e1d, we'd better add some basic documentation on how this API
shall be used.

Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
2022-11-07 14:43:53 +01:00
Harald Welte e443318da4 jenkins.sh: Support for building + publishing the manual
Change-Id: Ic399662e6ac5e5e7f999e6e7127df9a9580a0627
2022-11-07 14:36:51 +01:00
Harald Welte 03d9c3215c Initial user manual for osmo-e1d
Still quite incomplete, but significantly better than nothing.

Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281
2022-11-07 10:26:37 +00:00
Oliver Smith 533cf1e4d7 gitreview: new file
Change-Id: I32ef094163ad157c6174730fa4f0b51038280107
2022-11-07 10:20:17 +00:00
Harald Welte 1d4cf36e2a Add support of RPM package building via osmo-e1d.spec.in
Change-Id: If9d3d4b7b06aef156fd895415db3b30bdecd74b4
2022-11-07 11:03:29 +01:00
Harald Welte 5806606ce5 avoid segfault in 'show interface' of absent icE1usb
Don't segfault when processing a "show interfaces" for an interface
that is configured via VTY but not actually attached/found in the
system:

usb.c:693:29: runtime error: member access within null pointer of type 'struct e1_usb_intf_data'

Depends: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30019
Depends: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30020
Change-Id: I2ce990bb57f6ae4edb3a99a4b7bf26a49f362410
2022-11-05 22:26:07 +01:00
Harald Welte 7f204ac42a osmo-e1d: Add the usual '-V' / '--version' command line argument
Change-Id: Ie2d79c44e580ffa6555f87b969206047ffb7eb6f
2022-11-03 10:18:54 +01:00
Harald Welte 81546e6773 Differentiate between icE1usb and e1-tracer in log/vty output
Now that we support the e1-tracer in addition to icE1usb, let's
differentiate in the log output.

Change-Id: Iea647b12d86c97cfacbc3df43010b9b94f0a97c7
2022-11-02 09:42:04 +01:00
Harald Welte 7533197639 usb.c: Bail out of e1-tracer doesn't accept set_configuration(2)
This likely means it's not an e1-tracer after all, or it's an old
firmware that doesn't yet expose the e1d-compatible USB configuration.

Related: OS#5734
Change-Id: If5a9bc20084d84885d5d97b4f982e94801612d24
2022-11-01 18:24:29 +01:00
Harald Welte cfe7ab300e osmo-e1d-pipe: Add command line option for --force open of timeslot
This exposes the existing capability of force-opening a timeslot via a
command-line argument.

Related: OS#5735
Change-Id: Ieefc89f2e48e9124ae744a587739ff3948110944
2022-11-01 18:09:17 +01:00
Harald Welte 5077657f57 ctl: Prevent clients from opening TS0
This doesn't work, as the mux_demux.c code doesn't pass the TS0 bitstream
to users anyway.  So let's reject clients attempting this.

Change-Id: Idb2d20da7de72dad38ae2fccdd7630677d0f0cc8
2022-11-01 17:01:48 +01:00
Harald Welte 64e1889f99 support for e1-tracer hardware
Recent work on the e1-tracer firmware is introducing a set of USB
descriptors (as configuration 2) that are mostly compatible to how
osmo-e1d talks to icE1usb.

The main difference is that there's only one ISO IN endpoint per USB
interface, and no ISO OUT or ISU FB endpoints.  So we introduce some
minor adjustments here to accommodate that.

Related: OS#5733
Closes: OS#5734
Change-Id: I855e18c0f229bd473123f96303e60ab2de90677f
2022-11-01 17:00:25 +01:00
Sylvain Munaut 56a79f60e1 usb: Claim and set interface alt-setting only for used lines
If a line is not auto-created, there is no point on claiming the
matching interface and even less point setting the alt setting that
will try to use USB isoc bandwith.

With this you can no use only line 1 and not line 0 of a ice1usb
for instance. While previously it would still "enable" line 0 and
then line 1 would fail because on BW issues most of the case.

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: Iea5d72272f11875e7a32c78b60c188590deda831
2022-10-12 22:18:02 +02:00
Sylvain Munaut 6005fb3ea8 octoi: Prevent segfault on 'show octoi-clients if a client has no line
This can happen if the specified device in the config isn't plugged
in for instance, no line is created ...

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I594463591f2945a04ccd708f16788034cc1dfc57
2022-10-12 22:16:12 +02:00
Sylvain Munaut 9d45233337 vty: Add option to disable GPS-DO loop and use manual tuning values
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I8668fe42e4c399f08696e497887120e501341f5a
2022-10-06 10:44:18 +02:00
Sylvain Munaut a810249f9a usb: Fix ICE1USB_INTF_SET_GPSDO_MODE request parameter
This call takes its argument in wValue rather than as payload

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: Ibeebe3184a4744bd0cd9f5a19db84c12fab18806
2022-10-06 10:44:18 +02:00
Sylvain Munaut f3e77ceed9 usb: Fix the length field of ICE1USB_INTF_SET_GPSDO_TUNE request
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: Ibf1b1440696902757f4b1c1d9c4d80c1da453a36
2022-10-06 10:44:18 +02:00
Sylvain Munaut 3b3ec3ae3e Add osmo-e1gen to .gitignore
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I488b7eb2be52b59750ea780e4480923e423a1a66
2022-10-06 10:44:18 +02:00
Sylvain Munaut b7b6057e76 usb: Add support for new GPSDO status field "Accumulated error"
Because we want to handle older firmwares too, we need to excepect
we might get a smaller structure !

(We can't get a larger one since the wLength we send is limited to
the structure we know)

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846
2022-10-06 10:44:18 +02:00
Oliver Smith 6cd951d714 octoi_srv_fsm: fix implicit fall-through
Found by gcc (Debian 10.2.1-6) 10.2.1 20210110, which fails the build
with --enable-werror because of this.

Change-Id: Ib717df376a4b414f787168c2c632f04f0c51271b
2022-07-12 13:17:23 +02:00
Pau Espin 802943055d Bump version: 0.3.0.72-bb13-dirty → 0.4.0
Change-Id: Ia3b429acd866ab644a9d9a848d69bd9627dcd840
2022-06-29 12:09:55 +02:00
Harald Welte bb131026cd README.md: Fix syntax for hyperlinks
Change-Id: I0648d816dbfa51caac11920bacc16925e179223c
2022-06-18 11:59:44 +02:00
Harald Welte e185b4ee32 update git URLs (git -> https; gitea)
Change-Id: I1700d5d69aa622cde7f832a0e754969ba465a8c7
2022-06-18 11:59:44 +02:00
Harald Welte 61e4d2c4ac e1oip: Make batching-factor and prefill-frame-count configurable
This adds VTY commands at the 'account' level to configure those
settings.  They will only become active on the next [re]connect
of the line.

Change-Id: Ic455ef0ef82867db512e2ffdff24d9dd42d47eeb
2022-05-08 09:40:43 +02:00
Harald Welte d78ddab9ff e1oip: introduce #defines for BATCHING_FACTOR / PREFILL_COUNT
Change-Id: Ia0da9b038312b010bfdf88570733bf1bf004b7a8
2022-05-08 09:19:47 +02:00
Harald Welte 25945a818b octoi: Send ECHO_REQ every 10s and update the related stat_item
As soon as an OCTOI connection gets into ACTIVE state, send a
ECHO_REQ every 10s and compute the RTT at the time of receiving
the response.

Contrary to the initial idea, the stat item contains the RTT (round trip
time) measured in micro-seconds.  Changing this is not a problem as so
far the RTT was always reported as '0', and 0ms == 0us.

Change-Id: Id331319bff1cf6896fee37acc45846a2491ca92d
2022-05-01 11:22:06 +02:00
Harald Welte 18a05ecd7c octoi: only memcpy() if it is present in _octoi_tx_echo()
If the caller specifies zero-length data or a NULL pointer, don't
attempt to call memcpy() on that.

Change-Id: I5f5ed937643162d6ef6ce0cf2908432c007943c1
2022-05-01 11:22:06 +02:00
Harald Welte 0d813b5947 e1oip: Add rate_ctr for rx + tx packet / byte count
This allows to monitor the traffic utilization of each e1oip line.

Change-Id: Ifde6be0b7d3c5767b684cb8fbbc58bbd5cfb0714
2022-05-01 11:22:06 +02:00
Harald Welte 92f9ddc468 e1oip: fix line counter descriptions
The direction is wrong in two counter descriptions

Change-Id: Ia294af4b30eec1b32c4b15892751d360608c8333
2022-04-23 11:00:59 +02:00
Harald Welte e8e62c4b31 octoi: Support setting IP DSCP and socket priority via VTY
Let's allow setting IP DSCP and socket priority via the VTY.

Note that you must still manually add a kernel egress QoS map from
socket priority to IEEE P802.1p PCP (Priority Code Point) like this:

	ip link set dev eth0.7 type vlan egress-qos-map 0:0 1:1 5:5 6:6 7:7

This will create 1:1 mappings for socket priorities 0, 1, 5, 6 and 7 to
the respective IEEE PCP.  A higher PCP typically means higher priority,
where voice is traditionally using "5".

Change-Id: Ic5a6c5a0ec67beb40be4ca95326aca5072a28958
2022-04-21 09:14:42 +02:00