Update patch set 1
Patch Set 1: Code-Review+1 (1 comment) Patch-set: 1 Reviewer: Gerrit User 1000011 <1000011@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"tnt replied on the change"} Attention: {"person_ident":"Gerrit User 1000011 \u003c1000011@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"tnt replied on the change"}
This commit is contained in:
parent
072695fc16
commit
d1802c1072
|
@ -0,0 +1,21 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "242f894f_25846334",
|
||||||
|
"filename": "firmware/ice40-riscv/e1-tracer/e1.c",
|
||||||
|
"patchSetId": 1
|
||||||
|
},
|
||||||
|
"lineNbr": 280,
|
||||||
|
"author": {
|
||||||
|
"id": 1000011
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-11-01T19:22:47Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I wouldn\u0027t rename it.\n\nIn icE1usb we have e1_start(int port) and ultimately I\u0027d like e1.{c,h} to be shared between the two.\n\n(usb_e1 will most likely stay separate because there\u0027ll be too much difference there, but the driver for the E1 hw shouln\u0027t be all that different ultimately)",
|
||||||
|
"revId": "fced9a7147a16e32927a85534e274645d4ba5ed0",
|
||||||
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue