4238339176
CID:1023970 Unused pointer value
2014-05-16 19:53:23 +00:00
6a8002db79
CID:1024582 Logically dead code
2014-05-16 19:27:25 +00:00
21a5d166c6
CID:1024581 Logically dead code
2014-05-16 19:22:37 +00:00
c1f7887039
CID:1024580 Logically dead code, x will always be > 1
2014-05-16 19:19:31 +00:00
73c1e09269
CID:1024579 Logically dead code
2014-05-16 19:09:18 +00:00
3666029ff0
add auth-subscriptions flag. sofia ua can now optionally challenge subscrition requests
2014-05-16 19:05:35 +00:00
9b1ebff8de
CID:1024270 Dereference before null check
2014-05-16 18:54:50 +00:00
7d5434f57c
CID: 1214223-1214230 If sent an invalid registration authentication header with multiple params of the same name, then only use the first of the params instead of leaking memory
2014-05-16 11:50:18 -07:00
54fc2f5e39
CID:1023975 Unused pointer value
2014-05-16 18:49:23 +00:00
a67389ad5c
CID:1025879 Logically dead code
2014-05-16 18:20:25 +00:00
ecde431730
CID:1025850 Dereference before null check
2014-05-16 18:15:34 +00:00
b10c865c25
CID:1025849 Dereference before null check
2014-05-16 18:12:28 +00:00
a997331577
CID:1214125 https://scan6.coverity.com:8443/docs/en/cov_checker_ref.html#static_checker_BUFFER_SIZE
2014-05-16 13:30:27 -04:00
269db09015
don't leak on xferext ivr event, CID:1214232 Resource leak
2014-05-16 14:50:18 +00:00
65d9cf62c9
CID:1214237 String not null terminated
2014-05-16 14:41:42 +00:00
455ed10e40
CID:1214130 Buffer not null terminated
2014-05-16 14:37:43 +00:00
ebc0a99f1c
CID:1024250 Dereference before null check. CID:1024251 Dereference before null check, we don't need tto check these, as they are already used above in all cases
2014-05-15 18:34:25 +00:00
4653d78154
CID:1087387 Unused pointer value
2014-05-15 18:30:03 +00:00
44401e842a
CID:1023936 Unused pointer value
2014-05-15 17:00:32 +00:00
b7b14209eb
CID 1214210: mod_ssml - resource leak when parsing SSML
2014-05-15 11:31:04 -04:00
d055f5b6df
CID 1214263: mod_ssml - remove unused pointer value
2014-05-15 11:12:06 -04:00
d8d58fde63
CID:1214141 Buffer not null terminated
2014-05-15 14:26:29 +00:00
1b0bdaf85e
CID:1214212 Resource leak in voicemail_list
2014-05-15 14:11:39 +00:00
4e888a282c
CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing
2014-05-15 14:09:38 +00:00
d2884ac5a6
CID:1214211 Resource leak
2014-05-15 13:58:08 +00:00
0469db0305
CID:1214200 Dereference null return value
2014-05-15 13:47:24 +00:00
92c6f3abc5
CID:1214192 Dereference after null check, don't crash when no file name passed on file open
2014-05-15 13:37:26 +00:00
179e07c649
CID:1214219 Resource leak
2014-05-15 13:30:39 +00:00
07b6bba68b
CID:1214209 Resource leak, don't leak event populated by switch_channel_get_variables
2014-05-15 13:22:51 +00:00
452d7a3793
CID:1214163 Unchecked return value, check return value of switch_ivr_play_file and bail out if it fails
2014-05-15 13:18:58 +00:00
7c72e94a67
CID:1214158 Buffer not null terminated
2014-05-15 12:42:49 +00:00
68825ff4f1
CID:1214220 Resource leak
2014-05-15 12:41:09 +00:00
619b31e1e8
CID:1214140 Buffer not null terminated, make sure hostname is always null terminated
2014-05-15 12:38:41 +00:00
16805187ec
CID:1214256 Unused pointer value
2014-05-15 12:36:36 +00:00
128601316f
CID:1214255 Unused pointer value
2014-05-15 12:34:50 +00:00
19f3ab5182
CID:1214218 fix memory leak in conference_event_channel_handler
2014-05-15 12:33:15 +00:00
622cd21009
CID:1214231 don't leak when using invalid syntax
2014-05-15 12:27:39 +00:00
bdbefdcc48
CID:1087631 In the unlikely case the sprintf fails, free the memory instead of leak it
2014-05-14 19:56:32 -07:00
bf8b88cddd
CID: 1210583
2014-05-14 19:37:57 +00:00
b263201a2e
Avoid polluting CFLAGS for mod_snmp
...
Putting `net-snmp-config --cflags` into CFLAGS causes major pollution;
it overrides optimization and debugging levels, warnings, and more.
While normally we do want to automatically locate library headers,
there has to be a better way to do this. libsnmp is normally in the
usual place and doesn't need special handling. Perhaps people with
libsnmp in a weird place should just need to add the -I flag to their
CFLAGS before build.
2014-05-13 17:40:43 +00:00
94ec447e0d
Cleanup makefile library dependencies of mod_snmp
...
Calling out to net-snmp-config --agent-libs causes transitive
dependencies to get pulled in, but we don't need those -- a sensible
dynamic linker pulls those in automatically. Trying to track the
transitive dependencies manually would be a losing battle.
People were recently hitting this on Debian sid/jessie, where libpci
is in the transitive dependency list but isn't otherwise one of our
build dependencies.
2014-05-13 17:27:46 +00:00
cbe6f74fa9
FS-6285 skypopen: ANY, RR NOT work fine in mod_skypopen
2014-05-13 11:00:47 +02:00
7dbab7b1c6
FS-6517 skypopen: mod_skypopen not using configured context with mod_sms chatplan with PATCH, thanks Russell Treleaven
2014-05-12 16:07:39 +02:00
9a1c4f6827
don't pass large strucutre by value
2014-05-12 09:31:12 -04:00
3e18f08796
clean up coverity warnings and improve error checking
2014-05-12 09:08:52 -04:00
717bcf617e
FS-6515 --resolve
2014-05-10 00:35:32 +05:00
be56bbb7ae
let relay work if its the only option
2014-05-09 01:14:52 +05:00
31069f33a2
generate the modules list vars from modules.conf into a file instead of on the fly every time
2014-05-08 15:59:49 -04:00
c4f38f8d0d
CID: 1211940 mod_rayo - unlikely dereference of NULL pointer
2014-05-08 12:11:15 -04:00
42108871c9
CID: 1211941 mod_rayo - unlikely dereference of NULL pointer
2014-05-08 12:10:01 -04:00
17848d26be
CID: 1211943 mod_rayo - removed dead code when changing output speed
2014-05-08 12:03:28 -04:00
a72137d4ae
CID: 1211944 mod_rayo - remove set of unused pointer
2014-05-08 11:47:38 -04:00
58fea2544b
CID: 1211946 mod_rayo - dead code after switch statement
2014-05-08 11:36:05 -04:00
873acb2975
CID: 1211947 mod_rayo - allocated array with unsigned char * element size instead of unsigned char
2014-05-08 11:33:27 -04:00
4f4fb9e942
CID: 1211951 mod_rayo - fix unlikely dereference of null pointer
2014-05-08 11:30:53 -04:00
84eb4a0404
mod_rayo: re-added Makefile for iks helpers unit tests
2014-05-08 11:16:02 -04:00
d7d4625866
mod_rayo: re-added Makefile for srgs unit tests
2014-05-08 11:14:20 -04:00
752f7956f9
mod_rayo: fix compiler error to nlsml.c from attempted coverity fix
2014-05-08 11:10:42 -04:00
02f6269cf1
check for say errors in say_money functions
2014-05-07 13:18:21 -04:00
2459e710f7
FS-6337 prevent over-frequent jb resets in bad conditions
2014-05-07 22:12:18 +05:00
ee6f3da9ff
CID: 1211948 fix memory leak of decoded iks message in function parse_plain_auth_message in mod_rayo
2014-05-07 00:44:54 -07:00
2a50bbba68
CID: 1211950 fix memory leak of iksparser in function nlsml_parse in mod_rayo
2014-05-07 00:37:32 -07:00
ad327dffc8
CID: 1211946 fixing uninitialized pointer read in mod_translate
2014-05-07 00:22:56 -07:00
4a543b29a2
FS-6506 --resolve Technically when you are not using groups you do not add a <users> tag inside <domain> you just put several <user> tags in <domain> This patch will consume an extraneous <users> tag and move on making it work either way.
2014-05-07 00:06:02 +05:00
d6fe10979d
remove opezap from tree, it has been replaced by freetdm
2014-05-06 11:05:54 -04:00
3ff3f327ee
FS-6484: guess at fixing seg from mod_managed, this function should never be called without a channel, but if it does, throw an error instead
2014-05-05 19:19:03 -04:00
0a2ba8869a
sofia is treating all notify sending as if they were natted rather than when nat is detected. This causes issues on some polycoms that use strange ports in their contact for getting notifies that do not match the port the calls come from
2014-05-06 04:10:19 +05:00
38abcf7e2c
The APIs for spandsp FAX have changes, removing one of the parameters passed in
...
the callbacks.
2014-05-04 17:22:28 +08:00
9db6d5ba9c
different distros have diff pkg names
2014-05-02 18:35:37 -04:00
974cebd389
SIP-686 changed mod_say (en) to speak full dates when asked to speak a date in the future (rather than only weekday and time).
2014-05-02 14:48:09 -05:00
607247397c
FS-6413 update presence_epoch to lock to midnite
2014-05-02 23:49:46 +05:00
317f4b1442
Fix building with musl libc
...
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)
limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
fc40e4ab79
Avoid leaking data_buf in mod_conference
...
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated. On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
db1a2de186
don't null check what we know won't be null
2014-05-01 19:00:24 -04:00
2e3558c43e
don't need to double check for null
2014-05-01 18:50:26 -04:00
582fa1a664
fix typo
2014-05-01 18:22:57 -04:00
cd650f6055
Use system ldns library
...
This library is used only by mod_enum and is available on most
platforms. The version in our tree has many code quality problems
that are generating noise when doing static analysis. Suffice it to
say we want rid of it as our responsibility.
FS-353
2014-05-01 22:01:59 +00:00
c1f884cd33
Remove old ldns patch from FS-3110
2014-05-01 22:01:59 +00:00
33460064ac
CID: 1210739
2014-05-01 17:34:54 -04:00
a4e0929ef0
CID: 1210596
2014-05-01 17:28:54 -04:00
17f79bc2c3
CID: 1210770
2014-05-01 16:36:58 -04:00
7f18b80e60
FS-6503 --resolve remove unused code
2014-05-02 01:28:12 +05:00
c462ed6ae1
FS-6499 --resolve
2014-05-01 15:21:57 -05:00
d06b137abd
FS-6498 --resolve
2014-05-01 15:20:28 -05:00
64f1098b8c
remove dead assignment
2014-05-01 14:17:06 -04:00
b0fd845786
remove dead assignment
2014-05-01 14:04:56 -04:00
d4ba268f29
remove dead assignment
2014-05-01 13:52:12 -04:00
4ec5e5af47
Refactor if blocks
...
Since the first branch doesn't need to do anything, we invert it and
pull a sub-branch out a level into the main conditional.
2014-04-30 23:23:06 +00:00
ae3cf0a1a9
Remove dead assignment
...
...now this code needs refactoring.
2014-04-30 23:22:13 +00:00
2ae823fb9f
Drop dead assignments
...
We goto done at the end of these blocks.
2014-04-30 23:03:06 +00:00
e4d807108c
CID: 1210646
2014-04-30 18:47:02 -04:00
fd4364cd43
Drop dead assignment
2014-04-30 22:43:33 +00:00
946db55b34
Drop dead assignments
2014-04-30 22:42:08 +00:00
3abcee7142
unused
2014-04-30 18:36:44 -04:00
f38ccbfb51
Remove dead assignment, but why...
...
This assignment isn't doing anything, so it safe to remove it, but
there remains the question of whether there could have been some
actually necessary intention behind this line.
2014-04-30 22:33:24 +00:00
0f6e364e61
Drop dead assignment
2014-04-30 22:33:24 +00:00
b9b5b0d827
Avoid dead assignment of return value of execv
...
execv(3) only returns on error, and will always return -1 in that
case.
2014-04-30 22:33:24 +00:00
5f3e98beb4
Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds
2014-04-30 14:37:17 -07:00
6add88b43f
check return value for es_say_general_count
2014-04-30 16:43:35 -04:00
ef18915ca5
make sure old_pid_buffer is null terminated
2014-04-30 16:36:14 -04:00
23b3e172d5
don't leak file handle if fd = 0
2014-04-30 15:56:36 -04:00
6f16e0d3da
don't leak if first realloc fails but second one succeeds
2014-04-30 15:53:26 -04:00
068ad205b7
split this into 2 functions so its clear if this function allocates or not
2014-04-30 15:48:23 -04:00
942215637a
make sure receive buffer is always null terminated
2014-04-30 13:49:58 -04:00
ac9741b579
don't leak xml string in dl_logger
2014-04-30 13:44:59 -04:00
0b8d2c5d65
add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr
2014-04-30 13:31:06 -04:00
a9a852477a
fix read beyond buffer length error
2014-04-30 13:25:29 -04:00
e57484af9b
FS-6497: --resolve fix for loop initial declaration not allowed
2014-04-30 12:16:02 -04:00
c36e63026c
mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL)
2014-04-30 10:08:00 -04:00
e98045841e
gracefully handle allocation failure
2014-04-30 08:55:39 -04:00
2e8572acb5
we always have the session in the dialplan function
2014-04-30 08:51:52 -04:00
b3bfa563ae
we always have the caller profile at this point, if for some reason we don't just instead of crashing
2014-04-30 08:50:29 -04:00
7508481597
we always have the seesion in the app function
2014-04-30 08:46:11 -04:00
9bf98d0dd3
remove useless checks of array == 0
2014-04-30 08:43:57 -04:00
af32ca00e3
Correction to commit 0ba59aa6c2 using the correct variable in tel uri param parsing for mod_sofia
2014-04-29 15:23:24 -07:00
529099f15c
silence incorrect warnings about null pointer derference and remove unused code
2014-04-29 14:34:49 -04:00
d0de8c0bc6
add heartbeat_use_scheduler variable to force the heartbeat to use the scheduler rather than the media stream and also make it auto-chage between modes when going in and out of the media path
2014-04-29 04:20:51 +05:00
6e41898517
this should never happen, but just in case, this will at least calm coverity
2014-04-28 16:30:19 -04:00
7e2499355a
handle null 'status' passed to 'switch_channel_perform_presence' more gracefully
2014-04-28 16:21:45 -04:00
a5f680810d
only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value
2014-04-28 16:17:56 -04:00
d9b5bfaa7f
only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value
2014-04-28 16:12:10 -04:00
a044b3b64b
remove unused var ocp
2014-04-28 16:06:39 -04:00
e7107f616f
if we can't open /dev/null, you have much bigger issues to deal with
2014-04-28 16:02:39 -04:00
34c967707d
improve null checks
2014-04-28 15:49:57 -04:00
1b43fa85b5
remove useless variable
2014-04-28 15:19:19 -04:00
7a7c275445
remove useless statement
2014-04-28 15:16:03 -04:00
0cba8b39c3
improve error checking for null path
2014-04-28 15:12:02 -04:00
8d10e65b79
fix bitwise flag unsetting
2014-04-28 15:06:39 -04:00
4828ecd7fd
remove unused variable
2014-04-28 15:00:22 -04:00
95d4d0031c
don't set variable we don't use, and fix off by 1 buffer overflow in 1 case
2014-04-28 14:46:05 -04:00
dbaf49926c
remove unnecessary null check, we would have crashed already if that strdup failed
2014-04-28 14:38:38 -04:00
5c07c3eb03
don't use memory after free when using naptr with mod_enum with multiple routes
2014-04-28 13:03:09 -05:00
a83fde3543
block of code in here twice was writing over expanded, causing it to potentially leak
2014-04-28 13:41:48 -04:00
59734d8e15
add bounds check to keep rtcp packets with > 5 report blocks from creating a buffer overrun
2014-04-28 13:32:01 -04:00
cc06d9181b
FS-4779 FS-6467 the behaviour from 4479 is now masked behind the param 3pcc-reinvite-bridged-on-ack FS-6467 please test master
2014-04-28 22:10:14 +05:00
e3b4e6b227
fix deref before null check
2014-04-28 13:01:12 -04:00
1174413115
remove unused variable
2014-04-28 12:41:04 -04:00
c51b55a46e
FS-6491 --resolve
...
This seems to be a paradox when running a perl script from a session then executing perl again on the same session from a different thread.
I fixed it by converting any execution of perl in the execute_on_* family of operators to only run background mode which is to store the command in the session stack to be executed only by the session thread instead of on the spot by the outide thread. changing the execute_on_answer to perl::/path/to/script.pl would also eliminate the crash in code that has not been updated with this patch.
This is just a limitation of embedded perl we have to live with.
2014-04-28 21:19:48 +05:00
0d8f954e09
fixing commit a710841123 in switch_config
...
Previous commit actually broke the functionality since it was now returning if cfg->path[0] was not null.
Also since cfg->path can never be null, this check can be simplified to only check the first index.
2014-04-28 08:46:48 -07:00
60bc7dae9f
check return value of switch_vasprintf
2014-04-28 09:54:20 -04:00
553dd9bdcf
fix assigned but never used issue and code cleanup for readability
2014-04-28 09:47:30 -04:00
1affd78204
we only call this with values, and it would crash if you passed it null anyways, just assert to make it 100% clear
2014-04-26 15:41:34 -04:00
abd7882d18
contact->m_url is an array, don't check array for zero as its useless
2014-04-26 15:35:27 -04:00
96c6abbe69
Fix buffer overrun that could have been exploited with a crafted skinny packet designed to exploit this mistake in bounds checking.
2014-04-26 15:29:01 -04:00
2e45fc0619
fix memory leaks, tanks to Sharath from packetizer forum.
2014-04-26 04:49:35 +04:00
1aa2fc7548
FS-3332 --resolve
2014-04-25 15:53:21 -05:00
0ba59aa6c2
Expanding on 052638186b to support boolean tel url params in mod_sofia
2014-04-25 13:49:59 -07:00
f27fe7ed08
BNPH-6470 follow up to commit 68d863a179 removing the original line that performed the curl request to avoid a double request in mod_xml_curl
2014-04-25 12:11:09 -07:00
68d863a179
FS-6470
2014-04-25 11:50:06 -05:00
7e15c938e2
FS-6482 --resolve
2014-04-24 14:05:18 -05:00
Michael Jerris