retronetworking
/
freeswitch
13
0
Fork 0
Code Pull Requests Releases Activity

CID: 1214223-1214230 If sent an invalid registration authentication header with multiple params of the same name, then only use the first of the params instead of leaking memory

This commit is contained in:
William King 2014-05-16 11:50:07 -07:00
parent 54fc2f5e39
commit 7d5434f57c
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/mod/endpoints/mod_sofia/sofia_reg.c
View File

@ -2581,21 +2581,21 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
*p = '\0';
}
if (!strcasecmp(var, "username")) {
if (!strcasecmp(var, "username") && !username) {
username = strdup(val);
} else if (!strcasecmp(var, "realm")) {
} else if (!strcasecmp(var, "realm") && !realm) {
realm = strdup(val);
} else if (!strcasecmp(var, "nonce")) {
} else if (!strcasecmp(var, "nonce") && !nonce) {
nonce = strdup(val);
} else if (!strcasecmp(var, "uri")) {
} else if (!strcasecmp(var, "uri") && !uri) {
uri = strdup(val);
} else if (!strcasecmp(var, "qop")) {
} else if (!strcasecmp(var, "qop") && !qop) {
qop = strdup(val);
} else if (!strcasecmp(var, "cnonce")) {
} else if (!strcasecmp(var, "cnonce") && !cnonce) {
cnonce = strdup(val);
} else if (!strcasecmp(var, "response")) {
} else if (!strcasecmp(var, "response") && !response) {
response = strdup(val);
} else if (!strcasecmp(var, "nc")) {
} else if (!strcasecmp(var, "nc") && !nc) {
nc = strdup(val);
}
}