phone-side
/
uboot-mt623x
9
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

display_buffer: fix misaligned buffer 

use a union to cause necessary alignment per architecture

Signed-off-by: Reinhard Meyer <u-boot@emk-elektronik.de>
This commit is contained in:
Reinhard Meyer 2010-09-08 12:25:40 +02:00 committed by Wolfgang Denk
parent 93ceb4790d
commit 150f723665
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/display_options.c
View File

@ -101,10 +101,12 @@ void print_size(unsigned long long size, const char *s)
#define DEFAULT_LINE_LENGTH_BYTES (16) #define DEFAULT_LINE_LENGTH_BYTES (16)
int print_buffer (ulong addr, void* data, uint width, uint count, uint linelen) int print_buffer (ulong addr, void* data, uint width, uint count, uint linelen)
{ {
uint8_t linebuf[MAX_LINE_LENGTH_BYTES + 1]; /* linebuf as a union causes proper alignment */
uint32_t *uip = (void*)linebuf; union linebuf {
uint16_t *usp = (void*)linebuf; uint32_t ui[MAX_LINE_LENGTH_BYTES/sizeof(uint32_t) + 1];
uint8_t *ucp = (void*)linebuf; uint16_t us[MAX_LINE_LENGTH_BYTES/sizeof(uint16_t) + 1];
uint8_t uc[MAX_LINE_LENGTH_BYTES/sizeof(uint8_t) + 1];
} lb;
int i; int i;
if (linelen*width > MAX_LINE_LENGTH_BYTES) if (linelen*width > MAX_LINE_LENGTH_BYTES)
@ -123,21 +125,22 @@ int print_buffer (ulong addr, void* data, uint width, uint count, uint linelen)
for (i = 0; i < linelen; i++) { for (i = 0; i < linelen; i++) {
uint32_t x; uint32_t x;
if (width == 4) if (width == 4)
x = uip[i] = *(volatile uint32_t *)data; x = lb.ui[i] = *(volatile uint32_t *)data;
else if (width == 2) else if (width == 2)
x = usp[i] = *(volatile uint16_t *)data; x = lb.us[i] = *(volatile uint16_t *)data;
else else
x = ucp[i] = *(volatile uint8_t *)data; x = lb.uc[i] = *(volatile uint8_t *)data;
printf(" %0*x", width * 2, x); printf(" %0*x", width * 2, x);
data += width; data += width;
} }
/* Print data in ASCII characters */ /* Print data in ASCII characters */
for (i = 0; i < linelen * width; i++) for (i = 0; i < linelen * width; i++) {
if (!isprint(ucp[i]) || ucp[i] >= 0x80) if (!isprint(lb.uc[i]) || lb.uc[i] >= 0x80)
ucp[i] = '.'; lb.uc[i] = '.';
ucp[i] = '\0'; }
printf(" %s\n", ucp); lb.uc[i] = '\0';
printf(" %s\n", lb.uc);
/* update references */ /* update references */
addr += linelen * width; addr += linelen * width;