wireshark/epan
Alexis La Goutte cd519e450c From Olivier Benghozi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7734
BGP bad decoding for Graceful Restart Capability with only helper support

BGP Capability in OPEN message: Graceful restart capability (64).

So when the length of the capability value is smaller that 6 (6 meaning full
support of GR capa, with significants elements and at least one AFI/SAFI), the
code interprets it as erroneous.

However,as described in RFC4724: " When a sender of this capability does not
include any <AFI, SAFI> in the capability, it means that the sender is not
capable of preserving its forwarding state during BGP restart, but supports
procedures for the Receiving Speaker (as defined in Section 4.2 of this
document). In that case, the value of the Restart Time field advertised by the
sender is irrelevant".

So, length of exactly 2 is valid but has to be interpreted with a particular
meaning.

In the dissector code, a length of 2 should be a special case for this capa,
decoding as "Graceful Restart helper mode only" or something like that, and
maybe also displaying an expert message if the Restart flag is not 0 in this
case, since here it's not expected to be possible.

svn path=/trunk/; revision=45216
2012-09-30 10:05:18 +00:00
..
crypt We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
dfilter As suggested by Xavier Raynaud in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6425 : 2012-09-20 03:04:48 +00:00
dissectors From Olivier Benghozi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7734 2012-09-30 10:05:18 +00:00
ftypes We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
wslua Store pointers to previously displayed and captured packet, not nstime_t deltas. 2012-09-23 16:25:28 +00:00
wspython We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
CMakeLists.txt Beginnings of the Foundry Discovery Protocol (FDP) dissector. 2012-09-24 16:20:31 +00:00
Makefile.am Make register_all_wiretap_modules() and register_all_codecs() static; 2012-09-08 17:16:51 +00:00
Makefile.common Move the list of AX.25 protocol IDs to epan/ax25_pids.h. Use it in 2012-08-03 01:58:12 +00:00
Makefile.nmake Fix the *test_install targets so they put the test tools in the right directory (wireshark-gtk2 is one dir up from here). 2012-05-16 16:36:32 +00:00
addr_and_mask.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
addr_and_mask.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
addr_resolv.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
addr_resolv.h Add a new preference to make it possible to only use the hosts file 2012-07-11 08:52:51 +00:00
address.h Get rid of ../../epan/address.h:65:19: warning: comma at end of enumerator list [-pedantic] 2012-09-24 15:08:46 +00:00
address_to_str.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
adler32.c Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
adler32.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
afn.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
afn.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
aftypes.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
arcnet_pids.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
arptypes.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
asm_utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
asm_utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
asm_utils_win32_x86.asm Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
asn1.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
asn1.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
atalk-utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
atalk-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
ax25_pids.h Move the list of AX.25 protocol IDs to epan/ax25_pids.h. Use it in 2012-08-03 01:58:12 +00:00
base64.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
base64.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
bitswap.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
bitswap.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
bridged_pids.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
camel-persistentdata.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
camel-persistentdata.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
charsets.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
charsets.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
chdlctypes.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
circuit.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
circuit.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
codecs.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
codecs.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
column-utils.c Store pointers to previously displayed and captured packet, not nstime_t deltas. 2012-09-23 16:25:28 +00:00
column-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
column.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
column.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
column_info.h cinfo.columns_changed is only used by ui/gtk, move it to cfile structure. 2012-09-03 15:12:49 +00:00
conv_id.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
conversation.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
conversation.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
crc8-tvb.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
crc8-tvb.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
crc16-tvb.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
crc16-tvb.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
crc32-tvb.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
crc32-tvb.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
diam_dict.h
diam_dict.l We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
dissector_filters.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
dissector_filters.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
doxygen.cfg.in
dtd.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
dtd_grammar.lemon We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
dtd_parse.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
dtd_parse.l
dtd_preparse.l We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
eap.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
emem.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
emem.h Convert GString to emem_strbuf_t in packet-gadu-gadu.c 2012-08-18 19:20:31 +00:00
enterprise-numbers [Automatic manuf, services and enterprise-numbers update for 2012-09-23] 2012-09-23 14:03:25 +00:00
epan.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
epan.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
epan_dissect.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
etypes.h Whitespace fixes 2012-09-24 11:39:28 +00:00
ex-opt.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
ex-opt.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
except.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
except.h
exceptions.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
exntest.c Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
expert.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
expert.h Make the corresponding packet_info available to each tree item. This 2012-08-10 20:33:01 +00:00
filesystem.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
filesystem.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
filter_expressions.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
filter_expressions.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
follow.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
follow.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
frame_data.c Store pointers to previously displayed and captured packet, not nstime_t deltas. 2012-09-23 16:25:28 +00:00
frame_data.h Store pointers to previously displayed and captured packet, not nstime_t deltas. 2012-09-23 16:25:28 +00:00
frequency-utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
frequency-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
funnel.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
funnel.h Fix up some indentation and trailing white space. 2012-09-19 19:34:17 +00:00
garrayfix.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
gcp.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
gcp.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
geoip_db.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
geoip_db.h From Evan Huus: 2012-07-08 01:17:19 +00:00
golay.c Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
golay.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
greproto.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
guid-utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
guid-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
h225-persistentdata.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
h225-persistentdata.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
iana_snap_pid.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
iax2_codec_type.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
in_cksum.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
in_cksum.h
ip_opts.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
ipproto.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
ipproto.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
ipv4.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
ipv4.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
ipv6-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
lapd_sapi.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
libwireshark.def Add new function: call_dissector_with_data 2012-09-11 09:06:13 +00:00
libwireshark.vcproj
llcsaps.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
next_tvb.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
next_tvb.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
nlpid.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
nstime.c Update FSF address - part II. 2012-06-28 23:18:38 +00:00
nstime.h Add a preview to the common file dialog. Adjust the win32 file dialog 2012-07-27 21:43:02 +00:00
oids.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
oids.h From Michael Mann: 2012-07-06 04:48:36 +00:00
osi-utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
osi-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
oui.h Beginnings of the Foundry Discovery Protocol (FDP) dissector. 2012-09-24 16:20:31 +00:00
packet.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
packet.h Remove #defines that provided backward source compatibility 2012-09-19 07:20:49 +00:00
packet_info.h Add doxygen hints. 2012-09-12 10:27:37 +00:00
params.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
pint.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
plugins.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
plugins.h Make register_all_wiretap_modules() and register_all_codecs() static; 2012-09-08 17:16:51 +00:00
ppptypes.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
prefs-int.h Compiler error fixes resulting from r44348 2012-08-08 20:47:20 +00:00
prefs.c Don't pass a null pointer to strcmp. 2012-09-27 16:23:06 +00:00
prefs.h Have (almost) all preferences use the generic preferences API (per https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7402). This cleaned up a lot of hardcoded code and allows breaking up the prefs structure (or at least prevent it from growing too large) if desired. 2012-08-08 16:54:02 +00:00
proto.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
proto.h MT: move global field_info_tmp to tree_data_t 2012-09-03 12:00:08 +00:00
ptvcursor.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
radius_dict.l We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
range.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
range.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
reassemble.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
reassemble.h From Robert Bullen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 : 2012-09-07 02:09:59 +00:00
reassemble_test.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
reedsolomon.c
reedsolomon.h
report_err.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
report_err.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
req_resp_hdrs.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
req_resp_hdrs.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
rtp_pt.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
sctpppids.h Update SCTP PPIDs. 2012-08-14 20:31:49 +00:00
sigcomp-udvm.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
sigcomp-udvm.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
sigcomp_state_hdlr.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
sigcomp_state_hdlr.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
slab.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
sminmpec.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
sna-utils.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
sna-utils.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
stat_cmd_args.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
stat_cmd_args.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
stats_tree.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
stats_tree.h From Wonil Kim: Enable statistics menu register for the tap plug-in. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7466 2012-07-15 16:24:35 +00:00
stats_tree_priv.h From Wonil Kim: Enable statistics menu register for the tap plug-in. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7466 2012-07-15 16:24:35 +00:00
stream.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
stream.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
strutil.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
strutil.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
t35.c Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
t35.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tap-voip.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tap.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tap.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tcap-persistentdata.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tcap-persistentdata.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tfs.c add the the necessary tfs variables for rev 45152 2012-09-26 18:19:15 +00:00
tfs.h add the the necessary tfs variables for rev 45152 2012-09-26 18:19:15 +00:00
time_fmt.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
timestamp.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
timestamp.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
to_str.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
to_str.h From Richard Stearn: support for AX.25, including support for 2012-08-02 16:54:43 +00:00
tpg.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tpg.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tvbparse.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tvbparse.h Update FSF address - part II. 2012-06-28 23:18:38 +00:00
tvbtest.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tvbuff-int.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
tvbuff.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
tvbuff.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
uat-int.h UATs could be put into "categories". The categories were defined only 2012-07-08 01:00:46 +00:00
uat.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
uat.h UATs could be put into "categories". The categories were defined only 2012-07-08 01:00:46 +00:00
uat_load.l We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
value_string.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
value_string.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
x264_prt_id.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00
xdlc.c We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 2012-09-20 01:48:30 +00:00
xdlc.h Update Free Software Foundation address. 2012-06-28 22:56:06 +00:00