osmocom/wireshark
14
0
Fork 1
Code Issues Pull requests Projects Releases Wiki Activity
wireshark/ui
History
John Thacker a3806fc69b Qt: Fix crash when changing dfilter macro 
The comments claim that UAT_AFFECTS_FIELDS also triggers a redissection,
but it does not. Fortunately, all UATs whose flags have UAT_AFFECTS_FIELDS
also have UAT_AFFECTS_DISSECTION.

dfilter macro expressions are a rare case of a UAT that should trigger
FieldsChanged but not PacketDissectionChanged. (It's slightly
unnecessary to invalidate the custom columns, but perhaps in the
future macros will be possible in custom columns.)

So resolve things by changing the comments to reflect current reality
and making the dfilter macro UAT flags UAT_AFFECTS_FIELDS.

This prevents a crash when removing a dfilter macro thus invalidating
the current filter, and then opening a file (including reloading the
current one.)

Fix #13753
2023-06-09 15:34:44 +00:00
..
cli ftypes: Hide fvalue implementation 2023-04-19 15:12:25 +00:00
logray CMake: Modernize Qt6 configuration 2023-06-09 13:57:33 +00:00
macosx macos: Remove no longer needed function 2022-07-25 17:00:55 +00:00
qt Qt: Fix crash when changing dfilter macro 2023-06-09 15:34:44 +00:00
win32 MinGW: Disable -Wcast-function-type warnings 2023-01-14 14:52:53 +00:00
alert_box.c Replace g_strdup_printf() with ws_strdup_printf() 2021-12-19 21:21:58 +00:00
alert_box.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
all_files_wildcard.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture.c Add packet dedup support for live captures too 2023-06-09 07:21:08 +00:00
capture.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_globals.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_info.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_ui_utils.c Replace g_strdup_printf() with ws_strdup_printf() 2021-12-19 21:21:58 +00:00
capture_ui_utils.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
CMakeLists.txt Move ui/filter_files.[ch] to wsutil 2023-02-10 20:59:22 +00:00
commandline.c Allow specifying subsecond granularity with tshark -t 2023-03-31 08:15:28 +02:00
commandline.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
decode_as_utils.c Move ui/cmdarg_err.[ch] to wsutil 2023-02-10 20:59:22 +00:00
decode_as_utils.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
dissect_opts.c MaxMindDB: Move pref to Name Resolution prefs 2023-04-07 00:31:37 +00:00
dissect_opts.h Allow specifying subsecond granularity with tshark -t 2023-03-31 08:15:28 +02:00
export_pdu_ui_utils.c Add a preference for ignoring duplicate frames 2023-06-09 07:21:08 +00:00
export_pdu_ui_utils.h Specify directory for temporary captures 2022-02-09 14:32:28 +00:00
failure_message.c Move ui/cmdarg_err.[ch] to wsutil 2023-02-10 20:59:22 +00:00
failure_message.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
file_dialog.c [#17478] free blocks in more places 2021-08-10 00:08:15 +00:00
file_dialog.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
firewall_rules.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
firewall_rules.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
help_url.c help: WLANTraffic section moved WSUG chapters 2023-03-02 14:43:07 +00:00
help_url.h Drop old unused topic actions 2022-03-06 15:10:19 +00:00
iface_lists.c Fix more unused variables and enable unused-but-set-variable errors. 2022-11-08 13:49:44 -08:00
iface_lists.h Allow to filter interface types 2022-04-19 09:19:50 +00:00
iface_toolbar.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
iface_toolbar.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
io_graph_item.c Replace g_assert() with ws_assert() 2021-06-19 01:23:31 +00:00
io_graph_item.h ftypes: Hide fvalue implementation 2023-04-19 15:12:25 +00:00
language.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
language.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
last_open_dir.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
main_statusbar.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
mcast_stream.c tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
mcast_stream.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
packet_list_utils.c columns: Migrate two-field columns to custom columns 2023-05-05 11:05:20 +00:00
packet_list_utils.h Ui: Centralize PacketList helper prototypes 2022-06-29 09:31:09 +00:00
packet_range.c Replace g_assert() with ws_assert() 2021-06-19 01:23:31 +00:00
packet_range.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
persfilepath_opt.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
persfilepath_opt.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
preference_utils.c ui: Fix leak 2023-04-25 18:33:44 +00:00
preference_utils.h Qt: Add resolved button to Edit Columns 2022-06-30 08:28:54 -04:00
profile.c ui: Fix leak 2023-04-25 18:33:44 +00:00
profile.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
progress_dlg.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
proto_hier_stats.c Proto hierarchy stats: obtain capture file read lock 2023-01-15 16:09:17 +00:00
proto_hier_stats.h hierarchy stats: Only increment the total packet count once per frame 2022-04-12 13:38:33 +00:00
recent.c View bytes as decimal or octal 2023-05-16 07:53:12 +00:00
recent.h View bytes as decimal or octal 2023-05-16 07:53:12 +00:00
recent_utils.h Ui: Centralize PacketList helper prototypes 2022-06-29 09:31:09 +00:00
rtp_media.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
rtp_media.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
rtp_stream.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
rtp_stream.h Replace g_strdup_printf() with ws_strdup_printf() 2021-12-19 21:21:58 +00:00
rtp_stream_id.c RTP: Fix some memleaks 2023-02-28 20:22:11 -05:00
rtp_stream_id.h RTP: Fix some memleaks 2023-02-28 20:22:11 -05:00
service_response_time.c Remove unneeded modelines in ui. 2021-04-20 07:43:39 +00:00
service_response_time.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
simple_dialog.h Fix more repeated words throughout 2021-12-31 22:50:40 +00:00
software_update.c UI: Allow Arm64 updates on Windows 2023-05-18 23:57:59 +00:00
software_update.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
ssl_key_export.c TLS: Export only actually used secrets 2023-06-08 12:57:28 +00:00
ssl_key_export.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
summary.c Finish removing RIPEMD160 support 2023-05-09 16:11:03 +00:00
summary.h Finish removing RIPEMD160 support 2023-05-09 16:11:03 +00:00
tap-credentials.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap-iax2-analysis.c IAX2 Stream Analysis: Fix of mean jitter calculation 2021-10-23 12:01:54 +00:00
tap-iax2-analysis.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap-rlc-graph.c RLC Graph: Free dfilter in case of errors. 2023-04-18 16:19:14 +00:00
tap-rlc-graph.h RLC Graph: store secs in time_t 2022-08-20 19:56:34 +00:00
tap-rtp-analysis.c RTP: Fix of incorrect timestamp sequence error on timestamp rollover 2023-04-10 10:35:33 +00:00
tap-rtp-analysis.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap-rtp-common.c RTP: Fix some memleaks 2023-02-28 20:22:11 -05:00
tap-rtp-common.h tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
tap-sctp-analysis.c tap: Adding flags for tap_packet 2022-06-10 05:46:15 +00:00
tap-sctp-analysis.h gboolean bitfields considered harmful 2022-07-30 08:49:08 -04:00
tap-tcp-stream.c dfilter: Make error a pointer 2023-04-20 14:12:39 +00:00
tap-tcp-stream.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap_export_pdu.c Move ui/version_info.[ch] to wsutil 2023-02-07 23:17:37 +00:00
tap_export_pdu.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
taps.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
text_import.c Move ui/version_info.[ch] to wsutil 2023-02-07 23:17:37 +00:00
text_import.h text2pcap: Move SHB and IDB setup to ui/text_import 2021-12-30 17:05:06 +00:00
text_import_regex.c text2pcap: Use standard log debug level 2021-12-30 01:17:06 +00:00
text_import_regex.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
text_import_scanner.h text_import: Report errors and warnings 2021-12-23 19:26:45 -05:00
text_import_scanner.l Add macros to control lemon diagnostics 2022-11-20 10:11:27 +00:00
time_shift.c Ui: Centralize PacketList helper prototypes 2022-06-29 09:31:09 +00:00
time_shift.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
urls.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
util.c Cast away the return value of g_strlcpy() and g_strlcat(). 2021-04-30 03:19:19 -07:00
util.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
voip_calls.c Qt: Fix leaks VOIP Calls Dialog 2023-05-12 20:07:58 +00:00
voip_calls.h Qt: Fix leaks VOIP Calls Dialog 2023-05-12 20:07:58 +00:00
ws_ui_util.h MinGW: Fix -Wreturn-type 2023-01-13 22:41:04 +00:00