osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/wsutil
History
Guy Harris f63b68f707 Further cleanups. 
If a variable is initialized in a loop body or an if clause or a switch
clause, declare it inside the loop body/clause, and de-initialize it
before leaving the loop body/clause.

De-initialize the gnutls_pkcs12_t before leaving rsa_load_pkcs12(), so
as not to leak it.

Always leave the per-bag loop by "goto done", even if we're not within
an inner loop, to make it clearer what we're doing.

We initialize the bag structure at the beginning of that loop body;
de-initialize it at the end.

If we leave the loop without a private key, and we don't have an error
message, the error is "we didn't find a PKCS8 key"; report that.

Change-Id: I87cf296876c8f1879f69d01ce67ca2829b4f8d16
Reviewed-on: https://code.wireshark.org/review/22958
Reviewed-by: Guy Harris <guy@alum.mit.edu>
 		2017-08-05 22:51:37 +00:00
..
.editorconfig Link version code statically again 2016-04-21 18:59:56 +00:00
CMakeLists.txt Change some names to reflect Apple's new UNIX-for-Macs name. 2017-06-16 08:50:22 +00:00
Makefile.am Change some names to reflect Apple's new UNIX-for-Macs name. 2017-06-16 08:50:22 +00:00
adler32.c
…
adler32.h
…
airpdcap_wep.c
…
base32.c Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode) 2016-11-02 04:34:44 +00:00
base32.h Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode) 2016-11-02 04:34:44 +00:00
base64.c
…
base64.h
…
bits_count_ones.h
…
bits_ctz.h Set width of hex output according to bitmask 2016-01-24 00:03:18 +00:00
bitswap.c
…
bitswap.h
…
buffer.c wiretap: add cleanup routine. 2017-02-14 10:22:20 +00:00
buffer.h wiretap: add cleanup routine. 2017-02-14 10:22:20 +00:00
cfutils.c cfutils.c: Fix ISO C forbids an empty translation unit [-Wpedantic] 2015-11-29 21:54:34 +00:00
cfutils.h cfutils.c: Fix ISO C forbids an empty translation unit [-Wpedantic] 2015-11-29 21:54:34 +00:00
clopts_common.c Let strtoi with NULL endptr require no invalid characters 2016-09-12 16:00:52 +00:00
clopts_common.h Add get_ routines to get a guint32, and use them. 2016-09-08 18:27:21 +00:00
cmdarg_err.c
…
cmdarg_err.h
…
color.h Fix indentation. 2017-06-10 03:00:08 +00:00
copyright_info.c Happy new Year 2017 ! 2017-01-01 14:14:18 +00:00
copyright_info.h
…
cpu_info.c Show memory info on macOS and Linux 2016-09-23 11:59:59 +00:00
cpu_info.h dumpcap: Include CPU info as hardware description in SHB 2016-09-23 08:13:43 +00:00
crash_info.c A bunch of "{Mac} OS X" -> "macOS" changes. 2017-04-05 19:16:22 +00:00
crash_info.h
…
crc6.c
…
crc6.h
…
crc7.c
…
crc7.h
…
crc8.c Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
crc8.h Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
crc10.c
…
crc10.h
…
crc11.c
…
crc11.h
…
crc16-plain.c
…
crc16-plain.h
…
crc16.c Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
crc16.h Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
crc32.c Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
crc32.h Add support for verifying CIP Safety CRC values. 2017-03-16 05:51:04 +00:00
eax.c Make Libgcrypt a mandatory dependency 2017-02-13 18:35:47 +00:00
eax.h
…
file_util.c Qt+Win32: Make software updates more friendly. 2016-12-20 14:18:14 +00:00
file_util.h Qt+Win32: Make software updates more friendly. 2016-12-20 14:18:14 +00:00
filesystem.c Use g_build_filename() instead, fix indentation 2017-08-01 21:20:37 +00:00
filesystem.h wsutil: Back out profile_write_info_file 2017-06-22 14:59:45 +00:00
frequency-utils.c Match what most source say are the actual Japanese 4.9 GHz channels. 2015-11-05 22:39:52 +00:00
frequency-utils.h Get rid of ws80211_frequency_to_channel(). 2015-11-05 22:56:07 +00:00
g711.c
…
g711.h
…
getopt_long.c Use AC_REPLACE_FUNCS and LTLIBOBJS 2016-04-04 23:58:41 +00:00
getopt_long.h Use AC_REPLACE_FUNCS and LTLIBOBJS 2016-04-04 23:58:41 +00:00
glib-compat.c Add g_get_monotonic_time() to glib-compat and use 2017-05-04 03:45:07 +00:00
glib-compat.h Add g_get_monotonic_time() to glib-compat and use 2017-05-04 03:45:07 +00:00
inet_addr-int.h Use AC_REPLACE_FUNCS and LTLIBOBJS 2016-04-04 23:58:41 +00:00
inet_addr.c Make sure config.h is included before inet_addr.h. 2016-12-02 10:33:42 +00:00
inet_addr.h Move ip6_to_str_buf() to to_str.c and make it take the buffer length. 2016-06-06 22:00:41 +00:00
inet_aton.c Add inet_pton/inet_ntop interface to libwsutil 2016-02-19 15:55:09 +00:00
inet_aton.h Just #include wsutil/inet_aton.h 2016-02-13 23:51:53 +00:00
inet_ipv6.h Move IPv6 inet definitions to wsutil/inet_ipv6.h 2016-07-30 13:14:43 +00:00
inet_ntop.c Use AC_REPLACE_FUNCS and LTLIBOBJS 2016-04-04 23:58:41 +00:00
inet_pton.c Include ws_diag_control.h in config.h 2016-04-04 23:05:31 +00:00
interface.c wsutil: add enumeration of local ip addresses in Windows. 2016-08-26 21:04:40 +00:00
interface.h extcap: add local_interfaces_to_list() to wsutil. 2016-03-04 05:53:56 +00:00
jsmn.c wsutil: split libjsmn. 2016-09-30 20:12:00 +00:00
jsmn.h jsmn(.h): fix warning: '@param' command used in a comment that is not attached to a function declaration [-Wdocumentation] 2016-10-06 14:20:16 +00:00
mpeg-audio.c
…
mpeg-audio.h
…
nstime.c Fix up the compare chain in nstime_delta(). 2016-05-09 23:52:33 +00:00
nstime.h No need for "struct nstime_t", "nstime_t" by itself suffices. 2016-01-03 07:19:34 +00:00
os_version_info.c Change some names to reflect Apple's new UNIX-for-Macs name. 2017-06-16 08:50:22 +00:00
os_version_info.h
…
pint.h pint(.h): Add Modelines and fix indent (use spaces) 2017-02-05 13:19:46 +00:00
plugins.c Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
plugins.h wsutil: remove leaks from filesystem and plugins code. 2017-02-18 13:45:14 +00:00
popcount.c
…
popcount.h
…
privileges.c A bunch of "{Mac} OS X" -> "macOS" changes. 2017-04-05 19:16:22 +00:00
privileges.h Move npf_sys_is_running() from wsutil to caputils. 2016-06-03 21:24:47 +00:00
processes.h Make sure pid_t is defined. 2017-02-07 21:36:10 +00:00
report_message.c Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
report_message.h Clean up handling of enabled/disabled protocols/heuristic dissectors. 2017-04-08 20:40:08 +00:00
rsa.c Further cleanups. 2017-08-05 22:51:37 +00:00
rsa.h rsa.h: include <stdio.h> 2017-06-06 12:00:31 +00:00
sign_ext.h No need to operate on full bit width (CID 1355344 / 1355348) 2016-03-16 01:08:27 +00:00
sober128.c wsutil/sober128: remove unused macros and functions 2017-02-02 21:13:55 +00:00
sober128.h wsutil/sober128: remove unused macros and functions 2017-02-02 21:13:55 +00:00
socket.h Clean up some UN*X-vs-Windows socket issues. 2017-01-26 07:00:06 +00:00
str_util.c Include ws_diag_control.h in config.h 2016-04-04 23:05:31 +00:00
str_util.h Don't include "file.h" if you don't need it. 2015-11-04 08:46:30 +00:00
strnatcmp.c
…
strnatcmp.h
…
strptime.c
…
strptime.h
…
strtoi.c wsutil: add initializer (found by clang ccc). 2016-11-03 08:32:18 +00:00
strtoi.h wsutil: add statements for c++ calls. 2016-10-22 23:27:26 +00:00
tempfile.c Check the result of localtime(). 2017-04-18 05:43:54 +00:00
tempfile.h Allow create_tempfile to support a suffix. 2016-06-01 06:24:05 +00:00
time_util.c Avoid colliding with the (old) UNIX stime() system call. 2016-08-07 03:07:38 +00:00
time_util.h time_util: fix -Wshadow issue 2016-08-30 10:35:33 +00:00
type_util.c
…
type_util.h
…
unicode-utils.c Win32: Pass a mutable string to CreateProcess. 2016-04-28 23:50:28 +00:00
unicode-utils.h Fix SURROGATE_VALUE() to match what RFC 2781 says. 2017-06-16 18:41:00 +00:00
utf8_entities.h A bunch of "{Mac} OS X" -> "macOS" changes. 2017-04-05 19:16:22 +00:00
win32-utils.c wsutil: Move Win32 helper routines from capchild 2016-06-25 15:06:27 +00:00
win32-utils.h wsutil: Move Win32 helper routines from capchild 2016-06-25 15:06:27 +00:00
ws_cpuid.h
…
ws_mempbrk.c
…
ws_mempbrk.h
…
ws_mempbrk_int.h
…
ws_mempbrk_sse42.c The official #define for 32-bit and 64-bit Windows is _WIN32. 2015-09-02 22:59:10 +00:00
ws_printf.h Fix some of the checkAPIs.pl warnings for g_warning. 2016-07-26 04:08:50 +00:00
wsgcrypt.c Move RSA key loading and decryption functions to wsutil 2017-06-05 23:43:03 +00:00
wsgcrypt.h SNMP: add support for USM SHA-2 algorithms (RFC 7860) 2017-08-04 05:57:20 +00:00
wsgetopt.h
…
wsjsmn.c Add sharkd - daemon variant 2017-01-25 07:19:05 +00:00
wsjsmn.h Add sharkd - daemon variant 2017-01-25 07:19:05 +00:00
wspcap.h Put the HAVE_REMOTE hack into wsutil/wspcap.h, and include that file. 2017-05-11 19:58:15 +00:00
xtea.c xtea[.ch] (wsutil): Add Modelines info 2017-07-05 18:06:40 +00:00
xtea.h xtea[.ch] (wsutil): Add Modelines info 2017-07-05 18:06:40 +00:00