osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui/qt/utils
History
Peter Wu 8da4777440 Qt: fix memleaks on opening a context menu 
FrameInformation was never deallocated, leaking the whole pinfo scope.
Fix a dealloc-alloc-mismatch (packet_data_ was g_memdup'd). Attach the
DataPrinter menu actions to the action group instead of the singleton
DataPrinter instance, this enables freeing the actions when the submenu
is gone rather than clearing this at program exit.

Reported by ASAN.

Change-Id: If13af94a60b07b0e52973ccc5c437ef987bfb394
Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView")
Reviewed-on: https://code.wireshark.org/review/27844
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2018-05-30 08:20:42 +00:00
..
color_utils.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
color_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
data_printer.cpp Qt: fix memleaks on opening a context menu 2018-05-30 08:20:42 +00:00
data_printer.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
field_information.cpp replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
field_information.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
frame_information.cpp Qt: fix memleaks on opening a context menu 2018-05-30 08:20:42 +00:00
frame_information.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
idata_printable.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
proto_node.cpp replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
proto_node.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
qt_ui_utils.cpp qt_ui_utils: fix issue found by PVS Studio (V519) 2018-05-17 04:25:42 +00:00
qt_ui_utils.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
stock_icon.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
stock_icon.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tango_colors.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
variant_pointer.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
wireshark_mime_data.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
wireshark_mime_data.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00