osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui
History
Peter Wu 7c0c8189a6 Qt: fix "Follow stream" in Conversations dialog 
If no stream is given to FollowStreamDialog::follow(), then it
overwrites the display filter with a conversation filter for the first
packet in the capture file.

Pass an explicit stream number and the "Follow stream" button will set a
correct display filter.

Test: open pcap with three TCP streams. Statistics -> Conversations.
Select last TCP conversation (expect "tcp.stream eq 2"). Select the
second conversation (expect "tcp.stream eq 1") and activate "Filter Out"
button (expect "!(tcp.stream eq 1)" and not "!(tcp.stream eq 2) and
!(tcp.stream eq 1)").

Bug: 14254
Change-Id: I28744d7f76f5034b07ea5660b45399566e3a7d2c
Reviewed-on: https://code.wireshark.org/review/26520
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
 		2018-03-21 16:56:21 +00:00
..
cli Plug a leak. 2018-03-09 02:13:17 +00:00
gtk Remove some unused or hard-coded header checks. 2018-03-12 22:11:32 +00:00
qt Qt: fix "Follow stream" in Conversations dialog 2018-03-21 16:56:21 +00:00
win32 Fix StringCchPrintf() calls. 2018-02-28 21:15:02 +00:00
CMakeLists.txt spdx: more licenses converted. 2018-03-07 15:56:44 +00:00
Makefile.am Use -Werror except for explicitly listed dirty dissectors. 2018-02-17 01:51:59 +00:00
alert_box.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
alert_box.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
all_files_wildcard.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
capture.c Move what capture_info_close() does into its only caller. 2018-03-03 06:55:44 +00:00
capture.h Remove declaration of routine that no longer exists. 2018-03-03 06:31:42 +00:00
capture_globals.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
capture_ui_utils.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
capture_ui_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
commandline.c Qt: Make we shut down cleanly when exiting early. 2018-03-01 08:44:00 +00:00
commandline.h Remove redundant declaration of exit_application(). 2018-03-20 17:57:54 +00:00
console.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
console.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
decode_as_utils.c Allow hexadecimal and octal numbers for tshark Decode As 2018-02-27 09:08:51 +00:00
decode_as_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
dissect_opts.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
dissect_opts.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
doxygen.cfg.in
…
export_object_ui.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_object_ui.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
export_pdu_ui_utils.c Constify an argument, remove no-longer-necessary removal of constness. 2018-02-20 20:06:36 +00:00
export_pdu_ui_utils.h Constify an argument, remove no-longer-necessary removal of constness. 2018-02-20 20:06:36 +00:00
failure_message.c Plug another leak for Wiretap errors. 2018-03-07 07:18:21 +00:00
failure_message.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
file_dialog.c Separately count all records and data records. 2018-02-10 03:44:10 +00:00
file_dialog.h Separately count all records and data records. 2018-02-10 03:44:10 +00:00
filter_files.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
filter_files.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
firewall_rules.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
firewall_rules.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
help_url.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
help_url.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
iface_lists.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
iface_lists.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
iface_toolbar.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
iface_toolbar.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
io_graph_item.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
io_graph_item.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
language.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
language.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
last_open_dir.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
main_statusbar.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
make-taps.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
mcast_stream.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
mcast_stream.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_list_utils.c Qt: Right justify custom columns with multiple fields 2018-02-20 11:48:20 +00:00
packet_list_utils.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
packet_range.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
packet_range.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
persfilepath_opt.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
persfilepath_opt.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
preference_utils.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
preference_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
profile.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
profile.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
progress_dlg.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
proto_hier_stats.c Generalize wtap_pkthdr into a structure for packet and non-packet records. 2018-02-09 00:29:51 +00:00
proto_hier_stats.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
recent.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
recent.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
recent_utils.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
rtp_media.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
rtp_media.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
rtp_stream.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
rtp_stream.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
service_response_time.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
service_response_time.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
simple_dialog.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
software_update.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
software_update.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
ssl_key_export.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
ssl_key_export.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
summary.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
summary.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-iax2-analysis.c tap-iax2-analysis: fix minor indentation issues. 2018-03-17 21:24:13 +00:00
tap-iax2-analysis.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
tap-rlc-graph.c Generalize wtap_pkthdr into a structure for packet and non-packet records. 2018-02-09 00:29:51 +00:00
tap-rlc-graph.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-rtp-analysis.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
tap-rtp-common.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-rtp-common.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-sctp-analysis.c tap-sctp: replace g_malloc with g_new. 2018-03-17 21:23:48 +00:00
tap-sctp-analysis.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap-tcp-stream.c tap-tcp-stream: fix indentation. 2018-03-17 21:24:54 +00:00
tap-tcp-stream.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
tap_export_pdu.c Generalize wtap_pkthdr into a structure for packet and non-packet records. 2018-02-09 00:29:51 +00:00
tap_export_pdu.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
taps.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
text_import.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
text_import_scanner.h Squelch redundant declaration warnings. 2018-02-16 22:40:26 +00:00
text_import_scanner.l spdx: more licenses converted. 2018-03-07 15:56:44 +00:00
time_shift.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
time_shift.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
traffic_table_ui.c Transition from GeoIP Legacy to MaxMindDB. 2018-03-06 18:02:21 +00:00
traffic_table_ui.h Don't put a comma after the last item in an enum list. 2018-03-10 05:20:23 +00:00
util.c replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
util.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
voip_calls.c Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
voip_calls.h Fix some source headers, reformat SPDX license lines in comment block. 2018-02-18 22:50:37 +00:00
ws_ui_util.h Note that exit_application() has UI-specific implementations. 2018-03-20 18:09:10 +00:00