wireshark/ui
John Thacker 6409a42f4b Qt: Invalidate the idle dissection timer when clearing packet list
When clearing the packet list model (called eventually from closing
the capturing file or redissecting), mark the idle dissection timer
as invalid so that idle dissection stops. It will be started again
by PacketList::captureFileReadFinished()

This saves some CPU during what is a fairly intensive and not
actually idle time, computing information that might be invalid.

In particular, this can prevent some read failures and spurious pop-up
error messages when opening a large file and saving it to a different
format (so that it is closed, and rescanned for new packet offsets)
while idle dissection is still ongoing. The idle dissection can
attempt to read packets with the wrong offsets. The error is caught
without serious issues, but messages like "pcap: file has X-byte
packet, bigger than maximum of Y" would imply to a user that something
went wrong with saving the file in the new format.

Related to #19486
2023-11-30 12:10:34 +00:00
..
cli tshark: Add UTF-8 output mode to the follow tap 2023-09-23 11:11:49 +00:00
logray Qt: Fix View.. Reset Layout 2023-11-23 07:32:09 -05:00
macosx macos: Remove no longer needed function 2022-07-25 17:00:55 +00:00
qt Qt: Invalidate the idle dissection timer when clearing packet list 2023-11-30 12:10:34 +00:00
win32 Work around macOS running applications in /. 2023-11-12 06:53:36 +00:00
CMakeLists.txt Move ui/filter_files.[ch] to wsutil 2023-02-10 20:59:22 +00:00
alert_box.c Replace g_strdup_printf() with ws_strdup_printf() 2021-12-19 21:21:58 +00:00
alert_box.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
all_files_wildcard.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
capture.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_globals.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_info.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
capture_ui_utils.c ui: Make sure to use user-specified interface descriptions 2023-11-25 07:56:53 -05:00
capture_ui_utils.h ui: Have get_interface_descriptive_name take the capture_options 2023-11-24 10:47:20 -05:00
commandline.c Fix overriding capture option prefs at the command line 2023-11-17 00:04:46 +00:00
commandline.h Fix overriding capture option prefs at the command line 2023-11-17 00:04:46 +00:00
decode_as_utils.c Don't include errno.h if we don't use errno or errno value definitions. 2023-06-26 16:07:23 -07:00
decode_as_utils.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
dissect_opts.c Handle all valid time stamp resolutions with the -t flag. 2023-09-13 01:47:22 -07:00
dissect_opts.h tshark: Support --read-file and filter long opts 2023-10-14 14:02:04 +00:00
export_pdu_ui_utils.c Add a preference for ignoring duplicate frames 2023-06-09 07:21:08 +00:00
export_pdu_ui_utils.h Specify directory for temporary captures 2022-02-09 14:32:28 +00:00
failure_message.c Move ui/cmdarg_err.[ch] to wsutil 2023-02-10 20:59:22 +00:00
failure_message.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
file_dialog.c
file_dialog.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
firewall_rules.c
firewall_rules.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
help_url.c dfilter: Replace macro UAT config file and update GUI 2023-11-08 11:45:54 +00:00
help_url.h dfilter: Replace macro UAT config file and update GUI 2023-11-08 11:45:54 +00:00
iface_lists.c Capture: Get our capabilities list in one dumpcap call 2023-11-23 20:27:58 +00:00
iface_lists.h Allow to filter interface types 2022-04-19 09:19:50 +00:00
iface_toolbar.c
iface_toolbar.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
io_graph_item.c
io_graph_item.h ftypes: Hide fvalue implementation 2023-04-19 15:12:25 +00:00
language.c
language.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
last_open_dir.h Work around macOS running applications in /. 2023-11-12 06:53:36 +00:00
main_statusbar.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
mcast_stream.c sharkd: Add Multicast streams output 2023-06-10 21:45:21 +00:00
mcast_stream.h sharkd: Add Multicast streams output 2023-06-10 21:45:21 +00:00
packet_list_utils.c ftypes: Rename IS_FT_* macros 2023-06-20 00:22:57 +01:00
packet_list_utils.h Find Packet: Find packet details multiple matches in a frame 2023-10-01 08:56:32 +00:00
packet_range.c packet_range: Handle depended upon correctly for all cases 2023-07-18 21:56:14 +00:00
packet_range.h packet_range: Handle depended upon correctly for all cases 2023-07-18 21:56:14 +00:00
persfilepath_opt.c
persfilepath_opt.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
preference_utils.c Add "Use monitor mode on all 802.11 devices if possible" 2023-11-30 04:20:33 +00:00
preference_utils.h Qt: Add resolved button to Edit Columns 2022-06-30 08:28:54 -04:00
profile.c ui: Fix leak 2023-04-25 18:33:44 +00:00
profile.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
progress_dlg.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
proto_hier_stats.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
proto_hier_stats.h hierarchy stats: Only increment the total packet count once per frame 2022-04-12 13:38:33 +00:00
recent.c Qt: Save GeometryStateDialog splitter states 2023-11-29 14:53:33 +00:00
recent.h Qt: Save GeometryStateDialog splitter states 2023-11-29 14:53:33 +00:00
recent_utils.h Qt: Fix Recent Files Max Count at startup 2023-11-15 08:57:36 +00:00
rtp_media.c codecs: Pass in fmtp, decode bandwidth efficient AMR 2023-07-14 17:58:19 -04:00
rtp_media.h codecs: Pass in fmtp, decode bandwidth efficient AMR 2023-07-14 17:58:19 -04:00
rtp_stream.c Include errno.h in a few files 2023-06-28 18:41:42 -04:00
rtp_stream.h Replace g_strdup_printf() with ws_strdup_printf() 2021-12-19 21:21:58 +00:00
rtp_stream_id.c RTP: Improve selection of streams for RTP Analysis/Player 2023-07-03 01:57:04 +00:00
rtp_stream_id.h RTP: Improve selection of streams for RTP Analysis/Player 2023-07-03 01:57:04 +00:00
service_response_time.c
service_response_time.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
simple_dialog.h Fix more repeated words throughout 2021-12-31 22:50:40 +00:00
software_update.c UI: Allow Arm64 updates on Windows 2023-05-18 23:57:59 +00:00
software_update.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
ssl_key_export.c Inject secrets through the GUI 2023-06-15 04:16:29 +00:00
ssl_key_export.h Inject secrets through the GUI 2023-06-15 04:16:29 +00:00
summary.c Finish removing RIPEMD160 support 2023-05-09 16:11:03 +00:00
summary.h Finish removing RIPEMD160 support 2023-05-09 16:11:03 +00:00
tap-credentials.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap-iax2-analysis.c
tap-iax2-analysis.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap-rlc-graph.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
tap-rlc-graph.h RLC Graph: store secs in time_t 2022-08-20 19:56:34 +00:00
tap-rtp-analysis.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
tap-rtp-analysis.h RTP Analysis:Fix nominal and arrival times calculation 2023-06-12 22:20:30 +00:00
tap-rtp-common.c ST2110-20: add dissector for SMPTE ST2110-20 2023-09-11 11:55:13 +00:00
tap-rtp-common.h Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
tap-sctp-analysis.c sctp tap: Fix copying checksum string 2023-10-08 14:53:12 +00:00
tap-sctp-analysis.h gboolean bitfields considered harmful 2022-07-30 08:49:08 -04:00
tap-tcp-stream.c dfilter: Make error a pointer 2023-04-20 14:12:39 +00:00
tap-tcp-stream.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
tap_export_pdu.c tshark: -U must be one of the export PDU taps 2023-11-15 08:50:10 +00:00
tap_export_pdu.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
taps.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
text_import.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
text_import.h text2pcap: Move SHB and IDB setup to ui/text_import 2021-12-30 17:05:06 +00:00
text_import_regex.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
text_import_regex.h Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
text_import_scanner.h text_import: Report errors and warnings 2021-12-23 19:26:45 -05:00
text_import_scanner.l Add macros to control lemon diagnostics 2022-11-20 10:11:27 +00:00
time_shift.c Ui: Centralize PacketList helper prototypes 2022-06-29 09:31:09 +00:00
time_shift.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
urls.h Add UI header files to Doxygen 2021-11-30 08:01:36 -05:00
util.c Make the code that handles the file open dialog style common code. 2023-11-13 21:30:47 +00:00
util.h Work around macOS running applications in /. 2023-11-12 06:53:36 +00:00
voip_calls.c Fix misppellings in root and ui directories 2023-09-26 00:26:25 -04:00
voip_calls.h Qt: Fix leaks VOIP Calls Dialog 2023-05-12 20:07:58 +00:00
ws_ui_util.h Qt: Use Qt [save|restore]Geometry for GeometryStateDialog 2023-11-26 16:49:45 -05:00