osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity
wireshark/ui/qt/models
History
Peter Wu 7b43c480f6 Qt: do not expose a UAT record if the update callback fails 
The default chk callbacks for individual fields only catches basic
errors such as invalid, too large numbers. Many dissectors perform
additional validation in the update_cb which is invoked for a record as
a whole. If this check fails, then the UAT must not be marked as valid
or else invalid records (like NULL pointers) could be exposed.

Thanks to Uli Heilmeier for noticing this.

Bug: 15709
Change-Id: I1cc4c6925322011a561ad6df840fbac67796e5b2
Fixes: v2.3.0rc0-1002-g1cd22559a8 ("Qt: convert UatDialog to model/view pattern, improve UX")
Reviewed-on: https://code.wireshark.org/review/33157
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Uli Heilmeier <openid@heilmeier.eu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
 		2019-05-15 05:31:47 +00:00
..
astringlist_list_model.cpp Get rid of some occurrences of Q_UNUSED 2018-06-18 16:22:43 +00:00
astringlist_list_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
cache_proxy_model.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
cache_proxy_model.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
coloring_rules_delegate.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
coloring_rules_delegate.h spdx: use consistent formatting for GPL-2.0-or-later 2018-03-09 17:32:36 +00:00
coloring_rules_model.cpp Qt: Remove checks for version below 5.2 2018-04-05 18:48:57 +00:00
coloring_rules_model.h spdx: use consistent formatting for GPL-2.0-or-later 2018-03-09 17:32:36 +00:00
decode_as_delegate.cpp Replace Qsort with std::sort 2019-02-15 15:10:03 +00:00
decode_as_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
decode_as_model.cpp Constification, to remove some compiler warnings. 2019-03-17 21:09:34 +00:00
decode_as_model.h Constification, to remove some compiler warnings. 2019-03-17 21:09:34 +00:00
dissector_tables_model.cpp ModelHelperTreeItem: Rename appendChild -> prependChild 2018-02-11 16:56:07 +00:00
dissector_tables_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
enabled_protocols_model.cpp Qt: Remove checks for version below 5.2 2018-04-05 18:48:57 +00:00
enabled_protocols_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
expert_info_model.cpp Expert Info: Displays comment of each packet in the expert information tab 2019-04-26 06:39:35 +00:00
expert_info_model.h Constification, to remove some compiler warnings. 2019-03-17 17:35:53 +00:00
expert_info_proxy_model.cpp Qt: Fix our Expert Info foreground color logic. 2019-03-23 13:28:46 +00:00
expert_info_proxy_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
export_objects_model.cpp No need to report "some files could not be saved". 2019-01-01 23:12:17 +00:00
export_objects_model.h No need to report "some files could not be saved". 2019-01-01 23:12:17 +00:00
fileset_entry_model.cpp Get rid of some occurrences of Q_UNUSED 2018-06-18 16:22:43 +00:00
fileset_entry_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
info_proxy_model.cpp Qt: Remove checks for version below 5.2 2018-04-05 18:48:57 +00:00
info_proxy_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
interface_sort_filter_model.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
interface_sort_filter_model.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
interface_tree_cache_model.cpp Qt: Fix debug assert in Manage Interfaces dialog 2019-05-09 03:59:18 +00:00
interface_tree_cache_model.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
interface_tree_model.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
interface_tree_model.h More interface view cleanups. 2018-08-12 01:56:23 +00:00
numeric_value_chooser_delegate.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
numeric_value_chooser_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
packet_list_model.cpp Qt: move packet list cache from record to model 2019-02-07 07:48:36 +00:00
packet_list_model.h Qt: move packet list cache from record to model 2019-02-07 07:48:36 +00:00
packet_list_record.cpp Hava a routine to read the currently-selected frome. 2019-04-15 05:54:41 +00:00
packet_list_record.h Qt: move packet list cache from record to model 2019-02-07 07:48:36 +00:00
path_chooser_delegate.cpp Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
path_chooser_delegate.h Qt: Switch models and DataPrinter to new-style signals and slots. 2018-12-24 07:38:21 +00:00
percent_bar_delegate.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
percent_bar_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
pref_delegate.cpp replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
pref_delegate.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
pref_models.cpp Qt: Support setting custom preferences 2019-04-24 00:33:37 +00:00
pref_models.h Qt: add initial RSA Keys preference frame 2019-01-29 23:34:01 +00:00
proto_tree_model.cpp Qt: Remove checks for version below 5.2 2018-04-05 18:48:57 +00:00
proto_tree_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
related_packet_delegate.cpp Qt: Add hover style to packet list and proto tree 2019-04-02 03:30:15 +00:00
related_packet_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
sparkline_delegate.cpp Qt: Comment some of the sparkline code. 2018-07-27 21:54:15 +00:00
sparkline_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
supported_protocols_model.cpp ModelHelperTreeItem: Rename appendChild -> prependChild 2018-02-11 16:56:07 +00:00
supported_protocols_model.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
timeline_delegate.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
timeline_delegate.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
tree_model_helpers.h Convert coloring rules dialog to use model. 2018-02-14 07:45:47 +00:00
uat_delegate.cpp Qt: IO Graph correct color selection 2019-01-16 18:40:10 +00:00
uat_delegate.h Qt: IO Graph correct color selection 2019-01-16 18:40:10 +00:00
uat_model.cpp Qt: do not expose a UAT record if the update callback fails 2019-05-15 05:31:47 +00:00
uat_model.h Qt: move method to apply/undo UAT changes to UatModel 2019-01-29 23:33:46 +00:00
url_link_delegate.cpp replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
url_link_delegate.h replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. 2018-02-08 14:57:36 +00:00
voip_calls_info_model.cpp Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00
voip_calls_info_model.h Fix comment end after SPDX identifier 2018-05-01 06:56:37 +00:00