wireshark/epan
Richard Sharpe 709757e996 radiotap: Refactor some aspects of the radiotap dissector.
One thing I hate is big slabs of open coding. Compilers are very good these days
and will inline functions if they are used in only one place.

By using functions we make the code very much more readible.

There is also a big opportunity to use functions like proto_tree_add_bitmask.

Change-Id: I66d1509f577d2955996f4649e05494ab0370ed01
Reviewed-on: https://code.wireshark.org/review/24964
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-30 15:32:20 +00:00
..
crypt airpdcap: check return value for gcry_mac_read (CID: 1420699). 2017-12-24 06:39:38 +00:00
dfilter cmake: match include directories with autotools 2017-11-29 06:58:22 +00:00
dissectors radiotap: Refactor some aspects of the radiotap dissector. 2018-01-30 15:32:20 +00:00
ftypes LTE L2 protocols: add FT_FRAMENUM_TYPE for most FT_FRAMENUM fields. 2017-11-29 21:21:09 +00:00
wmem autotools: Library build products don't need explicit cleaning 2017-11-18 22:29:41 +00:00
wslua wslua: fix nstime memory leak after passing unknown encoding to TvbRange_nstime() 2018-01-24 08:34:32 +00:00
.editorconfig Remove circuit API 2017-11-13 05:21:36 +00:00
CMakeLists.txt cmake: add ps.c to the checkAPI list with the proper path. 2018-01-18 11:01:38 +00:00
Makefile.am Hand the packet provider functions to epan_new(). 2017-12-08 04:33:55 +00:00
addr_and_mask.c Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
addr_and_mask.h Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
addr_resolv.c Get rid of MAX_IP_STR_LEN and MAX_IP6_STR_LEN. 2017-10-29 05:51:25 +00:00
addr_resolv.h Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
address.h Remove circuit API 2017-11-13 05:21:36 +00:00
address_types.c Don't cast away constness if it's not necessary. 2018-01-18 05:51:44 +00:00
address_types.h
afn.c
afn.h
aftypes.c
aftypes.h
app_mem_usage.c
app_mem_usage.h
arcnet_pids.h
arptypes.h
asn1.c
asn1.h
ax25_pids.h
bridged_pids.h
capture_dissectors.c
capture_dissectors.h
charsets.c Make a pointer const that has no need not to be const. 2018-01-18 05:48:46 +00:00
charsets.h
chdlctypes.h
color_filters.c Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
color_filters.h
column-info.h
column-utils.c
column-utils.h
column.c
column.h
conv_id.h
conversation.c Remove circuit API 2017-11-13 05:21:36 +00:00
conversation.h Remove circuit API 2017-11-13 05:21:36 +00:00
conversation_debug.h
conversation_table.c Use endpoint_type in conversation tables and hostlists 2017-10-29 20:17:03 +00:00
conversation_table.h conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the function declaration [-Wdocumentation] 2017-11-05 13:30:25 +00:00
crc6-tvb.c
crc6-tvb.h
crc8-tvb.c
crc8-tvb.h
crc10-tvb.c
crc10-tvb.h
crc16-tvb.c
crc16-tvb.h
crc32-tvb.c
crc32-tvb.h
decode_as.c Don't cast away constness if it's not necessary. 2018-01-18 06:00:59 +00:00
decode_as.h
diam_dict.h
diam_dict.l
disabled_protos.c
disabled_protos.h
dissector_filters.c
dissector_filters.h
doxygen.cfg.in
dtd.h
dtd_grammar.lemon Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
dtd_parse.h
dtd_parse.l Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
dtd_preparse.l Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
dvb_chartbl.c
dvb_chartbl.h
eap.h
eapol_keydes_types.h
epan.c Use an enum for plugin types. 2018-01-11 00:58:43 +00:00
epan.h Add new plugin type for libwireshark 2017-12-14 22:12:38 +00:00
epan_dissect.h
etypes.h Initial coding of the ieee1905 dissector with Multi-AP support. 2017-10-26 20:24:03 +00:00
ex-opt.c
ex-opt.h
except.c
except.h
exceptions.h
exntest.c
expert.c epan: Make expert info summary text mandatory 2017-12-14 06:06:47 +00:00
expert.h epan: Make expert info summary text mandatory 2017-12-14 06:06:47 +00:00
export_object.c Improve http object export for URLs with long extensions 2017-10-23 04:42:51 +00:00
export_object.h Note that the object size type is, in effect, size_t. 2018-01-06 23:33:06 +00:00
exported_pdu.c Convert PT_EXCHG into using conversation endpoints 2017-11-06 15:19:15 +00:00
exported_pdu.h Have the frame_tvbuff.c routines not use the global cfile. 2017-12-08 08:31:41 +00:00
filter_expressions.c
filter_expressions.h
follow.c
follow.h Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
frame_data.c
frame_data.h Use cfile.h to define the capture_file type. 2017-12-03 18:54:37 +00:00
frame_data_sequence.c
frame_data_sequence.h
funnel.c
funnel.h
garrayfix.h
geoip_db.c Explain where GeoIP_free comes from 2017-11-15 20:39:37 +00:00
geoip_db.h Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
golay.c
golay.h
guid-utils.c
guid-utils.h
iana_charsets.c
iana_charsets.h
iax2_codec_type.h
in_cksum.c
in_cksum.h
ip_opts.h
ipproto.c Remove unused netdb.h #includes 2017-10-31 00:11:08 +00:00
ipproto.h
ipv4.h Add wsutil/inet_ipv4.h. 2017-10-30 02:11:22 +00:00
ipv6.h Add a ws_in6_addr typedef for struct e_in6_addr. 2017-10-26 08:50:34 +00:00
lapd_sapi.h
llcsaps.h
media_params.c
media_params.h
next_tvb.c
next_tvb.h
nlpid.h
oids.c
oids.h
oids_test.c
osi-utils.c
osi-utils.h
oui.h Wi-SUN Protocol dissection and IEEE 802.15.4 IE cleanup. 2017-11-11 19:11:44 +00:00
packet.c Avoid ASN.1 frame.protocols duplication. 2017-12-19 21:03:04 +00:00
packet.h Avoid ASN.1 frame.protocols duplication. 2017-12-19 21:03:04 +00:00
packet_info.h Get rid of the necessity to use a preference to dissect ERSPAN type I packets. 2018-01-25 21:33:47 +00:00
params.h
plugin_if.c plugin_if: don't allocate memory and cast it instead. 2018-01-19 12:32:08 +00:00
plugin_if.h Remove a plugin_if_gui_cb type conversion. 2017-12-14 23:43:38 +00:00
ppptypes.h
prefs-int.h Convert GUI layout preferences to use preference effects. 2018-01-09 13:09:18 +00:00
prefs.c Qt: Don't use the term "extcap" interfaces in UI 2018-01-13 13:44:25 +00:00
prefs.h extcap: add preference to prevent interfaces loading. 2018-01-09 09:58:48 +00:00
print.c Reset file permissions 2018-01-27 18:48:40 +00:00
print.h Add columns (_ws.col) to output formats json, ek, pdml 2018-01-02 05:27:51 +00:00
print.ps
print_stream.c More information on the Windows Console and escape sequences. 2018-01-08 21:09:39 +00:00
print_stream.h TShark: Fix color handling on Windows. 2018-01-06 14:30:45 +00:00
proto.c Add duplicate value_string in check filter 2018-01-24 11:48:53 +00:00
proto.h Add ENC_VARINT_QUIC 2018-01-02 05:29:39 +00:00
proto_data.c proto_data.c: Fix bug in p_remove_proto_data. 2017-12-30 07:25:56 +00:00
proto_data.h
ps.h
ptvcursor.h Add ptvcursor APIs that return the values it retrieves 2017-10-13 06:45:37 +00:00
radius_dict.l Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
range.c
range.h
reassemble.c Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
reassemble.h
reassemble_test.c
reedsolomon.c
reedsolomon.h
register.c Don't use static GMutexes. 2018-01-25 09:04:48 +00:00
register.h Rewrite make-tap-reg.py in C 2017-12-11 02:52:28 +00:00
req_resp_hdrs.c
req_resp_hdrs.h
rtd_table.c
rtd_table.h
rtp_pt.h
sctpppids.h
sequence_analysis.c
sequence_analysis.h
show_exception.c
show_exception.h
slow_protocol_subtypes.h
sminmpec.h
srt_table.c Remove superfluous null-checks before strdup/free 2017-10-15 12:38:51 +00:00
srt_table.h
stat_groups.h
stat_tap_ui.c stat_tap: don't use-after-free (found by clang). 2018-01-16 22:31:51 +00:00
stat_tap_ui.h
stats_tree.c
stats_tree.h
stats_tree_priv.h
stream.c
stream.h
strutil.c
strutil.h
t35.c
t35.h
tap-voip.h
tap.c Refactor plugin registration and loading 2017-12-14 08:43:57 +00:00
tap.h Refactor plugin registration and loading 2017-12-14 08:43:57 +00:00
tfs.c
tfs.h
time_fmt.h
timestamp.c
timestamp.h
timestats.c
timestats.h
to_str-int.h
to_str.c Convert PT_EXCHG into using conversation endpoints 2017-11-06 15:19:15 +00:00
to_str.h Improve our ip6_to_str_buf() implementation 2017-10-29 15:15:31 +00:00
tvbparse.c Fix tvbparse recursion limit check. 2018-01-09 16:21:36 +00:00
tvbparse.h Limit tvbparse recursion. 2018-01-08 23:55:13 +00:00
tvbtest.c
tvbuff-int.h
tvbuff.c Add ENC_VARINT_QUIC 2018-01-02 05:29:39 +00:00
tvbuff.h Use pcapng as the name of the file format. 2018-01-09 00:38:51 +00:00
tvbuff_base64.c
tvbuff_composite.c
tvbuff_real.c
tvbuff_subset.c
tvbuff_zlib.c
uat-int.h
uat.c
uat.h Protect UAT color "datatype" from an empty string 2018-01-29 00:03:16 +00:00
uat_load.l
unit_strings.c btatt: Support BBC micro:bit Bluetooth profile 2018-01-04 12:51:44 +00:00
unit_strings.h btatt: Support BBC micro:bit Bluetooth profile 2018-01-04 12:51:44 +00:00
value_string.c
value_string.h
x264_prt_id.h
xdlc.c
xdlc.h