![Guy Harris](/assets/img/avatar_default.png)
statements. Move the setting of the Protocol column in various dissectors before anything is fetched from the packet, and also clear the Info column at that point in those and some other dissectors, so that if an exception is thrown, the columns don't reflect the previous protocol. "Tvbuffify" the Mobile IP dissector (it took old-style arguments, and then converted them into tvbuff arguments, so there wasn't much to do, other than to fix references to "fd" to refer to "pinfo->fd"). In the SCTP dissector, refer to the port type and source and destination ports through "pinfo" rather than through the global "pi", as it's a tvbuffified dissector. In the SMTP and Time Protocol dissectors, use "pinfo->match_port" rather than "TCP_PORT_SMTP" when checking whether the packet is a request or reply, just in case somebody makes a non-standard port be dissected as SMTP or Time. (Also, remove a bogus comment from the Time dissector; it was probably cut-and-pasted from the TFTP dissector.) svn path=/trunk/; revision=2938
97 lines
2.6 KiB
C
97 lines
2.6 KiB
C
/* packet-time.c
|
|
* Routines for time packet dissection
|
|
*
|
|
* Richard Sharpe <rsharpe@ns.aus.com>
|
|
*
|
|
* $Id: packet-time.c,v 1.13 2001/01/25 06:14:14 guy Exp $
|
|
*
|
|
* Ethereal - Network traffic analyzer
|
|
* By Gerald Combs <gerald@zing.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
* Copied from packet-tftp.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
# include "config.h"
|
|
#endif
|
|
|
|
#include "packet.h"
|
|
|
|
static int proto_time = -1;
|
|
static int hf_time_time = -1;
|
|
|
|
static gint ett_time = -1;
|
|
|
|
#define UDP_PORT_TIME 37
|
|
|
|
static void
|
|
dissect_time(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
|
|
{
|
|
proto_tree *time_tree;
|
|
proto_item *ti;
|
|
|
|
if (check_col(pinfo->fd, COL_PROTOCOL))
|
|
col_set_str(pinfo->fd, COL_PROTOCOL, "TIME");
|
|
|
|
if (check_col(pinfo->fd, COL_INFO)) {
|
|
col_add_fstr(pinfo->fd, COL_INFO, "TIME %s",
|
|
pinfo->srcport == pinfo->match_port ? "Response":"Request");
|
|
}
|
|
|
|
if (tree) {
|
|
|
|
ti = proto_tree_add_item(tree, proto_time, tvb, 0,
|
|
tvb_length(tvb), FALSE);
|
|
time_tree = proto_item_add_subtree(ti, ett_time);
|
|
|
|
proto_tree_add_text(time_tree, tvb, 0, 0,
|
|
pinfo->srcport==UDP_PORT_TIME? "Type: Response":"Type: Request");
|
|
if (pinfo->srcport == UDP_PORT_TIME) {
|
|
guint32 delta_seconds = tvb_get_ntohl(tvb, 0);
|
|
proto_tree_add_text(time_tree, tvb, 0, 4,
|
|
"%u seconds since midnight 1 January 1900 GMT",
|
|
delta_seconds);
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
proto_register_time(void)
|
|
{
|
|
|
|
static hf_register_info hf[] = {
|
|
{ &hf_time_time,
|
|
{ "Time", "time.time",
|
|
FT_UINT32, BASE_DEC, NULL, 0x0,
|
|
"Seconds since 00:00 (midnight) 1 January 1900 GMT" }}
|
|
};
|
|
static gint *ett[] = {
|
|
&ett_time,
|
|
};
|
|
|
|
proto_time = proto_register_protocol("Time Protocol", "TIME", "time");
|
|
proto_register_field_array(proto_time, hf, array_length(hf));
|
|
proto_register_subtree_array(ett, array_length(ett));
|
|
}
|
|
|
|
void
|
|
proto_reg_handoff_time(void)
|
|
{
|
|
dissector_add("udp.port", UDP_PORT_TIME, dissect_time, proto_time);
|
|
}
|