![Guy Harris](/assets/img/avatar_default.png)
statements. Move the setting of the Protocol column in various dissectors before anything is fetched from the packet, and also clear the Info column at that point in those and some other dissectors, so that if an exception is thrown, the columns don't reflect the previous protocol. Don't use col_add_fstr(..., "%s", string); Use col_add_str(..., string); as it does the same thing, but doesn't drag all the heavy *printf machinery in. Fix the DDTP dissector to set the Info column regardless of whether we're building a protocol tree or not, and to set it to "Encrypted payload" if the payload is encrypted. Also fix a typo in a field name. Register the FTP data dissector as being associated with the FTP data protocol, not the FTP protocol (the removed "CHECK_DISPLAY_AS_DATA()" call checked "proto_ftp_data", and the removed "pinfo->current_proto =" line set it to "FTP-DATA", so it should be associated with "proto_ftp_data"). Make the H1 dissector check whether the frame has at least 2 bytes in it before checking the first two bytes; heuristic dissectors must not throw exceptions until they've accepted the packet as one of theirs. Use "tvb_format_text()" rather than "tvb_get_ptr()" and "format_text()" in some dissectors where the result of "tvb_get_ptr()" is used only in the "format_text()" call. In the Quake dissector, don't check whether there are at least 4 bytes in the packet - if we return, the packet won't be dissected at all (it's not as if some other dissector will get to handle it), and, if we don't return, we'll throw an exception if there aren't at least 4 bytes in the packet, so the packet will be marked as short or malformed, as appropriate. In the RIPng dissector, associate the table of strings for the command field with the command field, so that the dissector doesn't have to format the string for the protocol tree entry itself, and so that the filter construction dialog box can let you select "Request" or "Response" from a list rather than requiring you to know the values for "Request" and "Response". Make "dissect_rpc()" static, as it's called only through a heuristic dissector list. Use "col_set_str()" to set the COL_PROTOCOL column for RPC protocols; the string used is from a table provided by the dissector, and is a string constant. Don't format the Info column for WSP into a buffer and then format that buffer into the column with "%s" - "col_add_fstr()" can do the formatting for you, without having to allocate your own buffer (or run through the *printf machinery twice). Don't fetch fields from the WTP packet until you're ready to use them, so that you don't throw an exception before you even set the Protocol column or clear the Info column. Use "pinfo->destport", not "pi.destport", in the Zebra dissector when checking whether the packet is a request or reply, and do the check by comparing with "pinfo->match_port" rather than TCP_PORT_ZEBRA (so that if the dissector is ever registered on another port, it still correctly determines whether the packet is a request or reply - the Network Monitor HTTP dissector has port 80 wired into its brain, which is a bit irritating if you're trying to get it to dissect HTTP proxy traffic on port 3128 or proxy administration UI traffic on port 3132). svn path=/trunk/; revision=2931
197 lines
5 KiB
C
197 lines
5 KiB
C
/* packet-lpd.c
|
|
* Routines for LPR and LPRng packet disassembly
|
|
* Gilbert Ramirez <gram@xiexie.org>
|
|
*
|
|
* $Id: packet-lpd.c,v 1.27 2001/01/22 08:03:45 guy Exp $
|
|
*
|
|
* Ethereal - Network traffic analyzer
|
|
* By Gerald Combs <gerald@zing.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
# include "config.h"
|
|
#endif
|
|
|
|
#ifdef HAVE_SYS_TYPES_H
|
|
# include <sys/types.h>
|
|
#endif
|
|
|
|
#include <string.h>
|
|
|
|
#include <glib.h>
|
|
#include "packet.h"
|
|
|
|
#define TCP_PORT_PRINTER 515
|
|
|
|
static int proto_lpd = -1;
|
|
static int hf_lpd_response = -1;
|
|
static int hf_lpd_request = -1;
|
|
|
|
static gint ett_lpd = -1;
|
|
|
|
enum lpr_type { request, response, unknown };
|
|
|
|
static gint find_printer_string(tvbuff_t *tvb, int offset);
|
|
|
|
static void
|
|
dissect_lpd(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
|
|
{
|
|
proto_tree *lpd_tree;
|
|
proto_item *ti;
|
|
enum lpr_type lpr_packet_type;
|
|
guint8 code;
|
|
gint printer_len;
|
|
|
|
/* This information comes from the LPRng HOWTO, which also describes
|
|
RFC 1179. http://www.astart.com/lprng/LPRng-HOWTO.html */
|
|
char *lpd_client_code[] = {
|
|
"Unknown command",
|
|
"LPC: start print / jobcmd: abort",
|
|
"LPR: transfer a printer job / jobcmd: receive control file",
|
|
"LPQ: print short form of queue status / jobcmd: receive data file",
|
|
"LPQ: print long form of queue status",
|
|
"LPRM: remove jobs",
|
|
"LPRng lpc: do control operation",
|
|
"LPRng lpr: transfer a block format print job",
|
|
"LPRng lpc: secure command transfer",
|
|
"LPRng lpq: verbose status information"
|
|
};
|
|
char *lpd_server_code[] = {
|
|
"Success: accepted, proceed",
|
|
"Queue not accepting jobs",
|
|
"Queue temporarily full, retry later",
|
|
"Bad job format, do not retry"
|
|
};
|
|
|
|
if (check_col(pinfo->fd, COL_PROTOCOL))
|
|
col_set_str(pinfo->fd, COL_PROTOCOL, "LPD");
|
|
if (check_col(pinfo->fd, COL_INFO))
|
|
col_clear(pinfo->fd, COL_INFO);
|
|
|
|
/* rfc1179 states that all responses are 1 byte long */
|
|
code = tvb_get_guint8(tvb, 0);
|
|
if (tvb_reported_length(tvb) == 1) {
|
|
lpr_packet_type = response;
|
|
}
|
|
else if (code <= 9) {
|
|
lpr_packet_type = request;
|
|
}
|
|
else {
|
|
lpr_packet_type = unknown;
|
|
}
|
|
|
|
if (check_col(pinfo->fd, COL_INFO)) {
|
|
if (lpr_packet_type == request) {
|
|
col_add_str(pinfo->fd, COL_INFO, lpd_client_code[code]);
|
|
}
|
|
else if (lpr_packet_type == response) {
|
|
col_set_str(pinfo->fd, COL_INFO, "LPD response");
|
|
}
|
|
else {
|
|
col_set_str(pinfo->fd, COL_INFO, "LPD continuation");
|
|
}
|
|
}
|
|
|
|
if (tree) {
|
|
ti = proto_tree_add_item(tree, proto_lpd, tvb, 0,
|
|
tvb_length(tvb), FALSE);
|
|
lpd_tree = proto_item_add_subtree(ti, ett_lpd);
|
|
|
|
if (lpr_packet_type == response) {
|
|
proto_tree_add_boolean_hidden(lpd_tree, hf_lpd_response,
|
|
tvb, 0, 0, TRUE);
|
|
} else {
|
|
proto_tree_add_boolean_hidden(lpd_tree, hf_lpd_request,
|
|
tvb, 0, 0, TRUE);
|
|
}
|
|
|
|
if (lpr_packet_type == request) {
|
|
printer_len = find_printer_string(tvb, 1);
|
|
|
|
if (code <= 9 && printer_len != -1) {
|
|
proto_tree_add_text(lpd_tree, tvb, 0, 1,
|
|
lpd_client_code[code]);
|
|
proto_tree_add_text(lpd_tree, tvb, 1, printer_len,
|
|
"Printer/options: %s",
|
|
tvb_format_text(tvb, 1, printer_len));
|
|
}
|
|
else {
|
|
dissect_data(tvb, 0, pinfo, tree);
|
|
}
|
|
}
|
|
else if (lpr_packet_type == response) {
|
|
if (code <= 3) {
|
|
proto_tree_add_text(lpd_tree, tvb, 0, 1,
|
|
"Response: %s", lpd_server_code[code]);
|
|
}
|
|
else {
|
|
dissect_data(tvb, 0, pinfo, tree);
|
|
}
|
|
}
|
|
else {
|
|
dissect_data(tvb, 0, pinfo, tree);
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
static gint
|
|
find_printer_string(tvbuff_t *tvb, int offset)
|
|
{
|
|
int i;
|
|
|
|
/* try to find end of string, either '\n' or '\0' */
|
|
i = tvb_find_guint8(tvb, offset, -1, '\0');
|
|
if (i == -1)
|
|
i = tvb_find_guint8(tvb, offset, -1, '\n');
|
|
if (i == -1)
|
|
return -1;
|
|
return i - offset; /* length of string */
|
|
}
|
|
|
|
|
|
void
|
|
proto_register_lpd(void)
|
|
{
|
|
static hf_register_info hf[] = {
|
|
{ &hf_lpd_response,
|
|
{ "Response", "lpd.response",
|
|
FT_BOOLEAN, BASE_NONE, NULL, 0x0,
|
|
"TRUE if LPD response" }},
|
|
|
|
{ &hf_lpd_request,
|
|
{ "Request", "lpd.request",
|
|
FT_BOOLEAN, BASE_NONE, NULL, 0x0,
|
|
"TRUE if LPD request" }}
|
|
};
|
|
static gint *ett[] = {
|
|
&ett_lpd,
|
|
};
|
|
|
|
proto_lpd = proto_register_protocol("Line Printer Daemon Protocol", "LPD", "lpd");
|
|
proto_register_field_array(proto_lpd, hf, array_length(hf));
|
|
proto_register_subtree_array(ett, array_length(ett));
|
|
}
|
|
|
|
void
|
|
proto_reg_handoff_lpd(void)
|
|
{
|
|
dissector_add("tcp.port", TCP_PORT_PRINTER, &dissect_lpd, proto_lpd);
|
|
}
|