18f0109969
qstring.toUtf8() returns a QByteArray object and .constData() returns a pointer inside that object. It is not safe to store this pointer as it will become invalid after the statement. Store a const reference instead. (Due to scoping differences, some are copy-assigned though.) In the UAT dialog, strlen(bytes.constData()) has also been replaced by bytes.size() as an optimization. Caught by ASAN. Change-Id: Ie09f999a32d0ef1abaa1e658b9403b74bedffc37 Reviewed-on: https://code.wireshark.org/review/5528 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
76 lines
2.1 KiB
C++
76 lines
2.1 KiB
C++
/* export_pdu_dialog.cpp
|
|
* Dialog for exporting PDUs to file
|
|
*
|
|
* Wireshark - Network traffic analyzer
|
|
* By Gerald Combs <gerald@wireshark.org>
|
|
* Copyright 1998 Gerald Combs
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include "export_pdu_dialog.h"
|
|
#include "ui_export_pdu_dialog.h"
|
|
|
|
#include "globals.h"
|
|
#include "pcap-encap.h"
|
|
|
|
#include <epan/tap.h>
|
|
#include <epan/exported_pdu.h>
|
|
|
|
#include "ui/tap_export_pdu.h"
|
|
|
|
ExportPDUDialog::ExportPDUDialog(QWidget *parent) :
|
|
QDialog(parent),
|
|
ui(new Ui::ExportPDUDialog)
|
|
{
|
|
GSList *tap_name_list;
|
|
|
|
ui->setupUi(this);
|
|
|
|
for (tap_name_list = get_export_pdu_tap_list(); tap_name_list; tap_name_list = g_slist_next(tap_name_list)) {
|
|
ui->comboBox->addItem((const char*)(tap_name_list->data));
|
|
}
|
|
}
|
|
void ExportPDUDialog::on_buttonBox_accepted()
|
|
{
|
|
exp_pdu_t exp_pdu_data;
|
|
|
|
exp_pdu_data.pkt_encap = wtap_wtap_encap_to_pcap_encap(WTAP_ENCAP_WIRESHARK_UPPER_PDU);
|
|
|
|
const QByteArray& filter = ui->displayFilterLineEdit->text().toUtf8();
|
|
const QByteArray& tap_name = ui->comboBox->currentText().toUtf8();
|
|
|
|
do_export_pdu(filter.constData(), (gchar *)tap_name.constData(), &exp_pdu_data);
|
|
}
|
|
ExportPDUDialog::~ExportPDUDialog()
|
|
{
|
|
delete ui;
|
|
}
|
|
|
|
/*
|
|
* Editor modelines
|
|
*
|
|
* Local Variables:
|
|
* c-basic-offset: 4
|
|
* tab-width: 8
|
|
* indent-tabs-mode: nil
|
|
* End:
|
|
*
|
|
* ex: set shiftwidth=4 tabstop=8 expandtab:
|
|
* :indentSize=4:tabSize=8:noTabs=true:
|
|
*/
|