wireshark/epan
Dhiru Kholia 013675c9ad DHCPv4: Fix dissection of packets using HMAC-MD5 authentication
See https://tools.ietf.org/html/rfc3118#section-5.2 (Authentication for
DHCP Messages) for more details.

Sample DHCPv4 authentication .pcap file can be found at,
https://wiki.wireshark.org/SampleCaptures

Without this patch, Wireshark shows "Expert Info (Error/Protocol):
length isn't >= 31" error message in the Authentication section of the
packet dissection.

Change-Id: I2af5c7d18f0497a131b1d2dc50ee6e4708c34e28
Signed-off-by: Dhiru Kholia <dhiru.kholia@gmail.com>
Reviewed-on: https://code.wireshark.org/review/28360
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21 13:30:15 +00:00
..
crypt dot11decrypt(crypt): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 2018-06-15 15:19:33 +00:00
dfilter Better name for the routine. 2018-06-18 00:30:37 +00:00
dissectors DHCPv4: Fix dissection of packets using HMAC-MD5 authentication 2018-06-21 13:30:15 +00:00
ftypes character constant in dfilter now must fit into one byte 2018-06-17 21:16:13 +00:00
wmem fix missing parentheses in 'if' statement 2018-05-03 04:09:42 +00:00
wslua wslua: fix NSTime:__tostring for negative values 2018-05-25 12:50:18 +00:00
.editorconfig
CMakeLists.txt Fix build paths for cmake's Xcode project generator on macOS. 2018-06-21 03:33:03 +00:00
addr_and_mask.c
addr_and_mask.h
addr_resolv.c Remove tabs around manuf names as shown for BASE_OUI 2018-06-01 09:19:23 +00:00
addr_resolv.h Do IP address resolution synchronously before printing in TShark. 2018-05-23 03:52:09 +00:00
address.h
address_types.c
address_types.h
afn.c
afn.h
aftypes.c
aftypes.h
app_mem_usage.c
app_mem_usage.h
arcnet_pids.h
arptypes.h
asn1.c
asn1.h
ax25_pids.h
bridged_pids.h
capture_dissectors.c Qt: Implement the capture info dialog. 2018-05-16 04:26:36 +00:00
capture_dissectors.h
charsets.c
charsets.h
chdlctypes.h
color_filters.c glib: Use g_slist_free_full() in a couple of places. 2018-04-17 15:01:24 +00:00
color_filters.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
column-info.h
column-utils.c fix missing parentheses in 'if' statement 2018-05-03 04:09:42 +00:00
column-utils.h
column.c
column.h
conv_id.h
conversation.c
conversation.h
conversation_debug.h
conversation_table.c Get rid of a GTK+-only field. 2018-05-16 08:16:15 +00:00
conversation_table.h Get rid of a GTK+-only field. 2018-05-16 08:16:15 +00:00
crc6-tvb.c
crc6-tvb.h
crc8-tvb.c
crc8-tvb.h
crc10-tvb.c
crc10-tvb.h
crc16-tvb.c
crc16-tvb.h
crc32-tvb.c
crc32-tvb.h
decode_as.c
decode_as.h
diam_dict.h
diam_dict.l If we're reading from a string, don't fclose yyin. 2018-04-03 01:04:09 +00:00
disabled_protos.c
disabled_protos.h
dissector_filters.c
dissector_filters.h
dtd.h
dtd_grammar.lemon Use common indenting space in heading 2018-05-01 06:55:55 +00:00
dtd_parse.h Use common indenting space in heading 2018-05-01 06:55:55 +00:00
dtd_parse.l
dtd_preparse.l
dvb_chartbl.c
dvb_chartbl.h
eap.h
eapol_keydes_types.h
epan.c Free dynamic header fields on exit 2018-06-03 20:18:05 +00:00
epan.h Switch the Doxygen API reference build to CMake. 2018-04-17 03:46:05 +00:00
epan_dissect.h
etypes.h
ex-opt.c
ex-opt.h
except.c Clean up REPORT_DISSECTOR_BUG(). 2018-03-25 23:49:35 +00:00
except.h Clean up REPORT_DISSECTOR_BUG(). 2018-03-25 23:49:35 +00:00
exceptions.h Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
exntest.c
expert.c expert: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 2018-06-18 08:30:59 +00:00
expert.h
export_object.c
export_object.h
exported_pdu.c glib: Use g_slist_free_full() in a couple of places. 2018-04-17 15:01:24 +00:00
exported_pdu.h
filter_expressions.c Fix minor leak in filter_expression_new. 2018-04-28 16:28:18 +00:00
filter_expressions.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
follow.c
follow.h
frame_data.c
frame_data.h Older versions of Clang don't understand -Wpedantic. 2018-05-18 22:31:05 +00:00
frame_data_sequence.c
frame_data_sequence.h
funnel.c
funnel.h
garrayfix.h
golay.c
golay.h
guid-utils.c
guid-utils.h
iana_charsets.c
iana_charsets.h
iax2_codec_type.h
in_cksum.c
in_cksum.h
ip_opts.h
ipproto.c
ipproto.h
ipv4.h
ipv6.h
lapd_sapi.h
llcsaps.h
maxmind_db.c maxmind_db.c: fix a memory leak 2018-05-26 05:55:56 +00:00
maxmind_db.h
media_params.c
media_params.h
next_tvb.c
next_tvb.h
nlpid.h
oids.c Free g_array_free-related memory leaks 2018-05-14 13:44:23 +00:00
oids.h
oids_test.c
osi-utils.c Fix incorrect formatting of NSAP area addresses/address prefixes. 2018-05-27 18:56:41 +00:00
osi-utils.h Fix incorrect formatting of NSAP area addresses/address prefixes. 2018-05-27 18:56:41 +00:00
oui.h ieee80211: Add dissector for Aerohive vendor specific IE 2018-05-24 11:22:57 +00:00
packet.c Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
packet.h
packet_info.h
params.h
plugin_if.c plugin_if: fix small memory leak in ext_menubar_add_separator 2018-05-05 05:57:25 +00:00
plugin_if.h
ppptypes.h
prefs-int.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
prefs.c Qt: Configure the selection color via the preferences 2018-05-25 11:07:01 +00:00
prefs.h Qt: Configure the selection color via the preferences 2018-05-25 11:07:01 +00:00
print.c glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0 2018-04-16 16:07:46 +00:00
print.h
print.ps
print_stream.c
print_stream.h
proto.c Do bounds checking of the offset and length in proto_tree_add_string(). 2018-06-10 01:12:31 +00:00
proto.h When using the NEW_PROTO_TREE_API, the proto_tree_add... functions are 2018-06-04 20:33:36 +00:00
proto_data.c
proto_data.h
ps.h
ptvcursor.h
radius_dict.l Free g_array_free-related memory leaks 2018-05-14 13:44:23 +00:00
range.c
range.h
reassemble.c
reassemble.h
reassemble_test.c reasemble_test: fix issue found by PVS Studio (V519) 2018-05-17 07:40:04 +00:00
reedsolomon.c
reedsolomon.h
register.c glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0 2018-04-16 16:07:46 +00:00
register.h
req_resp_hdrs.c
req_resp_hdrs.h
rtd_table.c Get rid of some GTK+-only stuff. 2018-05-12 23:01:14 +00:00
rtd_table.h Get rid of some GTK+-only stuff. 2018-05-12 23:01:14 +00:00
rtp_pt.h
sctpppids.h
sequence_analysis.c glib: Get rid of GLIB_CHECK_VERSION as we now require 2.32.0 2018-04-16 16:07:46 +00:00
sequence_analysis.h
show_exception.c Put protocol name before "length of contained item...". 2018-04-22 21:45:48 +00:00
show_exception.h
slow_protocol_subtypes.h
sminmpec.h epan: Trivial constant sort order fix - sminmpec.h 2018-04-21 06:10:35 +00:00
srt_table.c Get rid of some GTK+-only stuff. 2018-05-13 19:46:45 +00:00
srt_table.h Get rid of some GTK+-only stuff. 2018-05-13 19:46:45 +00:00
stat_groups.h
stat_tap_ui.c Get rid of some GTK+-only stuff. 2018-05-13 20:21:14 +00:00
stat_tap_ui.h Get rid of some GTK+-only stuff. 2018-05-13 20:21:14 +00:00
stats_tree.c Free g_array_free-related memory leaks 2018-05-14 13:44:23 +00:00
stats_tree.h
stats_tree_priv.h Remove some GTK+-only code. 2018-04-17 03:44:47 +00:00
stream.c
stream.h
strutil.c
strutil.h
t35.c
t35.h
tap-voip.h
tap.c Eliminate some unneeded header checks. 2018-05-16 22:03:09 +00:00
tap.h tap: fix remaining potential memleaks with register_tap_listener 2018-03-27 04:51:00 +00:00
tfs.c
tfs.h
time_fmt.h
timestamp.c
timestamp.h
timestats.c
timestats.h
to_str-int.h
to_str.c
to_str.h
tvbparse.c
tvbparse.h Use common indenting space in heading 2018-05-01 06:55:55 +00:00
tvbtest.c Update some comments. 2018-04-20 02:58:36 +00:00
tvbuff-int.h Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
tvbuff.c tvbuff: make tvb_bytes_exist fail with negative values 2018-05-14 13:07:23 +00:00
tvbuff.h Update some comments. 2018-04-20 02:58:36 +00:00
tvbuff_base64.c
tvbuff_composite.c Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
tvbuff_real.c Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
tvbuff_subset.c Handle subset tvbuffs where the length goes past the end of the parent. 2018-04-20 03:18:47 +00:00
tvbuff_zlib.c tvbuff_zlib: reject negative lengths to avoid buffer overrun 2018-05-15 17:16:12 +00:00
uat-int.h
uat.c
uat.h
uat_load.l
unit_strings.c
unit_strings.h
value_string.c
value_string.h
x264_prt_id.h
xdlc.c
xdlc.h