Commit Graph

1819 Commits

Author SHA1 Message Date
Jakub Zawadzki 97d59088b0 #gtk #packet-list simplify, use gtk_tree_view_column_add_attribute() for text attribute.
svn path=/trunk/; revision=50176
2013-06-26 22:03:57 +00:00
Jakub Zawadzki 0426c05d49 packet-editor: Allow focus for byteview, it should fix problems with field hexeditor not getting key-press-event.
Generally it should be also safe for builds without packet-editor, just in case ifdef it.

svn path=/trunk/; revision=50172
2013-06-26 17:15:25 +00:00
Jeff Morriss 500d399393 Move tap-*-common.{h,c} into ui/ since that's the home for common UI functions.
svn path=/trunk/; revision=50165
2013-06-26 02:12:12 +00:00
Jeff Morriss bbf6a3766e Move tempfile.{h,c} into wsutil.
svn path=/trunk/; revision=50163
2013-06-26 01:14:35 +00:00
Jeff Morriss 74dc568ef1 As pointed out by Guy: timestats uses packet_info so it belongs in epan
not wsutil.

svn path=/trunk/; revision=50159
2013-06-26 00:18:44 +00:00
Jeff Morriss 2259c5c47d There's no need to compile timestats.c any more--it's now in libwsutil.
svn path=/trunk/; revision=50157
2013-06-25 23:34:07 +00:00
Jeff Morriss a441793cba Move a couple of time-related modules into wsutil.
A bunch of files didn't really need to include these header files so remove
the include line rather than changing it.

svn path=/trunk/; revision=50154
2013-06-25 22:02:20 +00:00
Guy Harris 847fbeefdb Fix build with packet editor enabled. (Fix a typo while we're at it.)
svn path=/trunk/; revision=50153
2013-06-25 21:45:56 +00:00
Jakub Zawadzki f0c9b34b55 Allocate memory for col_text[_len] when really needed
remove columnized bit, now the same can be done with col_text.

svn path=/trunk/; revision=50144
2013-06-25 18:27:31 +00:00
Jakub Zawadzki f56d9b49b3 packet_list_iter_children() simplify, just call packet_list_iter_nth_child(..., 0)
svn path=/trunk/; revision=50143
2013-06-25 18:07:33 +00:00
Stephen Fisher ca99b7a50a Cast away another implicit conversion not allowed in C++ warning
svn path=/trunk/; revision=50109
2013-06-21 22:37:40 +00:00
Chris Maynard eb0d10c9d2 Sort the man pages. Add capinfos and reordercap. Should we also any others (i.e., asn2deb, dftest, idl2deb, idl2wrs, randpkt)?
svn path=/trunk/; revision=50107
2013-06-21 15:30:08 +00:00
Evan Huus 50bc11bc14 One more fix for the protocol grey highlighting.
svn path=/trunk/; revision=50100
2013-06-21 00:49:35 +00:00
Jakub Zawadzki 2bd2bfb416 Yet another fix, put spaces in insensitive or normal state.
svn path=/trunk/; revision=50099
2013-06-21 00:42:19 +00:00
Jakub Zawadzki 135ecc1d88 fix for r50095 don't fetch parent hfinfo, traverse tree to get top one.
svn path=/trunk/; revision=50098
2013-06-21 00:23:55 +00:00
Jakub Zawadzki 1b69a2b3c8 Highlight protocol bytes in grey, idea stolen from qtshark
svn path=/trunk/; revision=50095
2013-06-20 23:28:35 +00:00
Gerald Combs 879d865039 Sort the encapsulation type combo box similar to the GTK change in r50077.
svn path=/trunk/; revision=50081
2013-06-20 18:07:54 +00:00
Evan Huus 2dab2c8102 Fix file_import_dlg.c:132: warning: useless storage class specifier in empty
declaration

I guess anonymous enums can't be static?

svn path=/trunk/; revision=50079
2013-06-20 16:44:46 +00:00
Chris Maynard 9229a5eeb3 Sort the list of encapsulation types, but still have Ethernet be the default.
svn path=/trunk/; revision=50077
2013-06-20 16:40:46 +00:00
Martin Kaiser 88a4c49bf7 update the button in the status bar when a packet comment is added
(this is a quick fix, the case when the last comment is removed
 is still not handled correctly)

svn path=/trunk/; revision=50069
2013-06-19 23:37:38 +00:00
Martin Mathieson 8411a601df Implement bug 8675: show stream id in follow TCP stream window.
svn path=/trunk/; revision=50067
2013-06-19 23:27:12 +00:00
Martin Mathieson 21a682ea24 Fix for bug 6090. Clear the list store when resetting the dialog.
svn path=/trunk/; revision=50064
2013-06-19 22:57:39 +00:00
Chris Maynard 3369a97da7 If the user turns off printing of the packet summary line, disable the column headings checkbox; otherwise, enable it.
svn path=/trunk/; revision=50053
2013-06-19 19:16:35 +00:00
Gerald Combs ba951e1a4d Try to make it more obvious that you can select unselected task list
items.

svn path=/trunk/; revision=50052
2013-06-19 18:48:20 +00:00
Chris Maynard f655e90d8b Remove col_headings_cb from print_cmd_toggle_detail() altogether. It's not needed since if summary isn't printed, neither are column headings anyway.
svn path=/trunk/; revision=50051
2013-06-19 18:44:42 +00:00
Evan Huus 50da1aacf9 Try and keep r50047 and still fix
print_dlg.c:916: warning: value computed is not used

svn path=/trunk/; revision=50050
2013-06-19 18:38:52 +00:00
Jörg Mayer 95a68da158 Fix for
Building C object ui/gtk/CMakeFiles/gtkui.dir/print_dlg.c.o
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c: In function ‘print_cmd_toggle_detail’:
/home/jmayer/work/wireshark/svn/trunk/ui/gtk/print_dlg.c:910:38: error: variable ‘col_headings_cb’ set but not used [-Werror=unused-but-set-variable]
   GtkWidget *print_bt, *summary_cb, *col_headings_cb, *details_cb;
                                      ^
cc1: all warnings being treated as errors

No idea wether the fix is correct. Compile tested only.

svn path=/trunk/; revision=50047
2013-06-19 18:30:04 +00:00
Chris Maynard 909d2eb309 Allow for column headers not to be printed in order to make it possible to export packets as plain text in a format that could then have a chance of being imported again (assuming other factors such as packet bytes were printed, etc.) in order to recover the original pcap file.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1636

svn path=/trunk/; revision=50036
2013-06-19 15:22:56 +00:00
Pascal Quantin d09ffee44e Add ability to export decrypted IPsec PDUs
svn path=/trunk/; revision=50022
2013-06-18 23:01:46 +00:00
Alexis La Goutte b381ca4f58 Fix qt make buildbot step
Qt make don't like cp ../../lib/lib{wireshark,wiretap,wsutil}.* .
cp: cannot stat `../../lib/lib{wireshark,wiretap,wsutil}.*': No such file or directory

svn path=/trunk/; revision=49994
2013-06-17 22:56:35 +00:00
Martin Mathieson 860b920383 Make the B->A graph label show as A<-B to be consistent with the column
heading.

svn path=/trunk/; revision=49954
2013-06-16 02:35:51 +00:00
Guy Harris ca0f8ee6da Make the libwiretap Buffer routines usable from C++, and fix the C++ UI
code to handle the API changes for the seek-read routines.

svn path=/trunk/; revision=49950
2013-06-16 01:40:04 +00:00
Guy Harris 8c9edf1280 Have the seek-read routines take a Buffer rather than a guint8 pointer
as the "where to put the packet data" argument.

This lets more of the libwiretap code be common between the read and
seek-read code paths, and also allows for more flexibility in the "fill
in the data" path - we can expand the buffer as needed in both cases.

svn path=/trunk/; revision=49949
2013-06-16 00:20:00 +00:00
Chris Maynard 2c71f23d1e Make use of text metrics and devmode data to properly format a page for printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49946
2013-06-15 12:57:32 +00:00
Chris Maynard 14b65f91a4 Ensure that Wireshark isn't obscured by the system taskbar or by any other desktop toolbars. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3034
#BACKPORT(1.10,1.8)

svn path=/trunk/; revision=49937
2013-06-14 17:47:54 +00:00
Gerald Combs af02ac36ac On OS X set the toolbar icon size to match our current icons.
svn path=/trunk/; revision=49919
2013-06-13 18:58:29 +00:00
Jeff Morriss 51b02ed94d From Peter Hatina via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8793 :
Fix crash if you cancel the Flow Graph window while the Graph Analysis window
is still open: close the Graph Analysis window when the user cancels the Flow
Graph window.

From me: do the same thing for the window-delete case.

svn path=/trunk/; revision=49908
2013-06-12 15:50:37 +00:00
Gerald Combs f5e892cbac Check for QtMacExtras, and if we have it use it to switch to a native
title + toolbar on OS X.

svn path=/trunk/; revision=49873
2013-06-10 21:21:51 +00:00
Gerald Combs 3d59df0ed6 Removing libui_dirty.a in r48976 broke CMake + Qt Creator builds. Fix
it.

svn path=/trunk/; revision=49872
2013-06-10 19:04:13 +00:00
Guy Harris 0b8d569887 If, after editing the settings for a particular interface, we don't have
a Capture Options window to update, don't try to update it.

#BACKPORT

svn path=/trunk/; revision=49850
2013-06-09 00:24:28 +00:00
Jakub Zawadzki a12ee2e673 Fix 'Misaligned columns in hex dump pane' [1]
Old code was broken for all pango version < 1.20

[1] http://www.wireshark.org/lists/wireshark-dev/201306/msg00015.html

svn path=/trunk/; revision=49848
2013-06-08 18:57:49 +00:00
Stig Bjørlykke e4893f0448 Ensure we only put private profiles directly in the profiles menu and
put global profiles in the "New from Global" menu.

svn path=/trunk/; revision=49830
2013-06-07 06:53:24 +00:00
Alexis La Goutte a4d78ca253 From report of IgorVK via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8736 Crash analyzing VoIP Calls
Wireshark crashes when analyzing Telephony->VoIP Calls from the pcap file attached.

From me :
Some packets is detect to be T38 and ->stop_fd is not initialize

#Backport 1.10 and 1.8

svn path=/trunk/; revision=49804
2013-06-06 16:00:23 +00:00
Chris Maynard b4414c61d9 As of r49659, StatisticsMenu is now just Statistics.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8770

svn path=/trunk/; revision=49788
2013-06-05 16:42:22 +00:00
Gerald Combs 8b4b8154a4 The CommDlg_OpenSave_GetFilePath macro fetches the path+name of the most
recently selected file in the current file dialog. This isn't the proper
routine to use when trying to figure out the save/export file name. We
have to dig through the OPENFILENAME struct instead. Fixes bug 8224.

#Backport 1.10

svn path=/trunk/; revision=49765
2013-06-04 18:07:59 +00:00
Anders Broman 78e334b845 From Mike Garratt:
Friendly Names support causing unnecessary delay when Wireshark starts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8034

svn path=/trunk/; revision=49752
2013-06-04 04:36:19 +00:00
Chris Maynard 27872a9324 Apply the same tooltip for the text entry as for the updated label tooltip in r49726, but with a typo fix: "thefield" -> "the field".
svn path=/trunk/; revision=49727
2013-06-03 20:34:50 +00:00
Gerald Combs a0823d82c9 Custom columns are specified using display filter field names, not
display filters.

svn path=/trunk/; revision=49726
2013-06-03 20:01:15 +00:00
Guy Harris 00ea06430a Implement PARAM_UINT as a spin button with a range of 0 to G_MAXUINT.
svn path=/trunk/; revision=49669
2013-06-01 01:23:59 +00:00
Guy Harris a8e7b7ccfe Neither gtk_mac_lte_stat_init() nor gtk_rlc_lte_stat_init() are referred
to outside the files that define them; make them static.

svn path=/trunk/; revision=49664
2013-05-31 23:07:51 +00:00