Gerald Combs
d1f6e2e3ec
Use a not-quite-black background for marked packets.
...
http://ianstormtaylor.com/design-tip-never-use-black/
svn path=/trunk/; revision=47392
2013-01-31 18:46:40 +00:00
Bill Meier
959ae3d687
Use '#if 0 ... #endif' rather than /** ... **/ to comment out
...
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47391
2013-01-31 18:35:06 +00:00
Bill Meier
d3a7f4b817
Use '#if 0 ... #endif' rather than /** ... **/ to comment out
...
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47390
2013-01-31 18:31:28 +00:00
Bill Meier
c439b805e2
Comment out unused hf[] entries & etc.
...
(found by checkhf)
svn path=/trunk/; revision=47389
2013-01-31 17:55:31 +00:00
Chris Maynard
8ee3809edc
Add 2 more verification steps to run in the "Submitting code for your new dissector" section.
...
svn path=/trunk/; revision=47388
2013-01-31 17:17:34 +00:00
Chris Maynard
eb5fcc8d01
Fix Coverity CID 971261: Unused pointer value. Additionally, #if 0 two unused value_string's (should they be deleted altogether?), minor whitespace cleanup, delete a continuation character, try to use a consistent bracketing style throughout. [Is "Movment" a typo?]
...
svn path=/trunk/; revision=47387
2013-01-31 17:07:19 +00:00
Anders Broman
4a8f124c43
Add an OID translation.
...
svn path=/trunk/; revision=47386
2013-01-31 16:59:39 +00:00
Guy Harris
a4902853a5
Constify a variable to which C string pointers will be assigned.
...
svn path=/trunk/; revision=47385
2013-01-31 06:50:24 +00:00
Guy Harris
094e30f9db
Fix RCS ID.
...
svn path=/trunk/; revision=47384
2013-01-31 06:49:34 +00:00
Guy Harris
7999b06d76
Get rid of CR's, and set the appropriate properties.
...
svn path=/trunk/; revision=47383
2013-01-31 06:49:05 +00:00
Michael Mann
9ee8360e4a
Add Parrot AR Drone dissector.
...
Bug 7493 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7493 )
svn path=/trunk/; revision=47382
2013-01-31 03:52:06 +00:00
Martin Kaiser
574c0d20d4
add missing case
...
svn path=/trunk/; revision=47380
2013-01-30 23:25:36 +00:00
Guy Harris
9b23449384
Clean up white space.
...
svn path=/trunk/; revision=47379
2013-01-30 22:56:05 +00:00
Guy Harris
b2fd895135
Clean up white space.
...
Define the PNG magic number as a mixture of hex and ASCII, to make it a
bit clearer what's going on.
svn path=/trunk/; revision=47378
2013-01-30 22:55:32 +00:00
Guy Harris
e9479b543f
A "DAAP request" is just an HTTP request of a certain type, possibly on
...
port 3689. They don't have the media type application/x-dmap-tagged, so
they're not handed to us any more. (This means that the Info column now
shows the HTTP URI rather than just "DAAP Request", so that's arguably a
feature; if you want to see all the traffic in the session, use "Follow
TCP Stream" or look for port 3689.)
svn path=/trunk/; revision=47377
2013-01-30 21:56:54 +00:00
Guy Harris
a4714f643a
Add a routine to allow dissectors to specify ports that carry HTTP
...
traffic *without* claiming all that traffic for themselves; they might
want, instead, to register for a particular media type.
Not all traffic to or from port 3689 is DAAP - not even traffic between
two Apple machines doing media stuff (e.g., some FairPlay traffic
isn't). Register for the media type application/x-dmap-tagged, and just
say port 3689 is HTTP. This means we can get rid of the FPLY hack, as
that traffic is application/octet-stream. Update some comments.
Leave it up to the DAAP dissector to tag traffic as DAAP in the protocol
column.
svn path=/trunk/; revision=47376
2013-01-30 21:49:33 +00:00
Guy Harris
8499f78705
Set properties.
...
svn path=/trunk/; revision=47375
2013-01-30 21:37:01 +00:00
Guy Harris
47b8a34ebb
GPOINTER_TO_INT() is the inverse of GINT_TO_POINTER().
...
svn path=/trunk/; revision=47374
2013-01-30 21:31:45 +00:00
Guy Harris
d29e1b5604
Use optargp, not optarg, in followSsl(), as in other routines; this
...
squelches a shadowing warning.
svn path=/trunk/; revision=47373
2013-01-30 21:07:19 +00:00
Michael Mann
7f3064e6ae
Add support in TShark to follow SSL streams
...
From QA Cafe, bug 8280 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8280 )
svn path=/trunk/; revision=47372
2013-01-30 20:36:47 +00:00
Gerald Combs
9296fcc310
Fix more dependencies.
...
svn path=/trunk/; revision=47371
2013-01-30 20:32:44 +00:00
Guy Harris
b1e6d2730e
Some FairPlay stuff in DAAP starts out with a 4-character FPLY tag, but
...
what follows the tag isn't a length, it's some unknown form of data.
svn path=/trunk/; revision=47370
2013-01-30 20:08:50 +00:00
Gerald Combs
f0d670afb3
Fix a couple of dependencies.
...
svn path=/trunk/; revision=47369
2013-01-30 19:58:12 +00:00
Michael Mann
d6901da1d1
Wiretap: Add support for files contain GIF, PNG images
...
From Michal Labedzki, bug 8278 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8278 )
svn path=/trunk/; revision=47368
2013-01-30 19:26:05 +00:00
Evan Huus
942ac68bdc
Add a cast to hopefully quiet the mac buildbot.
...
svn path=/trunk/; revision=47367
2013-01-30 01:14:13 +00:00
Evan Huus
b8a74f33b6
Add SVN properties, modelines.
...
svn path=/trunk/; revision=47366
2013-01-30 01:09:31 +00:00
Michael Mann
e5ba6f9b1e
Add Gearman dissector. Bug 4992 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4992 )
...
svn path=/trunk/; revision=47365
2013-01-30 00:59:27 +00:00
Gerald Combs
2afe999c21
Copy over r47277 from ui/gtk.
...
svn path=/trunk/; revision=47364
2013-01-30 00:07:57 +00:00
Martin Kaiser
b48fb53c7e
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-AQojcV.html#EndPath
svn path=/trunk/; revision=47363
2013-01-29 23:35:30 +00:00
Martin Kaiser
a32b153890
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-eehjto.html#EndPath
svn path=/trunk/; revision=47362
2013-01-29 22:33:37 +00:00
Martin Kaiser
4a64d51119
simplify dissect_gds() a bit
...
svn path=/trunk/; revision=47360
2013-01-29 22:15:06 +00:00
Martin Kaiser
b3f2e26a7a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
http://www.wireshark.org/download/automated/analysis/scan-build-2013-01-28-1/report-tWikJH.html#EndPath
svn path=/trunk/; revision=47359
2013-01-29 22:04:32 +00:00
Michael Mann
5d026123c4
Make eDonkey dissector a "new style" and only dissect if first byte matches a valid eDonkey protocol. This addresses the problem of Bug 3033 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3033 ), but I'm still not sure eDonkey should have explicitly registered TCP and UDP ports.
...
svn path=/trunk/; revision=47349
2013-01-29 18:16:23 +00:00
Michael Mann
23168c9677
Get Server Info should not have any data unless "challenged", per eMule source code. Addresses bug 3509 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3509 ).
...
Also updated documentation links.
svn path=/trunk/; revision=47345
2013-01-29 15:43:33 +00:00
Bill Meier
c268f2c153
Add missing '&hf_gtpv2_bss_con_xid' entry to hf[].
...
(Found by checkhf)
Fix apparent issues with two hf[] entries.
Also: Do minor whitespace cleanup.
##Baclport 1.8
svn path=/trunk/; revision=47344
2013-01-29 14:31:21 +00:00
Bill Meier
39886c79cb
Add missing '&hf_fw1_trailer' hf[] entry;
...
Found by checkhf.
## Backport 1.8
svn path=/trunk/; revision=47343
2013-01-29 14:18:04 +00:00
Bill Meier
ef242060b8
Add an XXX comment about some code which will never be executed;
...
Also: mention that there's a missing hf[] entry.
svn path=/trunk/; revision=47342
2013-01-29 13:59:17 +00:00
Bill Meier
3520ab3889
Add missing 'hf_scsi_persresv_control_unreg' hf[] entry.
...
(Found by checkhf)
Do some minor whitespace cleanup.
svn path=/trunk/; revision=47341
2013-01-29 13:53:16 +00:00
Bill Meier
f10906369a
Remove some unneeded parens in hf[] entries;
...
svn path=/trunk/; revision=47340
2013-01-29 13:33:04 +00:00
Gerald Combs
ec880b7db3
Use readlink instead of ls.
...
svn path=/trunk/; revision=47338
2013-01-29 01:06:24 +00:00
Bill Meier
d1ae197ae4
Re-implemention of checkhf.pl:
...
Main objective: reduce the number of false positives.
(Committed as a patch to the original
checkhf.pl written by Joerg Mayer so as to
keep the history for the original program).
svn path=/trunk/; revision=47331
2013-01-28 22:23:32 +00:00
Bill Meier
7540ccc0ed
Delete checkhf-v2.pl from the repository.
...
(It will be re-submitted as a patch to
update(replace) the existing checkhf.pl
svn path=/trunk/; revision=47330
2013-01-28 22:15:06 +00:00
Balint Reczey
c6f9d4c131
make dumpabi target build with multiple digits in library version numbers
...
svn path=/trunk/; revision=47329
2013-01-28 21:45:44 +00:00
Michael Mann
8ad4ccb850
Allow SNMP user table entry to be re-editted even if engineID/Username remains the same.
...
Bug 2426 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2426 )
svn path=/trunk/; revision=47328
2013-01-28 21:08:14 +00:00
Bill Meier
4f1488181b
Re-implemention of checkhf.pl:
...
Main objective: reduce the number of false positives.
Normal usage: the same as for checkhf.pl.
For now: named checkhf-v2.pl
svn path=/trunk/; revision=47326
2013-01-28 19:58:54 +00:00
Anders Broman
80d3245f4a
Try to detect duplicated packets due to mirroring/span ports by comparing src MAC addresses.
...
svn path=/trunk/; revision=47324
2013-01-28 15:41:45 +00:00
Evan Huus
29f02b2bb2
Update the MSRP link, it's an actual RFC now.
...
svn path=/trunk/; revision=47323
2013-01-28 13:27:28 +00:00
Anders Broman
317ccb2ff9
Whitespace and doxygen comment changes.
...
svn path=/trunk/; revision=47322
2013-01-28 12:04:15 +00:00
Jaap Keuter
335b2bdc96
From Gyanesh:
...
Add SPBV MAC address sub-TLV support (802.1aq).
svn path=/trunk/; revision=47321
2013-01-28 06:46:21 +00:00
Martin Kaiser
fd85b72d51
the fragment id must depend on the transport connection
...
fragments from different transport connections can be interleaved
svn path=/trunk/; revision=47320
2013-01-27 22:08:29 +00:00