f26b250595
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8290 :
...
Allow up to 64 OPTIONAL / DEFAULT components per SEQUENCE
svn path=/trunk/; revision=47433
2013-02-01 22:44:14 +00:00
d3a7f4b817
Use '#if 0 ... #endif' rather than /** ... **/ to comment out
...
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47390
2013-01-31 18:31:28 +00:00
0960e508e4
Comment out cases of unused hf array entries found by checkhf.
...
svn path=/trunk/; revision=47302
2013-01-26 18:54:53 +00:00
59e4794390
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8216 :
...
Add basic dissection of UTF8String type in ASN.1 PER dissector
svn path=/trunk/; revision=47233
2013-01-23 20:50:18 +00:00
c5c24d2277
Only construct bit string if show internal per fields is set. Use tvb_get_bits
...
svn path=/trunk/; revision=46496
2012-12-11 07:01:43 +00:00
950325b82a
Cast result of strlen() from size_t to int.
...
svn path=/trunk/; revision=46480
2012-12-09 14:35:14 +00:00
394853ec7e
Similarly avoiding calling g_snprintf() in dissect_per_constrained_integer().
...
svn path=/trunk/; revision=46479
2012-12-09 04:49:58 +00:00
e5e25f8670
Speed up dissect_per_boolean() by avoiding call to ep_strdup_printf().
...
Saves 5% on a particular LTE log.
svn path=/trunk/; revision=46478
2012-12-09 04:23:46 +00:00
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
22c537a5f9
Try to fix the buildbot
...
svn path=/trunk/; revision=44588
2012-08-19 21:08:54 +00:00
c48bc11626
Apply the speed improvement from r44578 to 64bits variant and length determinant decoding.
...
Compute the buffer size so that it can contain the field name and the bit string display.
svn path=/trunk/; revision=44586
2012-08-19 18:15:20 +00:00
55e386dd5d
Calling g_strlcat() for every bit of a constrained integer was really
...
slow. Track the index and write the characters directly (while still
carefully checking that we don't spill the buffer).
svn path=/trunk/; revision=44578
2012-08-19 03:55:51 +00:00
d34ca4d69d
From Jan de Jongh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7624 :
...
dissect_per_constrained_integer_64b fails for 64 bits
svn path=/trunk/; revision=44510
2012-08-14 22:12:31 +00:00
1741731384
remove unnecessary underscores from display filters
...
svn path=/trunk/; revision=44181
2012-08-01 02:59:17 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
a923c28ede
Use restricted character string decoding for IA5String type
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6246
svn path=/trunk/; revision=43203
2012-06-11 13:54:06 +00:00
d53320919a
Remove unneeded #includes (stdlib, stdio, ctypes, time);
...
In a few cases: do some whitespace, indentation cleanup & reformatting.
svn path=/trunk/; revision=42632
2012-05-15 19:23:35 +00:00
f65cb5f27b
FALSE -> ENC_BIG_ENDIAN conversion
...
svn path=/trunk/; revision=42422
2012-05-04 16:35:59 +00:00
8f557d0874
Attempt to fix clang warnings (dead assignment, dereference of null pointer, branch condition evaluates to a garbage value)
...
svn path=/trunk/; revision=42392
2012-05-02 21:55:59 +00:00
80445e5a99
Fix off by one shift errors introduced in r39530 where it seemed proper[1]
...
[1] I'm unsure of packet-dtpt, so I haven't patch it.
svn path=/trunk/; revision=41873
2012-03-31 20:57:15 +00:00
42b44648c8
Get rid of Warnings.
...
svn path=/trunk/; revision=39954
2011-11-20 08:59:19 +00:00
bc5301e114
Fix handling of empty OpenType at the end of PDU
...
svn path=/trunk/; revision=39880
2011-11-16 08:55:02 +00:00
bdc92e9a5d
Add missing semicolon.
...
svn path=/trunk/; revision=39555
2011-10-25 06:08:16 +00:00
585ee5026d
From Neil Piercy:
...
The binary display and decimal values are corrupt in the case where they are
"stitched" together from words and octets: the complete words are extracted
ready for LSB padding, but when the final octet/word is added (also so
extracted), the data already present is shifted by a whole number of octets
(not allowing for the padding), and the value is then used by the binary and
decimal display functions as if it were MSB padded. This results in both a
corrupt bit pattern and wrong padding of the bit pattern in the display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6473
svn path=/trunk/; revision=39553
2011-10-25 05:46:31 +00:00
54b72021bb
Fix encoding arg for various fcn calls:
...
- proto_tree_add_bits_item
- proto_tree_add_bits_ret_val
- proto_tree_add_bitmask
- tvb_get_bits
- tvb_get_bits16
- tvb_get_bits24
- tvb_get_bits32
- tvb_get_bits64
svn path=/trunk/; revision=39539
2011-10-24 19:57:53 +00:00
d7a1840204
Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string();
...
Fix encoding arg as needed.
svn path=/trunk/; revision=39530
2011-10-23 22:58:45 +00:00
44f914a0f1
From Pascal Quantin:
...
I identified a new regression. When selecting a bit string, the highlighted bytes in the packet view are not the correct ones.
svn path=/trunk/; revision=39220
2011-10-02 15:12:47 +00:00
5f76488f0a
Move tvb_new_octet_aligned() to tvbuff.c and use it.
...
svn path=/trunk/; revision=39150
2011-09-26 15:11:14 +00:00
f7b214378b
From Pascal Quantin:
...
Incorrect decoding of BIT STRING type
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6347
svn path=/trunk/; revision=39017
2011-09-15 20:02:19 +00:00
733452afd7
Support for Extension Addition Group in PER encoding
...
Fix for bug 6196 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6199
svn path=/trunk/; revision=38421
2011-08-09 08:00:06 +00:00
3f7e7672c9
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38095
2011-07-18 19:11:32 +00:00
3d17e592d5
From Pascal Quantin:
...
Do not trigger an assert when reaching an unknown extension in CHOICE and SEQUENCE types.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6087
svn path=/trunk/; revision=37886
2011-07-04 06:22:15 +00:00
cab0dc1340
Don't treat the aligned and unaligned bit strings differently
...
always padd LSBs.
Hopfully this does not break anything else...
svn path=/trunk/; revision=35680
2011-01-27 15:48:02 +00:00
66053b7b3a
From Johannes Lange:
...
Function dissect_per_bit_string_display might read more bytes than available (PER dissector).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5394
svn path=/trunk/; revision=35023
2010-11-24 16:35:23 +00:00
4d4283ef98
From Johannes Lange:
...
Bug 5393 - Wrong length calculation in new_octet_aligned_subset_bits() (PER dissector) .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5393
svn path=/trunk/; revision=35021
2010-11-24 16:21:04 +00:00
2b37214674
From Pascal Quantin via bug 5301:
...
Make the PER constaints check like in the BER dissector.
svn path=/trunk/; revision=34536
2010-10-17 14:07:05 +00:00
38ba5119cd
From Pascal Quantin via bug 5301:
...
Add expert info when ASN.1 PER constrained integer does not match range.
svn path=/trunk/; revision=34531
2010-10-17 11:59:10 +00:00
a974e115ce
Fix start offset and length handling in SEQUNCE OF (caused Gtk crash for sequences at the end of frame)
...
svn path=/trunk/; revision=34058
2010-09-03 10:31:56 +00:00
026f4dfa7b
Fixed guint64 printf modifier.
...
svn path=/trunk/; revision=33799
2010-08-14 17:22:22 +00:00
856f205c27
Fix up decoding of bitfields in the aligned variant.
...
svn path=/trunk/; revision=33798
2010-08-14 16:42:41 +00:00
91e949512d
From Neil Piercy:
...
Fix misleading PER Bit string display.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4789
(I Added bits display)
svn path=/trunk/; revision=32948
2010-05-25 19:29:23 +00:00
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
9b568ea691
Fix gcc -Wshadow warnings
...
svn path=/trunk/; revision=31561
2010-01-19 00:37:39 +00:00
2e138172a2
Constrained SEQ OF in PER encoding associated with wrong length;
...
also take into account cases of length 0.
svn path=/trunk/; revision=31219
2009-12-09 21:18:04 +00:00
3bb1cd12a4
No non-ASCII characters, please.
...
svn path=/trunk/; revision=31049
2009-11-22 21:54:50 +00:00
98c852386d
Handle lenght restriction extension of restricted strings.
...
Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4251
svn path=/trunk/; revision=31047
2009-11-22 17:00:45 +00:00
9aa6257dde
Handle extended PER bitstrings.
...
svn path=/trunk/; revision=31034
2009-11-20 21:40:28 +00:00
c60a5b284e
Added offset fix from bug 4202, error introduced in r30770.
...
svn path=/trunk/; revision=30815
2009-11-04 11:41:05 +00:00
c9b5bc30d0
assert() doesn't throw an exception, it just immediately crashes the
...
app, and DISSECTOR_ASSERT() throws an exception, but claims the problem
is a dissector bug, not a malformed packet. Presumably the error in
question is the result of a malformed packet, so throw
ReportedBoundsError to indicate that (it's not really the *right*
exception, but the right exception doesn't exist).
svn path=/trunk/; revision=30776
2009-10-31 08:31:21 +00:00
Pascal Quantin