Commit Graph

74 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam 8c48c6835f Rename address_to_str() to ep_address_to_str() because:
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().

svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
Bill Meier 439486505f Fix potential crash due to NULL dereference.
(Found by clang scan-build)

svn path=/trunk/; revision=29619
2009-08-29 17:00:22 +00:00
Bill Meier 94f28dd8f9 (FWIW) One step towards including stdio.h & stdlib.h only when req'd.
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Anders Broman 6c25896d84 From Kovarththanan Rajaratnam:
No letter-shortcuts in Telephony menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678

svn path=/trunk/; revision=29028
2009-07-08 18:36:31 +00:00
Anders Broman d7eaecfbdb Unit is now ms.
svn path=/trunk/; revision=28629
2009-06-03 19:17:35 +00:00
Bill Meier 9cbe53f92b rtp_stream_dlg: rework dtp_stream "save as" slightly:
- Prevent "dead" save-as window if error opening/writing file
       or if a directory is entered as the filename;
       Work-around is to always kill save-as window whether success
        or an error causing alert-box popup;
    - Enable "check for file overwrite" (if GTK 2.8 or greater);
    - Fix some memory leaks.

svn path=/trunk/; revision=28597
2009-06-02 15:17:35 +00:00
Guy Harris 54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Gerald Combs 605ef095f9 Fix the last of the Win64 problems in the gtk directory.
svn path=/trunk/; revision=28063
2009-04-16 03:18:10 +00:00
Bill Meier 27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Anders Broman 04837ca7f2 gtk_label_set -> gtk_label_set_text
"gtk_label_set is deprecated and should not be used in newly-written code.
Aliases gtk_label_set_text()."

svn path=/trunk/; revision=27556
2009-02-26 21:11:06 +00:00
Anders Broman 2a7af394e2 Remove unused(?) code.
svn path=/trunk/; revision=27513
2009-02-22 19:32:15 +00:00
Anders Broman 968c6e06bc Use gtk_file_chooser_dialog_new().
svn path=/trunk/; revision=27512
2009-02-22 19:02:02 +00:00
Bill Meier 6fee0f704e Fix some typos and spelling
svn path=/trunk/; revision=27070
2008-12-20 01:39:16 +00:00
Bill Meier d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier 56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Ulf Lamping 644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Ulf Lamping d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping 8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Ulf Lamping 3b7fe5fc6c remove GTK1 code
svn path=/trunk/; revision=24823
2008-04-07 00:42:04 +00:00
Michael Tüxen 4306c7037d Include epan/strutil.h for gtk-1.2 builds.
svn path=/trunk/; revision=24513
2008-03-01 10:23:57 +00:00
Stig Bjørlykke 7deec480ff Next attempt to cleanup some string functions, including:
strncpy -> g_strlcpy, strncat -> g_strlcat

svn path=/trunk/; revision=24504
2008-02-29 13:33:37 +00:00
Stig Bjørlykke 10a8f59e03 Rewrote some prohibited APIs in gtk/ (sprintf, strcpy, strcat).
If we get some truncated strings we probably overwrote some buffers...

svn path=/trunk/; revision=24239
2008-02-01 01:07:58 +00:00
Stephen Fisher 2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Ronnie Sahlberg a4ae600125 move some headers so that the compile works on gtk1
svn path=/trunk/; revision=21505
2007-04-22 16:44:36 +00:00
Anders Broman ffd05a9579 Add the name of the dynamic payload type to the stream dialouge if avalable.
svn path=/trunk/; revision=21375
2007-04-10 18:58:18 +00:00
Guy Harris 92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris 84aef00bad Move the file selection dialog routines to file_dlg.c, and give it a
header file.

#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.

svn path=/trunk/; revision=18036
2006-04-30 01:47:58 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Guy Harris 13e0b409cf As per a suggestion by Ulf Lamping, rename gtk_*.[ch] to gui_*.[ch], so
that it doesn't appear to be part of GTK+.

svn path=/trunk/; revision=15501
2005-08-21 19:24:11 +00:00
Guy Harris 195c549d1a Have "register_dfilter_stat()" add "..." to the menu item, as all menu
items registered with it pop up a dialog box before displaying the stat.
Don't pass a name with "..." to it.

Put "..." into other menu items that pop up a dialog box before
displaying the stat; remove "..." from other menu items that don't.

svn path=/trunk/; revision=15495
2005-08-21 10:29:47 +00:00
Guy Harris a0e68da918 Add a "register_dfilter_stat()", to register stats that take a display
filter as an argument on the command line and have a dialog box to enter
the display filter through the GUI.  Use it for all stats using
"gtk_tap_dfilter_dlg_cb()".

Add a top-level "stat_menu.h" file to declare "REGISTER_STAT_GROUP_E"
for the benefit of the declaration of "register_dfilter_stat()" in the
top-level "tap_dfilter_dlg.h".  Rename the "stat_menu.h" in the gtk
directory to "gtk_stat_menu.h", so as not to have two headers with the
same name.

Get rid of headers not declaring any functions not being used in the
module.

svn path=/trunk/; revision=15493
2005-08-21 09:48:27 +00:00
Jörg Mayer 0edcc8920e - Declare some functions static
- Add plugins_dlg.h
- Include .h files in their respective .c files
- Include .h and remove extern declarations in .c files
- set eol-style and keywords on gui_utils.[hc]

svn path=/trunk/; revision=15471
2005-08-20 14:02:00 +00:00
Ulf Lamping eafbbbcabb renamed ui_util.c/.h to gui_utils.c/.h to prevent confusion with identical named ui_util.h in / dir
svn path=/trunk/; revision=15465
2005-08-20 12:09:48 +00:00
Guy Harris b2807e2ab6 Move the APIs for registering and processing "-z" command-line arguments
and "Statistics" menu items into "stat.h" and "stat.c", to separate them
from the core tapping APIs.  A tap could conceivably not register as a
"-z" command-line argument or "Statistics" menu item, and a stat could
conceivably not be implemented as a tap, and dissectors that implement
tapping points don't need the UI-related stuff from "stat.h", they just
want the tap-related stuff in <epan/tap.h>.

svn path=/trunk/; revision=15427
2005-08-19 09:29:41 +00:00
Ulf Lamping e571cbfa9d add 12 new toolbar/menu icons
add two toolbar toggle buttons
add icons to various menu items

create new Statistics telephony group and put telephony and alike protocols in it

svn path=/trunk/; revision=14098
2005-04-16 10:53:09 +00:00
Guy Harris 460ff2d162 From Lars Ruoff:
when formatting numerical values for CSV lists, save the locale
	before formatting, set the locale to the "C" locale, and then
	restore the locale, so that numbers are always formatted with
	"." as the decimal point;

	add to the RTP streams window a Copy button that copies all data
	from the CList to the clipboard as CSV.

svn path=/trunk/; revision=13842
2005-03-21 01:24:19 +00:00
Luis Ontanon 28e58deeb1 Frrom Francisco Alcoba
- Name resolution support for the RTP Stream Analysis functionality
- fix a crash when trying to analyze with no stream selected.


svn path=/trunk/; revision=13572
2005-03-02 01:24:18 +00:00
Luis Ontanon 6180287d82 From Martin Mathielson
- from the "RTP streams" dialog, pressing 'Analyze' with no stream selected
would throw up an 'invalid filter' error.  This patch avoids anything if no
steam(s) are selected.



svn path=/trunk/; revision=13529
2005-02-27 12:45:07 +00:00
Guy Harris ad4374e213 Mallocate the strings to be put into the columns, rather than filling in
fixed-length buffers.

svn path=/trunk/; revision=13492
2005-02-24 05:42:03 +00:00
Ulf Lamping 6939cc4465 buttons should use "Header capitalization" see GNOME HIG http://developer.gnome.org/projects/gup/hig/1.0/layout.html#layout-capitalization
svn path=/trunk/; revision=13465
2005-02-22 07:22:51 +00:00
Ronnie Sahlberg fe94290194 from lars ruoff a few extra columns for rtp analysis
svn path=/trunk/; revision=13410
2005-02-16 09:24:52 +00:00
Ulf Lamping 0861927ce3 huge cleanup of capture file API (functions in file.c/file.h).
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.

Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...

svn path=/trunk/; revision=13289
2005-02-04 18:44:44 +00:00
Guy Harris 26c2759ebc Get rid of an unused typedef.
svn path=/trunk/; revision=13239
2005-02-02 10:19:35 +00:00
Guy Harris e4ae2aa011 From Francisco Alcoba:
add IPv6 support;

	replace "delay" with "delta".

svn path=/trunk/; revision=12636
2004-12-01 11:54:41 +00:00
Ulf Lamping cd4a4308bb add some button tooltips, renamed some buttons
svn path=/trunk/; revision=12192
2004-10-03 16:29:40 +00:00
Guy Harris 8a8b883450 Set the svn:eol-style property on all text files to "native", so that
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.

svn path=/trunk/; revision=11400
2004-07-18 00:24:25 +00:00
Anders Broman c33e85ae63 From Martin Mathieson: Show number of detected streams in RTP Analysis window
svn path=/trunk/; revision=11288
2004-06-30 21:17:55 +00:00
Ulf Lamping 92ddb18b8c move "extern GtkWidget *main_display_filter_widget" from
various stats files to gtkglobals.h

svn path=/trunk/; revision=11073
2004-06-02 07:12:11 +00:00