Commit graph

173 commits

Author SHA1 Message Date
pascal
f400e647b8 From Pontus Andersson via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7259 :
GTP Extension headers are dissected incorrectly

svn path=/trunk/; revision=42663
2012-05-16 20:59:56 +00:00
Bill Meier
c055ca8c7e General minor cleanup including:
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation


svn path=/trunk/; revision=42487
2012-05-07 22:11:34 +00:00
Anders Broman
fbecf576d1 From David Wei:
Change GTP and GTPv2 dissectors for pre-Rel7 UEs that do not support bitrates higher than 16 Mbps.

svn path=/trunk/; revision=42381
2012-05-02 07:23:32 +00:00
pascal
4f415d93c5 Fix some clang warnings (dead assignment/increment, assigned value is garbage or undefined)
svn path=/trunk/; revision=42344
2012-04-30 09:00:05 +00:00
Anders Broman
2cc15fd9c6 Fully dissect more IEs
svn path=/trunk/; revision=42259
2012-04-26 13:23:16 +00:00
Anders Broman
25c3a2b236 Get rid of a few more of the explicitly defined ett:s
svn path=/trunk/; revision=42234
2012-04-25 15:33:06 +00:00
Bill Meier
d43f0fc80a Fix a crash caused by an "off by one" define
svn path=/trunk/; revision=42199
2012-04-22 20:50:34 +00:00
Anders Broman
dad5036fb2 Basic IE dissectoon for more IE:s
svn path=/trunk/; revision=42198
2012-04-22 19:28:21 +00:00
Anders Broman
974014275d Add basic IE dissection for new IE:s
svn path=/trunk/; revision=42158
2012-04-20 12:32:17 +00:00
Ronnie Sahlberg
4479fa14b4 compile warning/error. flag unused argument with _U_
svn path=/trunk/; revision=42152
2012-04-20 07:01:50 +00:00
Anders Broman
5d0ffcc606 Add the basic code to dissect IE APN Aggregate Maximum Bit Rate (APN-AMBR)
svn path=/trunk/; revision=42151
2012-04-20 05:47:02 +00:00
Anders Broman
514092549c Cosmetic changes
svn path=/trunk/; revision=42066
2012-04-14 12:17:06 +00:00
Anders Broman
6968651735 Refactor to use dissect_gsm_map_msisdn().
svn path=/trunk/; revision=42036
2012-04-12 14:34:52 +00:00
Anders Broman
869b54e3b5 Dissect IE Type = 106 fully.
svn path=/trunk/; revision=42023
2012-04-11 15:52:14 +00:00
pascal
14d362a018 As suggested by Jakub, always update the digit value when the nibble is outside [0;9] range
svn path=/trunk/; revision=41984
2012-04-08 16:03:21 +00:00
pascal
e599abd268 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7042 :
Handle properly filler and do not remove last digit

svn path=/trunk/; revision=41979
2012-04-08 13:10:45 +00:00
Anders Broman
d8a60f8a0a From Claude LeFrancois: Support 2 new GTP Information Elements. The Fully Qualified Domain Name (FQDN) GTP IE and the Evolved Allocation/Retention Priority II GTP IE.
svn path=/trunk/; revision=41861
2012-03-30 21:45:42 +00:00
Jeff Morriss
d22d574d6c From Liangfeng via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7012 :
According to 3GPP R7//R8/R9/R10/R11, AVP 'MBMS-Session-Duration' has 3 octets.
First 17 bits indicate seconds, the rest of bits(7 bits) represents days. 

However, in the source file packet-gtp.c, it parse the AVP reversely -- taking
first 7 bits as days, the rest of 17 bits as seconds.  This patch fixes that.

svn path=/trunk/; revision=41849
2012-03-30 17:40:01 +00:00
Anders Broman
5252d989d6 Update cause values and export the extended value string.
svn path=/trunk/; revision=41672
2012-03-19 12:57:21 +00:00
Bill Meier
f79a5f32b7 Fix a checkAPIs error: Blurb matches field name.
svn path=/trunk/; revision=41646
2012-03-18 22:52:28 +00:00
Bill Meier
2df5dc3d53 From Reinhard Speyerer: Fix several misspellings/typos in Wireshark
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967

svn path=/trunk/; revision=41645
2012-03-18 22:24:24 +00:00
Jeff Morriss
27b7fa96af Remove a couple trailing commas
svn path=/trunk/; revision=41538
2012-03-13 16:49:43 +00:00
Jeff Morriss
d0c997bc0b Fix up indentation/white space. Use global tfs_yes_no instead of local version.
svn path=/trunk/; revision=41537
2012-03-13 16:47:11 +00:00
Jeff Morriss
7ca19c7df7 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6947 :
Don't leave a space at the end of the MSISDN string.

svn path=/trunk/; revision=41536
2012-03-13 15:43:41 +00:00
Anders Broman
f97ad44031 Add entry for TPDU in the tree
svn path=/trunk/; revision=41194
2012-02-26 17:10:40 +00:00
Anders Broman
77c24abcdd Add comments about new IEs
svn path=/trunk/; revision=40945
2012-02-09 22:14:58 +00:00
Alexis La Goutte
b8502c9013 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=40904
2012-02-06 22:15:53 +00:00
Anders Broman
e9ab825ba5 max_ul_ext isn't printed/decoded to the packet details log in GTP protocol packet.(Wrong length check)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6761

svn path=/trunk/; revision=40702
2012-01-24 19:23:05 +00:00
Chris Maynard
dea0a5d277 Fix some duplicate display filter names.
svn path=/trunk/; revision=40591
2012-01-19 21:01:52 +00:00
Anders Broman
5aa94e620f Handle 20 byte GTP' V0 header.
svn path=/trunk/; revision=40081
2011-12-03 12:11:01 +00:00
Anders Broman
1c2c94d3ea Extend ULI dissection.
svn path=/trunk/; revision=40069
2011-12-02 21:45:45 +00:00
Anders Broman
209ecca1c1 Update value strings.
svn path=/trunk/; revision=40035
2011-11-29 17:31:52 +00:00
Anders Broman
7d64f2d940 let packet-gsm_a_gm.c dissect Protocol Configuration Options.
svn path=/trunk/; revision=40023
2011-11-28 16:40:29 +00:00
Anders Broman
28f7d63c58 Dissect RIM related IEs
svn path=/trunk/; revision=39740
2011-11-06 08:18:26 +00:00
Guy Harris
30811d83fd Get rid of non-ASCII characters in comments.
Convert "4-space tabs" to spaces.

svn path=/trunk/; revision=39735
2011-11-04 18:43:23 +00:00
Anders Broman
f960294c68 Dissect RIM Routing Address Discriminator and RAN Transparent Container.
svn path=/trunk/; revision=39734
2011-11-04 17:39:54 +00:00
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier
4c46725c2c Fix vi "modeline" so it works;
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748

svn path=/trunk/; revision=39074
2011-09-21 16:28:53 +00:00
Anders Broman
9ae5d241dc - Remove expert Warning not relevant to all GTP variants.
- use proto_add_item() in a couple of places.
- Fix a hf length.

svn path=/trunk/; revision=38732
2011-08-25 10:26:35 +00:00
Anders Broman
241958363d Error: the blurb for field "Extension header" ("gtp.ext_hdr") matches the field name in packet-gtp.c
svn path=/trunk/; revision=37885
2011-07-04 06:11:38 +00:00
Anders Broman
d86c200706 From Martin Isaksson:
PDCP PDU number extension header support.

svn path=/trunk/; revision=37880
2011-07-03 19:16:21 +00:00
Anders Broman
e502bbaafd Add a dissector table for CDR:s
svn path=/trunk/; revision=37751
2011-06-22 13:58:04 +00:00
Anders Broman
a9bbcb4a05 Remove extra space at end of IMSI.
svn path=/trunk/; revision=37519
2011-06-02 11:06:26 +00:00
Chris Maynard
3848ace06e Use [hi|lo]_nibble macros, leave room in str[] for invalid BCD digits to be
displayed as blanks.  Since imsi_to_str() and ip_to_str() do the same thing,
just have imsi_to_str() call ip_to_str() rather than having two different
implementations of the same thing.  Use a BCD2CHAR macro instead of doing a
table lookup.

svn path=/trunk/; revision=36740
2011-04-20 20:12:40 +00:00
Chris Maynard
80889668bc From Vladimir Kazansky via bug 5849: Fix msisdn_to_str() so it converts all BCD
digits and not just 1.

svn path=/trunk/; revision=36727
2011-04-20 02:24:16 +00:00
Alexis La Goutte
eff30da7a4 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36703
2011-04-18 17:48:23 +00:00
Bill Meier
fc600d4bf9 Fix a few cases of proto_item_add_subtree() using the wrong tree: Coverity 916-918;
Also: Fix some indentation: e.g., "4 space tabs".

svn path=/trunk/; revision=36585
2011-04-12 15:39:19 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00