Commit graph

14 commits

Author SHA1 Message Date
Guy Harris
42107e8614 Move calls to "dissector_add()" out of the register routines for TCP and
UDP and into the handoff registration routines for the protocols in
question.

Make the dissectors for those protocols static if they're not called
outside the dissector's source file.

Get rid of header files if all they did was declare dissectors that are
now static; remove declarations of now-static dissectors from header
files that do more than just declare the dissector.

svn path=/trunk/; revision=1823
2000-04-08 07:07:42 +00:00
Gilbert Ramirez
474d3b54a9 Convert two instances of proto_tree_add_uint_format() to
proto_tree_add_protocol_format(). I had converted them incorrectly
when I changed them from their original proto_tree_add_item_format().

svn path=/trunk/; revision=1717
2000-03-14 07:12:23 +00:00
Gilbert Ramirez
f6e92a9e93 Break proto_tree_add_item_format() into multiple functions:
proto_tree_add_protocol_format()
	proto_tree_add_uint_format()
	proto_tree_add_ipxnet_format()
	proto_tree_add_ipv4_format()
	proto_tree_add_ipv6_format()
	proto_tree_add_bytes_format()
	proto_tree_add_string_format()
	proto_tree_add_ether_format()
	proto_tree_add_time_format()
	proto_tree_add_double_format()
	proto_tree_add_boolean_format()
If using GCC 2.x, we can check the print-format against the variable args
passed in. Regardless of compiler, we can now check at run-time that the
field type passed into the function corresponds to what that function
expects (FT_UINT, FT_BOOLEAN, etc.)

Note that proto_tree_add_protocol_format() does not require a value field,
since the value of a protocol is always NULL. It's more intuitive w/o the
vestigial argument.

Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c
Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*)

Checked in Guy's fix for the function declearation for proto_tree_add_text()
and proto_tree_add_notext().

svn path=/trunk/; revision=1713
2000-03-12 04:48:32 +00:00
Guy Harris
3b9f205621 Fix some "proto_tree_add_text()" calls.
Reorganize "icqv5_cmd_send_text_code()" a bit so that it only puts an
item into the tree if it's present in the packet.

svn path=/trunk/; revision=1697
2000-03-07 05:30:37 +00:00
Guy Harris
f2246ebb65 Fix a bunch of dissectors to use "pi.captured_len" rather than
"fd->cap_len" for the frame length - or to use macros such as
"BYTES_ARE_IN_FRAME()", "IS_DATA_IN_FRAME()", and "END_OF_FRAME", which
use "pi.captured_len" - so that they correctly handle frames where the
actual data length of the packet is less than the size of the raw frame,
e.g. with encapsulations such as ISL.

svn path=/trunk/; revision=1530
2000-01-24 03:33:35 +00:00
Guy Harris
e17904a02a Updates from Kojak.
svn path=/trunk/; revision=1221
1999-12-05 22:59:55 +00:00
Guy Harris
27f7e065e4 Fix the "proto_tree_add_item_format()" call for CMD_STATUS_CHANGE.
svn path=/trunk/; revision=1176
1999-12-01 23:58:44 +00:00
Guy Harris
1ecbfc0619 Clean up some ANSI C nits pointed out by "gcc -pedantic".
svn path=/trunk/; revision=1060
1999-11-18 21:04:54 +00:00
Guy Harris
a7aba0a288 Replace the ETT_ "enum" members, declared in "packet.h", with
dynamically-assigned "ett_" integer values, assigned by
"proto_register_subtree_array()"; this:

	obviates the need to update "packet.h" whenever you add a new
	subtree type - you only have to add a call to
	"proto_register_subtree_array()" to a "register" routine and an
	array of pointers to "ett_", if they're not already there, and
	add a pointer to the new "ett_" variable to the array, if they
	are there;

	would allow run-time-loaded dissectors to allocate subtree types
	when they're loaded.

svn path=/trunk/; revision=1043
1999-11-16 11:44:20 +00:00
Guy Harris
bba1ad82d1 Updates to the ICQ decoder, from Kojak.
svn path=/trunk/; revision=981
1999-11-06 03:08:34 +00:00
Guy Harris
f817d71424 Include <time.h>, so as to declare "ctime()" on systems where
<sys/time.h> doesn't include <time.h>.

svn path=/trunk/; revision=968
1999-11-03 06:21:35 +00:00
Guy Harris
d3ab2c76af Ensure that "password" is '\0'-terminated.
svn path=/trunk/; revision=925
1999-10-25 20:32:52 +00:00
Guy Harris
a54314e961 Update from Kojak to dissect ICQ login packets and text messages.
svn path=/trunk/; revision=924
1999-10-25 20:28:21 +00:00
Guy Harris
da1fdf005f Kojak's ICQ dissector.
svn path=/trunk/; revision=919
1999-10-24 00:56:11 +00:00