Michael Mann
6c0e747f61
use session allocated memory for rtp_add_address/srtp_add_address hash tables
...
svn path=/trunk/; revision=44571
2012-08-19 00:21:26 +00:00
Jeff Morriss
b63d63529c
Fix fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7560 :
...
Don't assume that we stored off the SPRT conversation port. This was code
comes from r43887/bug 3507 so no need to backport.
svn path=/trunk/; revision=44243
2012-08-03 13:55:07 +00:00
Michael Mann
0d4eafb04d
Update display filter names per Bug 2794. Part 1 of many.
...
svn path=/trunk/; revision=43907
2012-07-22 03:06:37 +00:00
Bill Meier
45f9935f04
Additional cleanup:
...
packet-sdp.c:
Init 'proto_sprt' in proto_reg_handof..()
[instead of using a registered init fcn];
packet-sprt.c:
Fix some typos;
Comment out dissect_sprt_heur() since it doesn't
really do any dissection. Add an XXX comment re same.
packet-v150fw.c:
Remove unused 'v150fw_handle' and thus unneeded proto_reg_handoff...();
Add an XXX comment re the (commented out) dissect_v150fw() not actually
doing any dissection.
svn path=/trunk/; revision=43902
2012-07-21 22:06:17 +00:00
Evan Huus
f9ec58ae1d
Because storing the address of a stack variable seemed like such
...
a good idea at the time...
Allocate seasonal memory for it instead.
svn path=/trunk/; revision=43896
2012-07-21 15:31:35 +00:00
Evan Huus
897d72c358
Fix some of the GCC build errors, more to come.
...
svn path=/trunk/; revision=43889
2012-07-21 13:25:14 +00:00
Michael Mann
3d502b97f1
Updated patch from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3507
...
svn path=/trunk/; revision=43887
2012-07-21 12:38:59 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier
f9a08c84d5
General cleanup:
...
- whitespace;
- formatting (including long lines & hf[] entries).
svn path=/trunk/; revision=42614
2012-05-13 14:53:26 +00:00
Bill Meier
07d88fc044
From Evan Huus:
...
In dissect_sdp_media_attribute() we can leak 'key' in an error condition.
Simply move the allocation to after the error check.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7231
svn path=/trunk/; revision=42456
2012-05-07 01:18:17 +00:00
Jakub Zawadzki
68ec58d385
Fix some: 'cast discards qualifiers from pointer target type' warnings
...
- Add const qualifier
- Remove some strange casts
svn path=/trunk/; revision=42131
2012-04-18 12:35:36 +00:00
Alexis La Goutte
846fe21e31
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=40903
2012-02-06 22:15:24 +00:00
Anders Broman
c1813b0701
Collect and use some SRTP information.
...
svn path=/trunk/; revision=40794
2012-02-01 20:33:33 +00:00
Jeff Morriss
f091005d3e
Fix infinite loop reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6778 :
...
SDP_CRYPTO: Give up (and display an expert info) if we don't find the colon
separating the key-method and the key-info.
Reindent this area of code a bit.
Remove tabs in some places for consistency.
svn path=/trunk/; revision=40771
2012-01-30 17:39:15 +00:00
Anders Broman
63e6945482
Dissect the crypto attribute.
...
svn path=/trunk/; revision=40732
2012-01-26 17:52:13 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Martin Mathieson
c3d27315ed
Avoid longjmp warning by making adding volatile.
...
svn path=/trunk/; revision=39364
2011-10-11 18:06:01 +00:00
Anders Broman
eeff694c87
- Put a TRY/CATCH block around dissect_h264_nal_unit() in case
...
a bogus nal unit was sent.
- Delete an unused hf entry.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6407
svn path=/trunk/; revision=39305
2011-10-07 16:42:52 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier
d2269ce7d5
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Bill Meier
a2b58f051d
Add #include <stdlib.h> to files which reference fcns declared in stdlib.h;
...
(In many cases I previously incorrectly removed the #include <stdlib.h>).
svn path=/trunk/; revision=37334
2011-05-20 19:00:09 +00:00
Stephen Fisher
ef5823c210
Put back in one of the includes removed in r36606: ctype.h for isdigit()
...
function.
svn path=/trunk/; revision=36607
2011-04-12 20:29:42 +00:00
Bill Meier
c85689f108
Don't assign to a proto_item * if the value won't be used: Coverity 1034;
...
Comment out two calls to tvb_)get_ephemeral_string since the result is never used: Coverity 1035;
Also:
Remove some unneeded #includes;
Use consistent indentation.
svn path=/trunk/; revision=36606
2011-04-12 20:19:10 +00:00
Martin Mathieson
473b578880
Remove static that was added to appease Coverity 753. 2016 bytes isn't too much to put on the stack.
...
svn path=/trunk/; revision=36285
2011-03-23 10:12:35 +00:00
Martin Mathieson
034820599a
Make a struct static to avoid growing the stack too much.
...
Coverity CID 753.
svn path=/trunk/; revision=36255
2011-03-22 17:46:59 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier
03b57df5a0
Fix various typos and spelling errors.
...
svn path=/trunk/; revision=35126
2010-12-06 01:34:58 +00:00
Anders Broman
cab0cef11d
Use value_string_ext for RTP payload types.
...
svn path=/trunk/; revision=34804
2010-11-08 14:43:59 +00:00
Jaap Keuter
12b574e628
Fix for bug 5220:
...
- Don't list codecs which are deleted by using port 0.
- Use real concatenation i.s.o. reprint, which seems to fail in some circumstances.
svn path=/trunk/; revision=34154
2010-09-18 13:12:03 +00:00
Anders Broman
b1568cb247
Update the comment.
...
svn path=/trunk/; revision=33777
2010-08-11 21:52:35 +00:00
Anders Broman
ccf8787370
Add a warning message if H264 profile-level-id parameter wasn't
...
posible to parse.
svn path=/trunk/; revision=33776
2010-08-11 21:39:22 +00:00
Stig Bjørlykke
894f256912
Added check for valid tvb before calling tvb_length().
...
svn path=/trunk/; revision=33774
2010-08-11 21:27:35 +00:00
Anders Broman
4b9747a74d
Add a komment about the format of the MSRP path parameter.
...
svn path=/trunk/; revision=33764
2010-08-11 11:33:40 +00:00
Anders Broman
326ec92f7c
Fix: Malformed packet if port is missing from path.
...
svn path=/trunk/; revision=33209
2010-06-11 11:49:01 +00:00
Jeff Morriss
47e2d75820
Move some code (including the optional objects) into libwsutil
...
svn path=/trunk/; revision=33012
2010-05-28 20:19:55 +00:00
Bill Meier
10ffd14b8f
Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
...
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Jeff Morriss
67b7737481
Fix the build
...
svn path=/trunk/; revision=32467
2010-04-14 21:38:08 +00:00
Anders Broman
83ce037aa9
Use the sample rate from SDP info in RTP stream analysis.
...
svn path=/trunk/; revision=32466
2010-04-14 20:48:37 +00:00
Anders Broman
0424d1716c
Extract encoding name and sample rate
...
i.e "AMR/8000"
This string can then be put in the hastable, extracted by
packet-rtp.c and split into "AMR" and "8000"
sample rate can then be a part of rtp_info and get rid of the
clock rate maping.
(I have some problem splitting the string, help apreciated) :-)
svn path=/trunk/; revision=32455
2010-04-13 19:27:14 +00:00
Anders Broman
25af78517e
Make tvb_pbrk_guint8() return the found needle.
...
svn path=/trunk/; revision=32144
2010-03-08 20:45:13 +00:00
Bill Meier
1a4283ccf8
Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup in a few cases.
...
svn path=/trunk/; revision=31617
2010-01-22 13:56:19 +00:00
Anders Broman
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Stig Bjørlykke
d577ca0fa7
Guard #include <sys/types.h> with HAVE_SYS_TYPES_H.
...
svn path=/trunk/; revision=31053
2009-11-23 18:47:52 +00:00
Gerald Combs
cf8126a808
Instead of initializing the Media Format name to NULL, set it to
...
"Unknown". This keeps us from crashing on some platforms if we have an
unknown media format ID.
svn path=/trunk/; revision=31011
2009-11-19 01:50:44 +00:00
Anders Broman
bc9a809b65
From Didier Gautheron:
...
ep memory can't be used for tvbs defined as data_source.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4054
svn path=/trunk/; revision=30376
2009-10-06 19:15:58 +00:00
Kovarththanan Rajaratnam
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
Bill Meier
94f28dd8f9
(FWIW) One step towards including stdio.h & stdlib.h only when req'd.
...
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Kovarththanan Rajaratnam
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00