Bill Meier
c591c6dd56
Comment out all but first value_string array entries with dup values:
...
kept: first dup since that's the one which would
be found with a linear search.
svn path=/trunk/; revision=44642
2012-08-23 17:30:42 +00:00
Bill Meier
ca154aad10
(Trivial) whitespace cleanup
...
svn path=/trunk/; revision=43959
2012-07-24 14:05:20 +00:00
Bill Meier
e6818f164e
Fix incorrect(duplicate) value in artnet_oem_code_vals[] value string array;
...
{ 0x0ae0, "chainzone:RoundTable:0 DMX Inputs,
...
- { 0x0ae0, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
+ { 0x0b00, "STC Mecatronica:DDR 2404 Digital Dimmer Rack:...
Correct value obtained from Bug #7407 attachment #8684 :
"Art-Net OEM manufacturer codes for 1.4be specification"
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8684
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407
(Issue noticed because value_string_ext search was 'linear' for this array).
svn path=/trunk/; revision=43689
2012-07-13 04:52:40 +00:00
Pascal Quantin
41e5166f81
Add a few missing ENC_ASCII and remove a few unused hf entries
...
svn path=/trunk/; revision=43581
2012-07-06 05:33:55 +00:00
Pascal Quantin
0bcc9b0e66
From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 :
...
Update ESTA manufacturer IDs and OEM code values
svn path=/trunk/; revision=43580
2012-07-06 05:17:09 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Anders Broman
b74438e41d
Set but not used variable
...
svn path=/trunk/; revision=42885
2012-05-28 17:55:47 +00:00
Anders Broman
4312a9dd61
Remove C++ style comments initilize some variables.
...
svn path=/trunk/; revision=42884
2012-05-28 16:00:20 +00:00
Anders Broman
14eb5154ac
From Erwin Rol:
...
Artnet, RDM and DMX dissector updates
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7286
svn path=/trunk/; revision=42880
2012-05-28 15:24:54 +00:00
Bill Meier
d53320919a
Remove unneeded #includes (stdlib, stdio, ctypes, time);
...
In a few cases: do some whitespace, indentation cleanup & reformatting.
svn path=/trunk/; revision=42632
2012-05-15 19:23:35 +00:00
Bill Meier
72bf183742
Do indentation cleanup (e.g., 4-space tabs => spaces)
...
Reformat a few long lines.
svn path=/trunk/; revision=42213
2012-04-23 17:50:02 +00:00
Chris Maynard
523cbecd1a
Avoid some potential divide by zero errors that Clang reports.
...
svn path=/trunk/; revision=41923
2012-04-04 12:47:08 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
d65261d344
Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.
...
(Some minor whitespace cleanup).
svn path=/trunk/; revision=39488
2011-10-20 14:07:54 +00:00
Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Anders Broman
4b952c1324
Get rid of check_col, while at it set ENC.
...
svn path=/trunk/; revision=39146
2011-09-26 08:25:18 +00:00
Stig Bjørlykke
1c45c1a243
From Michael Mann via bug 2794:
...
Fixed display filters with obvious typos.
svn path=/trunk/; revision=36713
2011-04-19 08:22:58 +00:00
Jeff Morriss
61876001c3
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the
...
return string is NULL terminated.
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().
svn path=/trunk/; revision=35548
2011-01-16 03:57:12 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss
0ff5638f37
Replace blurbs that match the name (case insensitive) with NULL.
...
svn path=/trunk/; revision=34227
2010-09-23 21:46:31 +00:00
Bill Meier
10ffd14b8f
Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
...
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Anders Broman
4d2e653901
From Didier Gautheron:
...
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107
svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Kovarththanan Rajaratnam
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68
Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke
0437f102c3
From Kovarththanan Rajaratnam:
...
More FT_XXX cleanup.
svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Jaap Keuter
a6f65c6bf7
From Reinhard Speyerer:
...
This patch fixes several misspellings/typos in Wireshark SVN revision 28201.
svn path=/trunk/; revision=28208
2009-05-01 07:05:47 +00:00
Guy Harris
3c2b8a7c84
None of those strings will have a length that doesn't fit in a gulong.
...
svn path=/trunk/; revision=27787
2009-03-18 20:56:21 +00:00
Bill Meier
a213345be2
Add a comment about the way g_snprintf() is used.
...
svn path=/trunk/; revision=27756
2009-03-17 18:13:44 +00:00
Jaap Keuter
9da243b13c
Incorporate plugin dissector into build in collection.
...
svn path=/trunk/; revision=27505
2009-02-22 11:43:37 +00:00