- bump up SDP_MAX_PAYLOAD_TYPES to 20 (I have an mgcp capture where a media
gateway responded with 12 media types, resulting in a crash). Probably more
care needs to be taken while parsing the list of media types though...
svn path=/trunk/; revision=13973
"PROTOABBREV A name for the protocol for use in filter expressions;
it should contain only lower-case letters, digits, and
hyphens."
In proto_register_protocol(), generate a warning if PROTOABBREV contains
invalid characters. Along with the list above, allow underscores and
periods. Fix up whitespace.
Lower-case PROTOABBREV in several dissectors.
svn path=/trunk/; revision=13967
dissectors aren't needed outside the dissectors, and having more than
one of them exported causes build problems, at least on OS X - make them
static.
Fix indentation.
svn path=/trunk/; revision=13951
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
svn path=/trunk/; revision=13942
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
svn path=/trunk/; revision=13941
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
svn path=/trunk/; revision=13940
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
svn path=/trunk/; revision=13939
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
svn path=/trunk/; revision=13938
Clean up indentation.
Have the main loop for dissecting chunks check that the chunk size is
large enough for the chunk header, and have it pass the chunk size,
minus the size of the chunk header, to dissectors for particular chunk
types. Make those dissectors check that value to make sure it's large
enough for any fixed-length portion before subtracting the length of
that portion and using the result as a remaining data length.
svn path=/trunk/; revision=13924
FT_NONE be, in effect, unsigned, it's no longer necessary to check for a
so-large-it-doesn't-fit-in-a-signed-value length for items of those types.
svn path=/trunk/; revision=13918
Use "tvb_ensure_bytes_exist()" to check for some invalid lengths.
Add some comments about possible problems in the code.
Get rid of an unnecessary length check (the length is the sum of a small
constant and a value extracted from a single byte, so the sum won't
overflow).
For a FCP_RSP, make the top-level protocol tree item run to the end of
the tvbuff and then set its length when we finish dissecting it (if we
throw an exception and don't get around to setting the length, that
means that we hit the end of the tvbuff before we hit the end of the
item). Add some checks to catch too-large length fields.
svn path=/trunk/; revision=13917
the length of a suboption must be at least 2;
the length of the Unique Digit option must be 3, and its name is
"Unique Digit", not "Uniq Digit";
the length of the other suboptions must be at least 3.
svn path=/trunk/; revision=13901
items don't run past the length left in the option, and, if they do, put
an indication into the protocol tree that they did.
The length returned by "tvb_strsize()" includes the terminating null
character.
svn path=/trunk/; revision=13900
Here is a patch that:
* packet-ber.c:
- Fixes handling tags longer than one octet (in
"packet-ber.c:get_ber_identifier") which consists of replacing "if (t &
0x80) break;" by "if (!(t & 0x80)) break;"
- Add debug info on the identifier when debug is enabled (I don't know if we want to keep this, but I find it useful)
- printf's a warning when packet-ber hits a constructed type (to remind that we eventually have to handle this)
- Add the display of unknown BER octet strings (this one was already submitted along with the initial Camel dissector but didn't got
included)
svn path=/trunk/; revision=13895
freeing our data structures, we can go through all those structures and
free up the hash tables associated with them, rather than just leaking
them.
svn path=/trunk/; revision=13891
whether the suboption data offset plus the suboption data length is >,
not >=, the end of the option data - the end of the option data is the
first byte *after* the option data.
For CableLabs string suboptions, use the right offset when fetching the
data.
svn path=/trunk/; revision=13884
enough, and fix them - and handle the already-fixed case similarly (note
that the length is bogus, and break out of the loop).
Put object header items into the protocol tree in the order in which
they appear in the packet.
For unknown subobjects, make the "Data (N bytes)" item cover only the
data, not the header (which is already covered).
Fix the offset in some calls.
svn path=/trunk/; revision=13879
But what's the right way to do instead? Just inserted a return, this should do no harm.
Could someone with more knowledge of this dissector review this change?
svn path=/trunk/; revision=13878
so don't check whether they've done so with "DISSECTOR_ASSERT()".
("proto_item_set_string()" and friends already do so.)
Fix indentation.
svn path=/trunk/; revision=13876
TO THE DISSECTOR DEVELOPERS, PLEASE FIX THIS: I could easily found several places where a g_assert is called, depending on the input packet data. NEVER DO THIS, as this crashes Ethereal simply by invalid packet data input!!!
svn path=/trunk/; revision=13868
update for q933
(and changes to move variable declarations to the start of a block since normal c compilers can not handle declarations in the middle of a block)
svn path=/trunk/; revision=13854
tables that are searched rather than dense tables that are indexed, so
there's no reason to tread payload types 130 and 131 specially.
svn path=/trunk/; revision=13844
Check whether krb5.h defines KEYTYPE_ARCFOUR_56 - not all versions do
(in particular, the Heimdal that comes with FreeBSD 4.6 doesn't).
packet-kerberos.h includes krb5.h if we hae Heimdal; we don't need to do
so in packet-spnego.c.
svn path=/trunk/; revision=13828
"dissect_per_restricted_character_string()", which is a guint32, not a
pointer. Re-generate packet-h225.c with the fixed asn2eth.
svn path=/trunk/; revision=13819