Commit Graph

17149 Commits

Author SHA1 Message Date
Jeff Morriss 4361e2a4ed Get rid of most of the if(tree) checks: the proto_tree_add_*() functions
don't need them any more and, as shown in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290#c16
we really want to check if we're looking at something beyond the end of the TVB
(in order to break out of very long loops).

svn path=/trunk/; revision=49645
2013-05-31 01:46:40 +00:00
Pascal Quantin 55da3a2254 From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8644 :
SEL RTAC (Real Time Automation Controller) EIA-232 Serial-Line Dissection

svn path=/trunk/; revision=49635
2013-05-30 20:51:18 +00:00
Jeff Morriss d4f44f4979 Get rid of C++/C99-style comments.
svn path=/trunk/; revision=49632
2013-05-30 12:54:24 +00:00
Sake Blok dea156c3d5 Rename "http.response_ts" to "http.time" to be inline with other response time fiels (like dns.time and smb.time etc)
svn path=/trunk/; revision=49630
2013-05-30 07:16:04 +00:00
Anders Broman af28c2b9eb From Chris Pane:
Updates to IEEE 1722.1 dissector for Draft 23R2.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8732

svn path=/trunk/; revision=49628
2013-05-30 05:24:37 +00:00
Jeff Morriss 34230e736d Fix the infinite recursion problem reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8733 :

We can't solely rely on the port in the URI to determine whether we will be
recursively called by decode_tcp_ports().  Instead also check the conversation
entry too: if we find that we are the subdissector for this conversation
(which we might be--without the port being in our list of ports--if we
heuristically picked up the conversation or the user did Decode-As),
just bail out and dissect the payload as data.

svn path=/trunk/; revision=49623
2013-05-29 22:43:20 +00:00
Jeff Morriss a9ce065e49 As described in the thread starting with:
https://www.wireshark.org/lists/wireshark-dev/201305/msg00207.html

The PC and SSN are mandatory for the SCCP "user table" to work.  Complain if
they are not given.

svn path=/trunk/; revision=49605
2013-05-28 22:33:33 +00:00
Martin Mathieson 3a80080fe9 Add some info to make it easier to see when SI config changes:
- show systemInfoModification in info column (and expert info), also
  show number of UEs paged
- add expert item when systemInfoValueTag changes
- for MIB, add SFN to info column

svn path=/trunk/; revision=49603
2013-05-28 22:11:56 +00:00
Michael Mann 553bec65ba Batch of filterable expert infos. This (mostly) completes the non-ASN.1 list of (built-in) dissectors that only had a small handful of add_expert_info_format calls.
svn path=/trunk/; revision=49602
2013-05-28 03:11:44 +00:00
Evan Huus 292e50ed1d Remove unused variable caught by recent GCC
svn path=/trunk/; revision=49601
2013-05-28 00:48:09 +00:00
Michael Mann b0090fd046 Batch of filterable expert infos
svn path=/trunk/; revision=49600
2013-05-27 23:21:11 +00:00
Pascal Quantin 0ee4d0a00a Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402

svn path=/trunk/; revision=49599
2013-05-27 20:26:49 +00:00
Pascal Quantin 38d9a87a49 From Chris Hellberg via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8723 :
M3UA dissector RFC display update

svn path=/trunk/; revision=49598
2013-05-27 18:58:24 +00:00
Michael Mann d0c8f60840 Fix compiler warning
svn path=/trunk/; revision=49597
2013-05-27 17:35:21 +00:00
Michael Mann ea177a2575 Batch of filterable expert infos
svn path=/trunk/; revision=49596
2013-05-27 17:30:43 +00:00
Anders Broman c6af00a977 From jamie Neufeld:
Add an option to selct if payload is to be dissected as SYNC.

svn path=/trunk/; revision=49595
2013-05-27 16:27:50 +00:00
Alexis La Goutte 8cd231162b From Jouni Malinen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8711 Wi-Fi Display dissector
This matches the style used for Wi-Fi Display and gets rid of a minimal
header file for functionality that extends packet-ieee80211.c.

svn path=/trunk/; revision=49594
2013-05-27 16:20:57 +00:00
Alexis La Goutte 816ed3ce0d From Jouni Malinen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8711 Wi-Fi Display dissector
The attached patch adds initial support for dissecting Wi-Fi Display information element

svn path=/trunk/; revision=49593
2013-05-27 16:20:29 +00:00
Ronnie Sahlberg 0e06d5ce58 SCSI Add decoding of Block Device Characteristics VPD page
svn path=/trunk/; revision=49592
2013-05-27 03:44:06 +00:00
Ronnie Sahlberg c8a7157414 SCSI: Print the INQUIRY EVPD page name in the info column
svn path=/trunk/; revision=49591
2013-05-27 03:13:31 +00:00
Ronnie Sahlberg 78d98f852e SCSI: add dissection of Tiemout Descriptor for REPORT SUPPORTED OPCODES
svn path=/trunk/; revision=49590
2013-05-27 01:09:49 +00:00
Ronnie Sahlberg edd38556aa SCSI: Add dissection of the data-out buffer for SANITIZE service action OVERWRITE
svn path=/trunk/; revision=49589
2013-05-26 18:38:56 +00:00
Gerald Combs 08b5086b0f [Automatic manuf, services and enterprise-numbers update for 2013-05-26]
svn path=/trunk/; revision=49585
2013-05-26 14:03:39 +00:00
Michael Mann 5bc22a25df Batch of filterable expert infos.
svn path=/trunk/; revision=49584
2013-05-26 03:29:07 +00:00
Ronnie Sahlberg 2ab2ad7a42 SCSI: Add basic decoding of SANITIZE opcode
svn path=/trunk/; revision=49582
2013-05-25 22:47:10 +00:00
Michael Mann 7e8e5b347e Batch of filterable expert_infos.
svn path=/trunk/; revision=49581
2013-05-25 17:06:40 +00:00
Evan Huus f16996424a From Fabio Tarabelloni: more minor formatting and comment fixes.
svn path=/trunk/; revision=49576
2013-05-25 13:01:25 +00:00
Evan Huus ea416f0377 From Fabio Tarabelloni: fix copy-pasted comment.
svn path=/trunk/; revision=49575
2013-05-25 12:25:51 +00:00
Michael Mann b2027be0f8 Add filterable expert info.
svn path=/trunk/; revision=49573
2013-05-25 03:27:31 +00:00
Evan Huus cf7ec9f1e9 From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387
ZigBee ZCL OnOff cluster dissection.

Also, fix decryption of APS commands.

svn path=/trunk/; revision=49571
2013-05-25 01:45:16 +00:00
Anders Broman 9d5b23bc76 use key in all p_add_proto_data() p_get_proto_data()
svn path=/trunk/; revision=49568
2013-05-24 22:38:25 +00:00
Pascal Quantin ec1ebf5dd8 From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708 :
Add MAC-DATA support to TETRA dissector and other minor improvements

svn path=/trunk/; revision=49567
2013-05-24 20:55:42 +00:00
Michael Mann a686f1713a Bluetooth: Highlight correct bytes in some SDP trees (Part 2). Bug 8700 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700)
svn path=/trunk/; revision=49566
2013-05-24 19:40:09 +00:00
Michael Mann 5e86cb9bf4 Use new expert info API in idl dissectors. These generated about 50% of the add_expert_info_format() calls.
svn path=/trunk/; revision=49561
2013-05-24 18:09:57 +00:00
Michael Mann 45658e1cbd first batch of dissectors to use the new expert info API.
svn path=/trunk/; revision=49560
2013-05-24 18:02:54 +00:00
Pascal Quantin ecd3073813 How to mess with a keyboard...
svn path=/trunk/; revision=49558
2013-05-24 17:43:36 +00:00
Pascal Quantin 01da09fcb5 One more compilation fix for gcc 4.3.2 ('toi' may be used uninitialized in this function)
svn path=/trunk/; revision=49557
2013-05-24 17:36:19 +00:00
Evan Huus f953ba8346 Remove unused function parameter, rename variable to avoid shadowing.
svn path=/trunk/; revision=49556
2013-05-24 17:24:58 +00:00
Michael Mann d12fc51afd Overhauled the RMT dissectors. Not sure each needs its own file, but since this involves multiple RFCs, they remain split out by that. More are now a "pure" dissector and not a "decoding function hook".
Some Notes:
1. Converted to "new style" dissectors with data being passed between dissectors
2. Combined header files into one since there wasn't much that should have really been in the header files.  Implemented functionality is in c module of respective dissector.

Not sure if LCT preferences should just be in the LCT dissector and not the RMT-ALC "parent", but kept for backwards compatibility.

svn path=/trunk/; revision=49555
2013-05-24 17:06:23 +00:00
Pascal Quantin 608fe54c05 Fix computation of TP-User-Data-Length when SMS is coded with GSM 7 bit default alphabet and TP-User-Data-Header field is present
svn path=/trunk/; revision=49546
2013-05-23 20:28:59 +00:00
Michael Mann 7f832c18c3 Support Raptor/Raptor-Q FEC in RMT dissector. Bug 8699 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8699)
From Igor Slepchin.

svn path=/trunk/; revision=49523
2013-05-22 20:30:30 +00:00
Pascal Quantin 491b512399 Do not stop dissection when there is no tree: otherwise it prevents successful reassembly of SMS fragments
svn path=/trunk/; revision=49516
2013-05-22 18:19:05 +00:00
Michael Mann 1bdf3446c5 From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8700 :
Highlight correct bytes in some SDP trees.

svn path=/trunk/; revision=49481
2013-05-21 13:27:48 +00:00
Michael Mann 77b1d9b323 add a few filterable fields/expert info
svn path=/trunk/; revision=49479
2013-05-21 12:55:55 +00:00
Michael Mann 2369729832 use ep_ allocated memory instead of g_ allocated.
svn path=/trunk/; revision=49478
2013-05-21 12:54:08 +00:00
Anders Broman 51723864c1 - Move the export_pdu tap outside of if(tree)
- Have the diameter tap request a tree.

svn path=/trunk/; revision=49475
2013-05-21 05:47:20 +00:00
Anders Broman b8618947bd Add missing element NSAP to IE Evolved Allocation/Retention Priority II.
svn path=/trunk/; revision=49474
2013-05-21 05:08:50 +00:00
Michael Mann 478ee0ae73 DHCPv6 option 56, RFC 5908
Bug 8421 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8421)

svn path=/trunk/; revision=49473
2013-05-21 03:24:55 +00:00
Michael Mann 24df2990e5 Use col_set_fence() functionality to remove an unnecessary global variable.
svn path=/trunk/; revision=49472
2013-05-21 02:08:40 +00:00
Michael Mann f04a801716 Minor cleanup. Removal of unnecessary packet_info* global variable
svn path=/trunk/; revision=49471
2013-05-21 02:04:41 +00:00