Commit Graph

59 Commits

Author SHA1 Message Date
Anders Broman 47aca4c30f From stéphane bryant:
STUN, STUN2 and TURN dissection enhancements.

svn path=/trunk/; revision=25895
2008-08-01 15:11:06 +00:00
Jeff Morriss 28426d27ff prefs_register_uint_preference() takes as its argument a pointer to a uint, not a pointer to a gboolean. Similarly prefs_register_enum_preference takes a pointer to a gint, not a guint.
svn path=/trunk/; revision=25710
2008-07-11 19:56:43 +00:00
Jeff Morriss 83ae90ae83 In a call to proto_tree_add_bytes_format(): actually pass a pointer to the start of the bytes
svn path=/trunk/; revision=25709
2008-07-11 19:48:30 +00:00
Jaap Keuter ea13bae738 From Alon Tal:
RTP header extensions that are longer than 4 bytes (rtp.ext.len > 1)
get dissected incorrectly. The first 4 bytes of the header extension are
repeated rtp.ext.len times, and the remaining bytes are ignored.

svn path=/trunk/; revision=25184
2008-04-27 11:10:57 +00:00
Jaap Keuter 36471e1f8c From Peter Fuller:
If a UDP packet is submitted to the RTP heuristic dissector with either odd src
or dst ports, the heuristic will correctly return FALSE.  However, that
interferes with the next few lines of code that can potentially treat version 0
RTP packets as either STUN or T38 depending on preference settings.

svn path=/trunk/; revision=25150
2008-04-23 06:51:15 +00:00
Martin Mathieson 524f4c1611 Adjust the RTP heuristic dissector:
- loosen by accpepting dynamic payload type range
- tighten by only accepting even-numbered ports

svn path=/trunk/; revision=24583
2008-03-07 18:15:46 +00:00
Stig Bjørlykke b091b8d26c Rewrote to use g_strlcpy and g_strlcat.
svn path=/trunk/; revision=24525
2008-03-01 17:23:39 +00:00
Jaap Keuter 81aaf4a8b1 Avoid misreporting of cryto state of RTP payload.
svn path=/trunk/; revision=24461
2008-02-25 19:08:13 +00:00
Martin Mathieson d786333ab2 #ifdef DEBUG around left-over printfs. Should these just be deleted?
svn path=/trunk/; revision=24045
2008-01-09 16:21:03 +00:00
Tomas Kukosa 27a531e06a more sophisticated H245 OLC handling focusing on more reliable T.38 establishment
svn path=/trunk/; revision=24043
2008-01-09 13:30:31 +00:00
Jaap Keuter d3b3178186 Fix for bug 2026:
Clean up RTP header extension code. Remove duplicate raw presentation.

svn path=/trunk/; revision=24016
2008-01-06 11:49:32 +00:00
Jaap Keuter 93ef681227 From Andreas St:
In our communication systems, we make use of the RTP header extension to encode
signalling information in the form of a bit mask. To improve our debugging, we
extended the default RTP dissector to call back any subdissector registering
for a particular RTP payload type string. This allows to render the value of
the header extension in a different, more flexible way compared to the default
numeric representation, such as in form of a subtree.

svn path=/trunk/; revision=23943
2007-12-23 20:10:57 +00:00
Tomas Kukosa a76ff82d70 - register RFC 2198 as RTP dynamic payload type "red"
- display dynamic payload type names inside RFC 2198

svn path=/trunk/; revision=23846
2007-12-12 10:51:09 +00:00
Tomas Kukosa 9b3c5f9f03 display SRTP isntead of RTP if stream is established like a SRTP
svn path=/trunk/; revision=23337
2007-11-02 07:43:49 +00:00
Jaap Keuter b2d63bac5f Allow for full size setup method name.
svn path=/trunk/; revision=22863
2007-09-13 18:47:54 +00:00
Jaap Keuter 7b593acb18 From Neil Piercy:
This patch set provides a an API for out of band signalling protocols to
register flows as SRTP/SRTCP using extended versions of the existing
rt(c)p_add_address functions. At present the encrypted portions of the payloads
are simply skipped, and the auth tags etc added as fields.

svn path=/trunk/; revision=22562
2007-08-21 07:23:34 +00:00
Martin Mathieson 59c8ec0670 Make contributing items and hdr extensions proper fields.
svn path=/trunk/; revision=22382
2007-07-23 14:39:17 +00:00
Stephen Fisher 2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Anders Broman 4098c5e357 From Charles Lepple:
When dissecting RTP packets with a H.263 payload, the "Mark" flag runs into the Mode A/B flag in the info column.

From me abriviate Payload type to PT.

svn path=/trunk/; revision=20899
2007-02-23 06:47:07 +00:00
Anders Broman 33910c713f From Richard van der Hoff:
Along with this bug, identified by Mark, there is another problem, in that one of the chunks of my earlier patch seemed to get missed off when Anders committed it. This won't break anything yet, as the H.223-over-RTP dissection hasn't landed on trunk yet, but it will cause all sorts of nasties when it does.

Here is a new patch, against current trunk, which should fix Mark's bug, my bug, and a comment typo.

And a patch wich improves the general robustness of the h.223 dissector (making it less likely to crash on malformed data).

Hopefully this also fixes a bug raised by Fabio Sguanci a few weeks ago. 
Fabio: I think a better way to fix the problem is to stop the dissector crashing when it finds a malformed PDU, so that it just treats the first pdu as malformed; there is then no need to special-case it.

svn path=/trunk/; revision=20898
2007-02-22 20:40:19 +00:00
Anders Broman 86671a0de0 From Richard van der Hoff:
Here's a patch which adds an option enabling subdissectors to request defragmentation of packets over RTP streams, using the 
pinfo->desegment_{len,offset} API.

svn path=/trunk/; revision=20891
2007-02-21 06:45:34 +00:00
Martin Mathieson 946897ace7 Make RFC2198 pt preference work (wasn't calling
proto_reg_handoff_rtp when prefs changed).

svn path=/trunk/; revision=20822
2007-02-16 13:47:49 +00:00
Anders Broman f2b23aaffb Don't call subdissector for dynamic PT based on PT number if conversation info exists.
svn path=/trunk/; revision=20678
2007-02-01 20:49:34 +00:00
Martin Mathieson 2bfdb780ee Set correct length for extensions root
svn path=/trunk/; revision=19393
2006-10-02 10:49:57 +00:00
Tomas Kukosa f8ae861c94 the 1st very simple attempt to support RFC 2198 Redundant Audio Data
svn path=/trunk/; revision=18581
2006-06-27 12:40:53 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Gerald Combs a00e7fb4fb ntp_fmt_ts() doesn't take two arguments any more.
svn path=/trunk/; revision=17231
2006-02-09 19:22:15 +00:00
Gerald Combs 1602ca0715 Add support for PacketCable CCC-encapsulated RTP data, described in
PKT-SP-ESP1.5-I01-050128.

Sponsored by CableLabs.

svn path=/trunk/; revision=17230
2006-02-09 17:42:42 +00:00
Guy Harris c831848dd5 Fix description of version0_type, now that it also supports T.38.
svn path=/trunk/; revision=17130
2006-01-31 02:31:18 +00:00
Guy Harris f9eaba6d69 Add an option to dissect purported RTP packets with a version number of
0 as T.38 rather than STUN.

svn path=/trunk/; revision=17116
2006-01-29 00:40:40 +00:00
Anders Broman 2916d12d76 Packet-amr Register as "AMR" not "amr".
Add Dynamic PT:s mimestring  to rtp_info if avalable.
Use Dynamic PT:s mime string to find clock rate.

svn path=/trunk/; revision=16397
2005-11-05 21:38:22 +00:00
Ronnie Sahlberg 2a84d72f8f remove a strcpy call
svn path=/trunk/; revision=16333
2005-10-27 09:07:22 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Gerald Combs efdef9c5aa For SNMP, malloc memory that we're going to free later. Fixes bug 406.
For RTP, don't free se_allocated memory.

svn path=/trunk/; revision=15694
2005-09-05 21:38:10 +00:00
Ronnie Sahlberg 234f09c663 more gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15312
2005-08-12 10:50:55 +00:00
Jörg Mayer 5602f5bb83 Make some funtions static. More char -> const char warning fixes
svn path=/trunk/; revision=15146
2005-07-30 01:01:02 +00:00
Luis Ontanon 763afdea30 From: Martin Mathieson
fix cases where %d has been used instead of %u...


svn path=/trunk/; revision=14583
2005-06-07 23:25:46 +00:00
Gerald Combs 0b1b3d5716 From Lars Roland:
Make sure a hash table exists before trying to access it.  Fixes bug 105.

svn path=/trunk/; revision=14305
2005-05-04 16:40:30 +00:00
Ronnie Sahlberg 79b30e6df5 From Lars Ruoff
Make it possible to tap 4 PDUs from one frame


svn path=/trunk/; revision=14015
2005-04-04 20:12:18 +00:00
Guy Harris bed220604d "get_conv_info()" doesn't use the tvbuff passed to it, so don't pass it
one.

svn path=/trunk/; revision=13994
2005-04-01 09:19:29 +00:00
Gerald Combs a988f8f5cc Pass a NULL instead of an empty string in the value_string/true_false_string
field of hf_rtp_payload_type.  This should fix the "values output" test failures
in the FreeBSD builder.

svn path=/trunk/; revision=13959
2005-03-28 19:19:19 +00:00
Anders Broman d0c11490d0 Fix a typo
svn path=/trunk/; revision=13947
2005-03-27 22:11:09 +00:00
Anders Broman ec539cbdb3 From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

svn path=/trunk/; revision=13942
2005-03-27 21:37:05 +00:00
Guy Harris 7846581664 Fix some comments.
Use the same code to handle payload types in sessions set up by SDP and
sessions set up by other protocols, rather than duplicating that code.

svn path=/trunk/; revision=13775
2005-03-16 19:55:49 +00:00
Anders Broman fce4f45b75 Try the pt_dissector table also if conversation has been set up with SDP.
svn path=/trunk/; revision=13772
2005-03-16 19:25:13 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Lars Roland 186683631f use "guint" instead of "uint".
"uint" is not available on Windows

svn path=/trunk/; revision=13357
2005-02-08 21:12:54 +00:00
Guy Harris 83c47dc3d6 From Jon Ringle: add a preference to allow packets with an RTP version
of 0 to be dissected as STUN packets, to support dissecting of
application that follow the ICE methodology described in
draft-ietf-mmusic-ice-03.

Remove some extra spaces at the end of tags for preferences.

svn path=/trunk/; revision=13356
2005-02-08 20:54:08 +00:00
Anders Broman 84d4f0e508 From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now 
using an RTP tap (not using the rtp_stream).

svn path=/trunk/; revision=13300
2005-02-05 11:08:24 +00:00
Anders Broman 851ecd2ac4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13243
2005-02-02 20:07:03 +00:00