tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.
Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
1. Case sensitivity differences between hf_ field name and formatted string.
2. Unnecessary whitespace between hf_ field name and colon in formatted string
There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed.
svn path=/trunk/; revision=52098
- Adapted packet-gsm_sim.c and CmakeLists.txt to match current content (trivial)
- Fixed warnings about //-style comments that were found running
../../tools/checkAPIs.pl -g deprecated -g prohibited -g abort -g termoutput packet-gsm_sim.c packet-etsi_card_app_toolkit.c
Error: Found C++ style comments in packet-gsm_sim.c
- Not fixed (will lead to dissector abort if in a packet):
../../tools/checkhf.pl packet-gsm_sim.c packet-etsi_card_app_toolkit.c
ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b19
ERROR: NO ARRAY: packet-gsm_sim.c, hf_tprof_b18
ERROR: NO ARRAY: packet-etsi_card_app_toolkit.c, hf_ctlv_bearer_descr
Please provide the necessary element entries for the hf[] array in a
followup patch.
svn path=/trunk/; revision=40854
In order to ensure one consistent GSMTAP definition, some comments are added to
the code in order to make sure modifications are first merged in the GSMTAP
mainline header file, and then propagated to wireshark.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6442
svn path=/trunk/; revision=39366
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_BOOLEAN
FT_IPv4
FT_EUI64
FT_GUID
FT_UINT_STRING
Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)
svn path=/trunk/; revision=39328
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
Fix the GSMTAP to TETRA table
GSMTAP has the BSCH at 1... this means the table needs to have 9 entries, the
first being 0.
--------------------------------------------------------------------------------
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659
svn path=/trunk/; revision=35882
gsmtap: Update header file, add tetra support
0001 Minor cleanup - made it look crocked in visual studio, changed bu hand.
0002 Update the definitions from the 'upstream' source
0003 First bits of tetra decoding included in GSMTAP
0004 Pass the tetra PDUs to the TETRA decoder
Changed def. of gsmtap_to_tetra to make it compile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5659
svn path=/trunk/; revision=35864
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
Michael Mann