(Commented out for now since a few false positives are currently generated).
Fix a few minor bugs;
Tweak the calling sequences for various subs.
svn path=/trunk/; revision=47476
- Handle preprocessed (as well as original) .c source files.
(Running checkhf on the source after it has been pre-processed
should give few false positives).
- Remove blank lines, comments & quoted text strings before
doing the hf_... tests: reduces false positives/negatives.
svn path=/trunk/; revision=47458
- Remove comments from the input string before checking hf[] entries;
- Remove code under '#if 0' before doing API checks.
svn path=/trunk/; revision=47447
Main objective: reduce the number of false positives.
(Committed as a patch to the original
checkhf.pl written by Joerg Mayer so as to
keep the history for the original program).
svn path=/trunk/; revision=47331
Main objective: reduce the number of false positives.
Normal usage: the same as for checkhf.pl.
For now: named checkhf-v2.pl
svn path=/trunk/; revision=47326
------------------------------------------------------------------------
r47305 | gerald | 2013-01-26 12:12:52 -0800 (Sat, 26 Jan 2013) | 6 lines
Changed paths:
M /trunk-1.8/tools/fuzz-test.sh
Instead of setting resource limits on the fuzz-test.sh process itself,
set limits on the TShark subprocess. This should hopefully take care
of the strange fuzz failures we've seen lately.
Reduce the maximum CPU time to 5 minutes while we're at it.
------------------------------------------------------------------------
svn path=/trunk/; revision=47307
For .../dissectors/(non-generated dissectors):
Reduces the number of "unused" false positives (and
adds about 2 different false positives).
svn path=/trunk/; revision=47280
Try to convince Coverity that the passed in item pointer is appreciated,
but not used.
This time see if it pleases the Windows compiler too.
svn path=/trunk/; revision=47217
variable (WIRESHARK_DEBUG_USE_SLICES) which turns off the slab allocator and uses
g_slices instead (which can themselves be turned off by setting
G_SLICE=always-malloc).
This makes debugging problems in slab-allocated memory easier to find
(hopefully including https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197 ).
Set WIRESHARK_DEBUG_USE_SLICES when running Valgrind on *shark.
Remove unused structure member: emem_chunk_t.org.
svn path=/trunk/; revision=47110
"const char *", as it is now expected to be. Regenerate the dissectors.
Update the URL for OmniOrb.
In README.parlay, use idl2wrs in the sample command.
svn path=/trunk/; revision=46765
GTK+: Shorten the packet comment menu item name. Remove a couple of
unneeded includes.
Both: Add an arbitrary 20 MB limit when fetching all packet comments.
Use a color from the Tango palette for comments.
svn path=/trunk/; revision=46709
determine the desired type. This has two advantages over the old way:
- just one environment variable for valgrind to override in order to guarantee
that ALL allocators use memory it can track, and just one place to check that
variable
- allocator owners no longer have to include headers specific to their
allocator, allowing them to change allocators without adjusting all their
#includes
svn path=/trunk/; revision=46604
Note the change in behavior: building the tree is now off by default.
Complain (and exit) if we get an argument we don't understand.
svn path=/trunk/; revision=46321
doesn't seem (to me) to warrant preventing someone from fuzz-testing.
Anyone know why this was put in in the first place?
svn path=/trunk/; revision=45733
- make html output a flag (-h), instead of what happens when you
specify no files
- add flag (-j) for job count, like make et al.
- add flag (-a) to ignore the suppressions file and report all issues
- require /bin/bash instead of just /bin/sh in order to get arithmetic $(())
- add mode-lines
svn path=/trunk/; revision=45520
Updated wireshark_gen.py to generate hf_ variables for all of the IDL "types". The "simple" types use proto_tree_add_* (not text), while the "complex" types use the GIOP dissector API. checkhf.pl generates some warnings because (some of) the hf_ variables are being generated for the "complex" types, but are not being used. That will be done in Part 2.
expert_add_info_format now linked to a real item instead of being attached to a duplicative proto_tree_add_text(). This cleaned up literally thousands of unnecessary proto_tree_add_text()s
svn path=/trunk/; revision=45472
Add some additional memory-allocation failure checks in Lemon.
Use NULL rather than 0 as the null-pointer constant in those
checks.
From me:
Catch one more of the NULL-vs-0 cases.
Fix some failure messages to use fprintf(stderr, ...) -
ErrorMsg() requires a file name and line number, and is
generally used if you're going to continue rather than just give
up.
svn path=/trunk/; revision=45214
Fixed GTKHash table being overwritten when number of NCP packets exceeds 255. Sequence numbers wrap so this was causing the request value table to be overwritten and subsequent malformed NCP packets.
Fixed buid_expert_data for file open reporting to correctly convert to Hex value so proper lookup in val table will succeed.
Added additional OES Linux values to build_expert_data for server entries.
svn path=/trunk/; revision=45177
plugin.c or register.c content to a temporary file build a giant string
in memory and only write it if the current and new hashes differ.
This requires hashlib which was added in Python 2.5; hopefully that's
not a problem.
svn path=/trunk/; revision=45104
Only update outfile if it differs from newly created outfile
make-dissector-reg.py
Add a comment that we should do the same here (probably a small
task for python knowledeable people).
svn path=/trunk/; revision=45083
the compile line when building with cmake.
Put _U_'s definition in config.h when building with autofoo and on Windows.
svn path=/trunk/; revision=45034
registration and handoff routines in each line, read the whole file into
memory and then do one findall() search. Store the matches in sets to avoid
duplication.
(This also simplifies the number of regexps we're looking for.)
This speeds up the generation of register.c (when there is no cache)
significantly (on my system the time taken drops from ~32 seconds to ~5
seconds).
svn path=/trunk/; revision=44954
sort them. Avoids the double registration problem discussed on -dev today.
Note: the sorted() call requires Python 2.4+ but I think that's OK now.
svn path=/trunk/; revision=44952
wireshark-win{32,64}-libs instead. In win-setup.sh only try to unzip
files ending in .zip. PortableApps and U3 packaging changes are untested.
svn path=/trunk/; revision=44888
Ignore "duplicates" that are generated because a display filter is prefixed by a #define (which checkfiltername.pl is not smart enough to handle), causing an empty string
svn path=/trunk/; revision=44654
Also added a "FILE TYPE" for proto filter names with a period so that they can be verified. Presumably only "large", possibly "meta" protocols (probably spanning multiple dissector files) will be allowed to use a period in the proto filter name.
svn path=/trunk/; revision=44648
These happen when, eg, a program runs out of memory under valgrind
or other more fatal errors (that may sometimes be valgrind bugs instead).
svn path=/trunk/; revision=44451
The idl2wrs generated dissectors don't follow the convention of using the
filter name registered with the protocol as the start of any display filter
name. This patch fixes that.
svn path=/trunk/; revision=44325
Add commandline options to show file line numbers of dissectors. The default is to have no line numbers shown as its easier to compare results without a minor file change causing the line number of the filter to change resulting in an unnecessary difference.
Add commandline option to check filter names of automated files (default disabled).
Check for underscores prefacing or following a period in filter names as this is probably a typo.
Cleaned up output when checking a single file.
svn path=/trunk/; revision=44182
- add support for 2-pass dissection and config profiles
- make whitespace a consistent 4-spaces
fuzz-test.sh:
- update 2-pass support to use -2 and not the old -P
- add support for fuzz-testing under valgrind with the new -g option
svn path=/trunk/; revision=44024
- Take command-line arguments of files to check. In this case make output
GCC-like, as it's much more human-readable than the HTML.
- If there are no arguments, provide HTML output for the entire current
directory like before, for use with build-bot integration.
- Don't hack with the CWD to try and get include-paths to work. Cppcheck
will warn already if it can't find them, and since a lot of the checks
still work in any case, a warning is more appropriate than an error or
a hack.
svn path=/trunk/; revision=43882
