Chris Maynard
de91f3638b
Declare count as ssize_t instead of size_t, since read(), and thus ws_read(), can return a negative number. If that were to happen, then assigning the return value to an unsigned variable and then comparing that variable against 0 will yield incorrect/unintended results. Fixes Coverity CID 761910: Negative array index write.
...
svn path=/trunk/; revision=47069
2013-01-14 16:34:19 +00:00
Bill Meier
31e5c6f727
Replace gtk_table...() with ws_gtk_grid...().
...
Also:
Use #if 0 rather than /* */ to coment out some code;
Very minor whitespace fixup.
svn path=/trunk/; revision=47068
2013-01-14 16:17:42 +00:00
Chris Maynard
231bd8ab50
Fix Coverity CID 762007: Logically dead code.
...
svn path=/trunk/; revision=47067
2013-01-14 16:06:20 +00:00
Chris Maynard
110509a77f
Fixed Coverity CID 762008: Structurally dead code.
...
svn path=/trunk/; revision=47066
2013-01-14 15:49:30 +00:00
Jeff Morriss
664d138ea2
Previous commit put a little too much of the README.developer boilerplate in...
...
svn path=/trunk/; revision=47065
2013-01-14 15:47:55 +00:00
Chris Maynard
9dedcbdb82
packet-ncp2222.c -> dissectors/packet-ncp2222.c
...
svn path=/trunk/; revision=47064
2013-01-14 15:39:38 +00:00
Jeff Morriss
e64d2f9b3f
In response to http://ask.wireshark.org/questions/17660/licence-of-editcap
...
and as per email response from Richard Sharpe, add GPLv2+ boilerplate header
and license.
svn path=/trunk/; revision=47063
2013-01-14 15:25:49 +00:00
Chris Maynard
b89380dd74
Fix CID 966603: Unused pointer value.
...
svn path=/trunk/; revision=47062
2013-01-14 15:13:21 +00:00
Chris Maynard
c56910aa70
Fix CID 967205: Unused pointer value.
...
svn path=/trunk/; revision=47061
2013-01-14 15:09:12 +00:00
Jaap Keuter
23d2320dd0
Fixing CID 280433 and 280357.
...
Also strengthening the checking and debug presentation.
svn path=/trunk/; revision=47060
2013-01-14 07:43:14 +00:00
Bill Meier
165f86b9a3
Cleanup: Whitespace, formatting-style, long-lines & etc.
...
Use "4 space" indentation.
Add an XXX comment about better formating needed
for the text in the Help window (so the
text columns line up and so the Help text
looks better).
Comment out a "does-noting" for loop;
svn path=/trunk/; revision=47059
2013-01-14 04:28:16 +00:00
Bill Meier
c7120ce08e
Replace gtk_table...() with ws_gtk_grid...();
...
Also: Minor changes so that window resizing is handled
identically in Gtk2 & Gtk3.
svn path=/trunk/; revision=47058
2013-01-14 03:13:55 +00:00
Gerald Combs
917510f087
Fix building a Debian package.
...
svn path=/trunk/; revision=47053
2013-01-13 23:00:38 +00:00
Gerald Combs
a0df458eb8
[Automatic manuf, services and enterprise-numbers update for 2013-01-13]
...
svn path=/trunk/; revision=47048
2013-01-13 15:03:34 +00:00
Pascal Quantin
ccbff26e80
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8196 :
...
Add dissection of IPv4v6 type to End User Address IE
svn path=/trunk/; revision=47047
2013-01-13 11:04:46 +00:00
Michael Mann
a9fb54c677
bugfix nested loop that wasn't breaking out of the main loop when subloop really wanted it to. Bug 8198 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8198 )
...
svn path=/trunk/; revision=47046
2013-01-13 02:58:42 +00:00
Michael Mann
8a18cb574b
guint16 needed to prevent rollover. Bug 8199 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8199 )
...
#BACKPORT
svn path=/trunk/; revision=47045
2013-01-13 02:03:55 +00:00
Bill Meier
492d84d6a2
General whitespace & formatting style cleanup.
...
svn path=/trunk/; revision=47044
2013-01-12 20:00:50 +00:00
Bill Meier
83bc776dc3
Replace gtk_table...() with ws_gtk_grid...().
...
svn path=/trunk/; revision=47043
2013-01-12 18:40:01 +00:00
Bill Meier
4fbdb87e1a
General cleanup: whitespace, long-lines, & etc.
...
svn path=/trunk/; revision=47042
2013-01-12 16:23:09 +00:00
Pascal Quantin
d3e4d6c972
Upgrade RRC dissector to v11.4.0
...
svn path=/trunk/; revision=47041
2013-01-11 23:25:30 +00:00
Guy Harris
b8af5b44d1
#if 0 out some variables that are used only in now-#if 0'ed code.
...
svn path=/trunk/; revision=47040
2013-01-11 21:20:57 +00:00
Pascal Quantin
9f387eddbb
Try to deduce NAS EPS Detach Request direction from message size
...
svn path=/trunk/; revision=47039
2013-01-11 20:54:04 +00:00
Bill Meier
b57a1dd5db
Replace gtk_table...() with ws_gtk_grid...().
...
Also: remove some trailing whitespace.
svn path=/trunk/; revision=47038
2013-01-11 20:27:43 +00:00
Guy Harris
ef9384ff60
Fix uninitialized variable.
...
svn path=/trunk/; revision=47037
2013-01-11 20:25:05 +00:00
Pascal Quantin
d4cf9ce69a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8193 :
...
Add dissection of Dual Address Bearer Flag bit in Common Flags IE
svn path=/trunk/; revision=47036
2013-01-11 20:18:32 +00:00
Guy Harris
ebdc5f8d55
Get rid of unused variable.
...
svn path=/trunk/; revision=47035
2013-01-11 20:08:43 +00:00
Pascal Quantin
1ca9d5c2b3
Upgrade LPP dissector to v11.1.0 and modify extract_asn1_from_spec.pl to automatically get ASN.1 from spec
...
svn path=/trunk/; revision=47034
2013-01-11 19:31:15 +00:00
Michael Mann
660e028212
Add support for expanded Gigamon Trailer format
...
from Sandeep Dahiya, bug 8191 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8191 )
svn path=/trunk/; revision=47033
2013-01-11 19:20:39 +00:00
Bill Meier
a63b7f9264
Replace gtk_table...() with ws_gtk_grid...();
...
Add an XXX comment about trying (and failing)
to change the behavior of the grid when the
column prefs window is horizontally resized.
Also: do whitespace cleanup: indentation & etc.
svn path=/trunk/; revision=47032
2013-01-11 18:26:35 +00:00
Michael Mann
2d2198962a
replace g_warning with expert_add_info_format()
...
See bug 8155 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8155 )
svn path=/trunk/; revision=47031
2013-01-11 15:57:11 +00:00
Bill Meier
00ae417aae
Remove a left-over "// note to myself".
...
svn path=/trunk/; revision=47030
2013-01-11 15:56:23 +00:00
Bill Meier
9ffde43550
Replace gtk_table...() with ws_gtk_grid...();
...
Also: Do general cleanup:
- #if 0 unused value_strings and unused functions;
- Whitespace, formatting style, long-lines, etc.
svn path=/trunk/; revision=47029
2013-01-11 14:47:47 +00:00
Michael Mann
8326a92942
Add RFC 5460 - DHCPv6 Bulk Leasequery
...
Bug 8172 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8172 )
svn path=/trunk/; revision=47028
2013-01-11 14:41:17 +00:00
Bill Meier
18679dccbd
Replace gtk_table..() with ws_gtk_grid...().
...
svn path=/trunk/; revision=47027
2013-01-11 01:41:55 +00:00
Bill Meier
e28da09c31
Replace gtk_table...() with ws_gtk_grid...().
...
Also: Do some minor whitespace cleanup.
svn path=/trunk/; revision=47026
2013-01-11 01:19:05 +00:00
Bill Meier
12220072c9
Replace gtk_table...() with ws_gtk_grid...().
...
Also: do general whitespace, long-lines and formatting style cleanup.
svn path=/trunk/; revision=47025
2013-01-11 00:54:08 +00:00
Bill Meier
780ff66b6e
Replace gtk_table...() with ws_gtk_grid...().
...
Do some minor changes so that the Gtk2 & Gtk3
window resizing behavior is the same.
Also: Clean up whitespace: indentation & etc.
svn path=/trunk/; revision=47024
2013-01-10 23:11:35 +00:00
Bill Meier
ee762f80c9
Replace gtk_table...() with ws_gtk_grid...();
...
Also: Remove creation of a widget which is
never used.
svn path=/trunk/; revision=47023
2013-01-10 21:47:25 +00:00
Bill Meier
1dba2b6377
Add ws_gtk_grid_attach(); Update some comments.
...
svn path=/trunk/; revision=47022
2013-01-10 20:47:40 +00:00
Bill Meier
9e1bf0acef
Update comments.
...
svn path=/trunk/; revision=47021
2013-01-10 20:46:58 +00:00
Bill Meier
708de14dc8
Replace gtk_table...() with ws_gtk_grid...().
...
svn path=/trunk/; revision=47020
2013-01-10 16:29:30 +00:00
Bill Meier
d6ddcc9e54
Replace gtk_table...() with ws_gtk_grid...()
...
with some minor changes so that window resizing
functions the same for both Gtk2 & Gtk3.
svn path=/trunk/; revision=47019
2013-01-10 15:19:29 +00:00
Irene Rüngeler
2dc365db46
Another solution to fix bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8183 .
...
Now both windows are modal.
svn path=/trunk/; revision=47018
2013-01-10 12:44:52 +00:00
Anders Broman
614441f9e5
#if 0 out unused code
...
svn path=/trunk/; revision=47017
2013-01-10 12:42:07 +00:00
Anders Broman
84a8c1d83a
From an.huang:
...
(1) support for optional attribute in Sample Value:
datSet (0x81),
refrTm (0x84),
smpRate (0x86),
smpMod (0x88). New attribute in 9-2 Ed2
(2) Data (0x87) decoded as PhsMeas in 9-2 LE(Lite Edition) recommemdation is removed, now the data is decoded as simply OctString, just as 9-2, further details should refer to the data set definition and Table 14 in Ed1 / Table 15 in Ed2 Encoding for the basic data types;
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5696
svn path=/trunk/; revision=47016
2013-01-10 12:13:16 +00:00
Irene Rüngeler
2a7031f12b
Fix for bug 8183 reported by David Bergeron.
...
svn path=/trunk/; revision=47015
2013-01-10 09:27:07 +00:00
Anders Broman
2d44d2e05c
From Alton MacDonald:
...
A TLV can be larger that the MIH payload. In this case the packet should be fragmented and controlled with the help of two fields in the MIH header. The attached patch checks these fields and dissects the TLVs if the MIH payload is not fragmented.
Additionally, if a TLV is detected larger than the payload size it is marked as a fragmented TLV and not dissected. This would be the case if the previously mentioned fields were not set correctly as their use under this scenario is not explicitly defined in the 802.21 standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
svn path=/trunk/; revision=47014
2013-01-10 07:36:32 +00:00
Anders Broman
68160dac5c
From "temp4746":
...
wslua TvbRange:le_ustring/ustring buffer overflow's.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8175
svn path=/trunk/; revision=47012
2013-01-10 06:55:16 +00:00
Anders Broman
84a94842a8
From "schlephorst":
...
BACnet dissect new tags in NotificationParameters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8181
svn path=/trunk/; revision=47011
2013-01-10 06:48:10 +00:00