Chris Maynard
79fa0d0a3f
Reject the packet if data is NULL without doing anything else.
...
Note: We *might* want to do _something_ but that _something_ should be well-defined and consistent across all dissectors. Previously, some dissectors called proto_tree_add_text() to add some error message text to the tree, while others called DISSECTOR_ASSERT().
svn path=/trunk/; revision=53895
2013-12-09 22:23:44 +00:00
Michael Mann
d5d8c3c359
context is not being passed to dissector, not through pinfo->private_data so check data parameter, not pinfo->private_data.
...
svn path=/trunk/; revision=53236
2013-11-10 17:17:18 +00:00
Michael Mann
b6b78d69db
In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1. This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data. Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is.
...
svn path=/trunk/; revision=53090
2013-11-05 18:47:26 +00:00
Michael Mann
149de99d68
Have rose_ctx_t passed into subdissectors instead of using pinfo->private_data.
...
svn path=/trunk/; revision=53061
2013-11-03 12:57:58 +00:00
Michael Mann
02a8391535
Require dissector_try_string to pass a data parameter to its subdissectors. There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new.
...
svn path=/trunk/; revision=53049
2013-11-02 15:52:25 +00:00
Jörg Mayer
c5ffff76d8
Fix checkapi warnings (missing id)
...
Replace Makefile.{am,nmake,common} that did not conform by
their asn1/c133/ version.
svn path=/trunk/; revision=52062
2013-09-15 15:00:03 +00:00
Michael Mann
9e3f9b449f
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51852
2013-09-09 00:44:09 +00:00
Michael Mann
00dd0adc0d
expert_add_info_format_text -> expert_add_info_format
...
svn path=/trunk/; revision=51851
2013-09-09 00:28:48 +00:00
Evan Huus
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
Evan Huus
b1e12ec925
Convert the rest of the ASN1 dissectors from emem to wmem.
...
svn path=/trunk/; revision=50063
2013-06-19 22:47:36 +00:00
Michael Mann
2dbf6c59a2
Remove check_col() from ASN.1 dissectors
...
svn path=/trunk/; revision=49927
2013-06-14 12:44:50 +00:00
Michael Mann
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
Jörg Mayer
572d68a33b
Small optical change
...
svn path=/trunk/; revision=49204
2013-05-07 17:52:51 +00:00
Jörg Mayer
369c7b75ee
Allow generating some more dissectors with cmake.
...
svn path=/trunk/; revision=49196
2013-05-07 04:40:37 +00:00
Jörg Mayer
243e9c0ba5
Just whitespace changes
...
svn path=/trunk/; revision=49167
2013-05-05 08:49:18 +00:00
Jörg Mayer
8faa262e90
Stub cmake support for generating the asn1 dissectors.
...
It doesn't do anything yet, it is just to make svn status
readable again.
svn path=/trunk/; revision=49007
2013-04-23 23:05:33 +00:00
Anders Broman
dafdc19d9e
-Wmissing-prototypes
...
svn path=/trunk/; revision=48609
2013-03-28 07:34:13 +00:00
Anders Broman
84241f46ad
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48399
2013-03-18 20:44:36 +00:00
Guy Harris
29715ccc8f
How can I get a new tvbuff that starts at an offset within a given
...
tvbuff and runs to the end of the tvbuff? Let me count the ways....
Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().
svn path=/trunk/; revision=47751
2013-02-19 23:17:07 +00:00
Jeff Morriss
3551a86c36
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Jakub Zawadzki
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Alexis La Goutte
fe3168dc2a
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=40462
2012-01-13 16:22:50 +00:00
Anders Broman
34ea886454
[-Wunused-but-set-variable]
...
svn path=/trunk/; revision=39829
2011-11-14 17:35:04 +00:00
Jeff Morriss
b21b495f9f
Don't generate the conformance file for exported types when building the
...
dissector; instead built it only when the separate target (generate_export)
is built.
Built generate_export when building "all".
This prevents the exp_*.cnf files from being regenerated each time another one
of the exp_*.cnf files (which the current dissector depends on) has changed
(despite the fact that the exported types does not depe
Also fix the CLEANFILES definition so it actually cleans things.
svn path=/trunk/; revision=39421
2011-10-14 10:22:01 +00:00
Jeff Morriss
cf012d27b1
Build the ASN.1 dissectors directly into epan/dissectors (rather than building
...
them and then copying them over). The "all" target to builds these dissectors
now (instead of "generate_files" and/or "copy_files").
asn2wrs's "-O" option now means "the dissector goes in this directory" (rather
than "all output goes in this directory"); it also means that the "-s" (single
output file) option is now required.
Fix things up so that it's possible to build all of the ASN.1 dissectors in
one shot.
Fix building of conformance files when doing out-of-source-tree builds.
Unfortunately "make all" in the asn1 directory always builds something--I think
because of circular depedencies.
svn path=/trunk/; revision=39333
2011-10-10 02:31:11 +00:00
Stig Bjørlykke
ba2aae0f8e
Use ENC_NA as encoding for FT_PROTOCOL, FT_NONE and FT_BYTES.
...
svn path=/trunk/; revision=38122
2011-07-19 18:48:31 +00:00
Stig Bjørlykke
f282154ab0
Use correct encoding for proto_tree_add_item().
...
svn path=/trunk/; revision=38107
2011-07-19 10:51:12 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Tomas Kukosa
eb503df011
Do not report undecoded message to expert info for ReturnResult without result filed
...
svn path=/trunk/; revision=34076
2010-09-08 09:02:16 +00:00
Graeme Lunt
cfdd4788cf
Updates to the ROS dissector to support IDMP and fix to IDMP for implicit declaration of return value of call_ros_oid_callback().
...
svn path=/trunk/; revision=33182
2010-06-09 14:45:38 +00:00
Jeff Morriss
81da8e0b6b
Use find_or_create_conversation() in some ASN.1 dissectors
...
svn path=/trunk/; revision=32791
2010-05-13 18:55:31 +00:00
Bill Meier
9ade30a7b1
#include <string.h> and/or #include <stdio.h> not needed.
...
svn path=/trunk/; revision=32417
2010-04-07 16:54:29 +00:00
Bill Meier
f8b92f8d0b
#include <stdio.h> not needed.
...
svn path=/trunk/; revision=32405
2010-04-06 17:01:14 +00:00
Bill Meier
3a9c03abd6
Fix gcc -Wshadow warnings
...
svn path=/trunk/; revision=31714
2010-01-28 14:43:01 +00:00
Bill Meier
723533dbe4
Remove a check_col() in asn1 template file (SVN #31519 did only the generated file).
...
svn path=/trunk/; revision=31697
2010-01-27 14:54:48 +00:00
Jeff Morriss
6bbd17bcf9
Don't se_alloc() the conversation structure which contains pointers to two
...
g_hash_tables that we then try to free in ros_reinit(). Instead, g_malloc()
the conversation structure and free it (along with the hash tables) in the
reinit function.
svn path=/trunk/; revision=30601
2009-10-18 20:13:56 +00:00
Stig Bjørlykke
6d1dae6f28
Make all proto_* values static.
...
svn path=/trunk/; revision=30516
2009-10-11 16:24:29 +00:00
Kovarththanan Rajaratnam
7ab993bee7
Remove unused NEED_PACKET_PROTO_H variable
...
svn path=/trunk/; revision=30409
2009-10-08 17:26:57 +00:00
Tomas Kukosa
60022bc5f2
Expert info for undecoded Q.932 and H.450 operations
...
svn path=/trunk/; revision=29534
2009-08-24 09:05:15 +00:00
Kovarththanan Rajaratnam
0a5b014cec
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam
e971354a54
Don't guard col_set_str (COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke
0437f102c3
From Kovarththanan Rajaratnam:
...
More FT_XXX cleanup.
svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Graeme Lunt
c77ceafb0a
Small typo.
...
svn path=/trunk/; revision=28591
2009-06-02 09:50:09 +00:00
Stig Bjørlykke
6a713aad50
Added expert info for OID not implemented.
...
svn path=/trunk/; revision=28422
2009-05-20 09:27:45 +00:00
Stig Bjørlykke
94e9e2b1ec
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Anders Broman
84bbe30340
Get rid of unused code warnings.
...
svn path=/trunk/; revision=25809
2008-07-23 21:55:56 +00:00
Graeme Lunt
f8b679847e
Handling of ROS Rejects.
...
svn path=/trunk/; revision=24983
2008-04-13 16:11:15 +00:00
Jörg Mayer
3d22aa561b
asn1/*/Makefile.nmake were not part of the source package.
...
Spotted by Tomas Kukosa.
svn path=/trunk/; revision=23921
2007-12-19 10:02:50 +00:00
Tomas Kukosa
1e794fc494
ANSI TCAP regenerated and tested with -T -X asn2wrs options
...
asn2wrs has -T (tagged types support) and -X (new BER sttructures) default behavior
remove all -T and -X usage
svn path=/trunk/; revision=23823
2007-12-10 08:35:41 +00:00