Commit Graph

24253 Commits

Author SHA1 Message Date
Bill Meier ffb3264a99 #if 0 some unused #defines.
svn path=/trunk/; revision=54306
2013-12-20 16:03:24 +00:00
Bill Meier bf9f19e308 #if 0 some unused #defines;
Add editor modelines.

svn path=/trunk/; revision=54305
2013-12-20 15:55:40 +00:00
Evan Huus 82112c8ea3 The payload of a compressed Kafka message is supposed to be itself a
message-set, so dissect it as such. I don't have a capture demonstrating this
at the moment, but it ought to work.

svn path=/trunk/; revision=54303
2013-12-20 15:14:52 +00:00
Evan Huus 1feb5f00c1 Simplify dissect_kafka_metadata_request() to not add an unnecessary tree and
match the rest of the protocol dissection in style.

svn path=/trunk/; revision=54301
2013-12-20 15:03:08 +00:00
Martin Kaiser 73f1356275 use small negative values for the error defines
(such constants are signed ints by default)

svn path=/trunk/; revision=54300
2013-12-20 15:02:23 +00:00
Martin Kaiser 0f59960219 we can display UTF-8 encoded ISO 10646 BMP without any mapping
svn path=/trunk/; revision=54299
2013-12-20 15:00:26 +00:00
Martin Kaiser d8fd9f7ace add Asian DVB-SI character tables
minor whitespace changes

svn path=/trunk/; revision=54298
2013-12-20 14:59:34 +00:00
Martin Kaiser cf3276b1fc simplify the defines for DVB chartables
there's no need for their values to match the values in the DVB-SI spec
we can summarize basic and extended table definitions

svn path=/trunk/; revision=54297
2013-12-20 14:58:43 +00:00
Evan Huus c38424311f Replace one more g_memmove with memmove, add a cast to make the Lua stuff
compile.

svn path=/trunk/; revision=54296
2013-12-20 14:45:24 +00:00
Evan Huus 9fba5a787e g_memmove has been removed in favour of normal memmove in the latest glib
versions, so do the same. Plain old memmove appears to be specified in C90, so
I'm not sure why they ever needed a compat function in the first place...

svn path=/trunk/; revision=54295
2013-12-20 14:35:34 +00:00
Jeff Morriss c3de9c6311 As pointed out in http://ask.wireshark.org/questions/28304/questions-on-packet-kafkac :
ett_kafka_metadata_topics is defined (and registered) but not used.  Use it.

svn path=/trunk/; revision=54294
2013-12-20 14:28:16 +00:00
Stig Bjørlykke de2bcb2c8e Build correct base table in init.lua after changes in epan/proto.h
svn path=/trunk/; revision=54293
2013-12-20 13:38:36 +00:00
Stig Bjørlykke db3c476e6c Rewrote ProtoField_new to:
- Allow both string and integer for type and base (improve usability).
- Check valid base and mask for different types (avoid crashes).
- Remove ftypes.PROTOCOL from valid types.

This should fix bug #9549.

svn path=/trunk/; revision=54292
2013-12-20 13:33:48 +00:00
Martin Kaiser fe98b8ebc8 use STR_ASCII instead of BASE_NONE for strings
svn path=/trunk/; revision=54291
2013-12-20 13:23:13 +00:00
Martin Kaiser 217f7109cb don't assert if an FT_BYTES entry is empty
svn path=/trunk/; revision=54290
2013-12-20 13:17:24 +00:00
Guy Harris 198ce0b6c7 Fix indentation.
svn path=/trunk/; revision=54289
2013-12-20 10:30:57 +00:00
Guy Harris 1cf2e46426 bytes_to_hexstr_punct() does not add a null terminator, so we must add
it ourselves.

svn path=/trunk/; revision=54288
2013-12-20 10:08:35 +00:00
Stig Bjørlykke 2548f6ee2b Strip leading spaces in unknown-extension value.
svn path=/trunk/; revision=54287
2013-12-20 09:04:12 +00:00
Pascal Quantin f48dde1444 Fix a "'str' may be used uninitialized in this function" error
svn path=/trunk/; revision=54285
2013-12-20 08:33:18 +00:00
Martin Kaiser 852d93afa7 comment out unused function
svn path=/trunk/; revision=54284
2013-12-20 07:57:02 +00:00
Martin Kaiser 1170be181b fix compilation without libgcrypt
svn path=/trunk/; revision=54283
2013-12-20 07:56:38 +00:00
Pascal Quantin f390e381e7 Fix time dissection broken in r54274
svn path=/trunk/; revision=54282
2013-12-20 06:55:56 +00:00
Anders Broman 350a207a22 Try to please the buildbot.
svn path=/trunk/; revision=54281
2013-12-20 06:50:46 +00:00
Anders Broman 5fbfa6c351 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54280
2013-12-20 06:30:13 +00:00
Michael Mann f4ef031335 Make more items filterable courtesy of convert_proto_tree_add_text.pl
svn path=/trunk/; revision=54279
2013-12-20 02:13:02 +00:00
Pascal Quantin 56fa8467cd Try to please Clang-Code-Analysis buildbot
svn path=/trunk/; revision=54278
2013-12-19 22:55:16 +00:00
Pascal Quantin 6af6cd7089 Add out-of-band send_preamble event to UDP framing protocol
svn path=/trunk/; revision=54277
2013-12-19 22:40:49 +00:00
Michael Mann 704f759ee4 Makes "slot" filterable to pacify checkAPIs.pl
svn path=/trunk/; revision=54276
2013-12-19 22:18:30 +00:00
Michael Mann 1e29ff6699 proto_tree_add_text -> proto_tree_add_string to satisfy checkAPIs.pl
svn path=/trunk/; revision=54275
2013-12-19 22:05:07 +00:00
Michael Mann 959a290961 proto_tree_add_text -> proto_tree_add_xxx conversion.
svn path=/trunk/; revision=54274
2013-12-19 21:51:09 +00:00
Pascal Quantin d66bffb66e Add System Frame Number to UDP framing protocol and display it in info column
svn path=/trunk/; revision=54272
2013-12-19 21:40:38 +00:00
Evan Huus 6be37815a1 Add bytestring_to_str() which takes a wmem scope and is otherwise identical to
bytestring_to_ep_str (now deprecated). Use the new one in a few obvious places.

Also just print directly to the buffer when loading ethernet addresses for
resolution. The straight-to-buffer bytes_to_hexstr seems useful, maybe it
shouldn't be in a private header...

svn path=/trunk/; revision=54270
2013-12-19 20:53:44 +00:00
Bill Meier 1ed5971a72 Remove 'L' and 'LL' from constants; they are all used as 32-bit quantities.
#if 0 an unsed constant definition.

svn path=/trunk/; revision=54269
2013-12-19 20:52:56 +00:00
Bill Meier bc301c467d Add XXX comment as follows:
/* XXX: GINT_MAX is not defined so #if ... will always be false */
 #if (GINT_MAX >= (1LL << 32))
   ...
 #endif

Remove _U_ on several function parameters.

Do some very minor whitespace changes;
Add editor modelines.


svn path=/trunk/; revision=54268
2013-12-19 20:34:13 +00:00
Bill Meier e2c5575e80 Cast result of strtol() to guint32;
svn path=/trunk/; revision=54266
2013-12-19 19:29:44 +00:00
Chris Maynard 3dc77cefed Need to call ptvcursor_current_offset() BEFORE ptvcursor_free().
svn path=/trunk/; revision=54257
2013-12-19 17:48:58 +00:00
Martin Mathieson 4509ef242d Change types and add cast to try to please buildbot
svn path=/trunk/; revision=54256
2013-12-19 17:48:32 +00:00
Chris Maynard 725d85f002 Fix leaks where ptvcursor_free() wasn't being called.
svn path=/trunk/; revision=54255
2013-12-19 17:48:11 +00:00
Chris Maynard f756c9b2c4 Since we're always calling ptvcursor_new() now, always call ptvcursor_free().
svn path=/trunk/; revision=54254
2013-12-19 17:46:59 +00:00
Martin Mathieson 62393a672e Cope with spaces or dashes in security keys
svn path=/trunk/; revision=54251
2013-12-19 17:21:36 +00:00
Evan Huus 2ae8edccea Rename more to_str functions to have ep_ in the name if they return ephemeral
buffers. Remove two unused functions.

svn path=/trunk/; revision=54250
2013-12-19 16:28:39 +00:00
Evan Huus a6415ece0a Rename a couple of to_str functions to have ep_ in the name. This makes it
obvious that the returned string is ephemeral, and opens up the original names
in the API for versions that take a wmem pool (and thus can work in any scope).

svn path=/trunk/; revision=54249
2013-12-19 15:49:09 +00:00
Evan Huus b7ab4db210 Modelines and consistent indentation.
svn path=/trunk/; revision=54248
2013-12-19 15:27:44 +00:00
Stig Bjørlykke 3b73e8b479 Renamed new_TvbRange to push_TvbRange and use this when creating a new
TvbRange from a FieldInfo.

This should fix the crash in bug #9483.

svn path=/trunk/; revision=54247
2013-12-19 15:26:31 +00:00
Stig Bjørlykke 891b2372a0 Improved compressed user data handling.
svn path=/trunk/; revision=54246
2013-12-19 11:24:55 +00:00
Guy Harris 317b828986 Use proto_tree_add_item() or tvb_get_string_enc() instead of
tvb_get_unicode_string().  If there's an indication that the encoding is
UCS-2, use that, otherwise use UTF-16.  (For example, "BMP" stands for
"Basic Multilingual Plane", which is the part of Unicode that can be
encoded in 16 bits, hence UCS-2.)

In the description of the "Use Heuristics for UDP" preference for the
XML dissector, note that it's not just trying to recognize XML in UCS-2,
it's trying to recognize XML in *big-endian* UCS-2.

svn path=/trunk/; revision=54245
2013-12-19 09:19:33 +00:00
Guy Harris 4a346b7188 Use tvb_get_string_enc(), or proto_tree_add_item(), rather than
tvb_get_unicode_string() or g_iconv stuff.

svn path=/trunk/; revision=54244
2013-12-19 03:12:59 +00:00
Guy Harris 30129013b0 Use proto_tree_add_item() in cases where we don't actually look at the
value.

svn path=/trunk/; revision=54243
2013-12-19 02:41:27 +00:00
Jeff Morriss 6762f7e0c8 Some patches from Peter Harris:
[PATCH 1/5] X11 dissector: Sort declarations
This prevents pointless changes showing up in the diff when evaluating
unrelated changes to the generator.

See http://search.cpan.org/dist/perl-5.18.0/pod/perldelta.pod#Hash_randomization

[PATCH 2/5] X11 dissector: Silence warnings on perl 5.18, prevent 5.20
Perl 5.18 retroactively marked "given/when" experimental, with a
promise to remove or dramatically change it in 5.20.

Since there is no perl 5.20 yet, there is no way to make this script
compatible with it.

[PATCH 3/5] X11 dissector: Support variable_param (at least for glCallLists)
(This patch makes the change in r54232 unnecessary by using the previously-
unused variable.)

[PATCH 4/5] X11 dissector: Remove obsolete TODO item
This item was done in r53531 PATCH 09/11

svn path=/trunk/; revision=54242
2013-12-19 02:32:21 +00:00
Michael Mann cc152029f3 Exposing a couple of more constant arrays for ANSI-637. Bug 9471 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471)
From Michael Lum

svn path=/trunk/; revision=54241
2013-12-19 01:37:54 +00:00