Commit Graph

7241 Commits

Author SHA1 Message Date
Tim Potter 5ef6684a97 Apparently bit 0x80 of a SAMR domain handle is the permission to look
up alias members.

svn path=/trunk/; revision=7178
2003-02-21 00:19:02 +00:00
Guy Harris 365107a43d Don't return a success/failure value from a function if we're not going
to check the value, or if we always return "success".

Have "dissect_cops_object()" check for a bogus object length and give
up, returning an error indication, if it gets one.  Also don't store the
object length in a guint16, as we might round it up to a multiple of 4,
and if it's 65535, it gets rounded up to 0, not 65536, if it's 16 bits
long.

Have "dissect_cops_pr_objects()" check for a bogus object length and
give up if it gets one.  Also don't store the object length in a
guint16, as we might round it up to a multiple of 4, and if it's 65535,
it gets rounded up to 0, not 65536, if it's 16 bits long.

If "dissect_cops_object()" returns a "bogus length" indication, stop
dissecting.

If we've fetched a value, don't fetch it again to pass it to
"proto_tree_add_uint()".  If we haven't fetched the value, don't fetch
it to pass it to "proto_tree_add_uint()", use "proto_tree_add_item()".

svn path=/trunk/; revision=7177
2003-02-21 00:11:31 +00:00
Jörg Mayer 13c4434e9f Move packet-rsync.c into alphabetically correct posision in Makefile.*
Remove comma after last element in enum.

svn path=/trunk/; revision=7176
2003-02-20 12:04:11 +00:00
Guy Harris dd22e794c3 At least in regular SMB Browse and RAP messages, the server type mask is
not guaranteed to be aligned on a 4-byte boundary, so, if we're not
dissecting a DCE RPC request or reply, don't use "dissect_ndr_uint32()"
to extract the access mask.

svn path=/trunk/; revision=7175
2003-02-20 07:55:00 +00:00
Guy Harris 03533b258b Updates from Devin Heitmueller to add a framework to handle TLVs, and to
handle "oncoming buddy" and "signon" TLVs.

svn path=/trunk/; revision=7174
2003-02-20 04:42:08 +00:00
Guy Harris 46f4c41529 Don't try to put the policy handle name into the Info column if we don't
have a policy handle name.

svn path=/trunk/; revision=7173
2003-02-19 22:09:03 +00:00
Guy Harris d902039842 Updates from Greg Morris:
1. Added a number of NCP Error return values.
	2. Added ability to pass byte strings to summary window.
	3. Modified file NCP's to reflect file handle in summary window.
	4. Changed all NCP's using QueueID from big endian to little endian.
	This is different from Novell's NCP documentation but matches same
	information obtained from NDS dissector.
	5. Added over 50 more NDS error return values.
	6. Partially fixed NDS Request verb 6 (Search Entries)

svn path=/trunk/; revision=7172
2003-02-19 21:47:46 +00:00
Guy Harris 91b8a7567f From Brad Hards: initial rsync support.
svn path=/trunk/; revision=7171
2003-02-18 21:47:56 +00:00
Laurent Deniel 84eb2dafeb Remove hidden hf_rpl_type field from top level tree and add it to
rpl_tree subtree since this produces some weird thing like abort
in "Protocol Hierarchy Statistics".

svn path=/trunk/; revision=7170
2003-02-18 21:47:01 +00:00
Guy Harris 63bd8087e5 From Didier Gautheron: fix desegmentation code to handle sequence number
overflow.

svn path=/trunk/; revision=7169
2003-02-18 21:37:53 +00:00
Guy Harris 23ed899373 From Martijn Schipper: fix the tag for the 802.11g ERP Information field
to match draft 6.1 of the 802.11g spec.

svn path=/trunk/; revision=7168
2003-02-18 21:29:53 +00:00
Guy Harris 7aceda45b5 Sigh. It appears that atmsnoop might, at least for some packets, put 4
bytes of padding into the packet (possibly more, as if it's putting
extra stuff in the padding as Shomiti/Finisar Surveyor does, it might be
up to 7).  Fortunately, Surveyor puts lots of stuff into the padding, so
we'll crank up the "snoop vs. Surveyor" check to look for 4 or more
bytes.

svn path=/trunk/; revision=7167
2003-02-18 19:59:00 +00:00
Michael Tüxen 2a86c131fa Fixed a bug in the calculation of number of routing contexts.
svn path=/trunk/; revision=7166
2003-02-18 19:48:31 +00:00
Jörg Mayer 9befa53ac2 Update to version Feb, 9th
svn path=/trunk/; revision=7165
2003-02-18 11:27:50 +00:00
Jörg Mayer f40bf7ae8c Turn off -x
svn path=/trunk/; revision=7164
2003-02-18 11:24:19 +00:00
Guy Harris ade0adfe89 Add a function to dissect service contexts whose values don't
necessarily use the section 15.3.3 encapsulation rules, and use that to
dissect service contexts with unknown IDs.

svn path=/trunk/; revision=7163
2003-02-18 02:24:51 +00:00
Guy Harris 834966bcbf Add a dissector for the CodeSets service context.
Pass "encapsulation_boundary", not "seqlen_cd", as the boundary argument
to the dissector for RTCorbaPriority.

svn path=/trunk/; revision=7162
2003-02-18 02:03:29 +00:00
Olivier Abad c4ec808aad In gtk2, the "changed" signal is sent by the GtkTreeSelection, not the
GtkTreeView.

svn path=/trunk/; revision=7161
2003-02-17 21:08:37 +00:00
Richard Sharpe 729239067b Small explanation for why MS created their own KRB5 OID value.
svn path=/trunk/; revision=7160
2003-02-17 17:32:59 +00:00
Olivier Abad abe08df6d7 In gtk2 code, replace gdk_string_width() with the "Pango" way of
computing strings width and height.

svn path=/trunk/; revision=7159
2003-02-17 07:50:49 +00:00
Tim Potter 3031823bed Dissect the server type bitfield in NetServerGetInfo for SERVER_INFO_101
and SERVER_INFO_102.

Modify all callers to use the new interface.

svn path=/trunk/; revision=7158
2003-02-17 01:59:39 +00:00
Laurent Deniel 33b251a58f According to ITU/X.25 (refer to table G.2), only the bits 1 to 6
represent the number of semi-octets in the calling/called address
extension facility. So bits 7 and 8 shall be masked.
This fix avoids an incorrect detection of malformed packets.

svn path=/trunk/; revision=7157
2003-02-16 20:55:10 +00:00
Guy Harris f9a0be9c6b Fix a comment to more accurately describe what the statement following
it does.

svn path=/trunk/; revision=7156
2003-02-15 08:24:52 +00:00
Jörg Mayer 99209e3651 Comment out usage for obsolete configure args support
svn path=/trunk/; revision=7155
2003-02-15 03:17:17 +00:00
Guy Harris e236ed8c57 From Mike Frisch: add support for zero-length file handles (such as the
WebNFS root file handle).

svn path=/trunk/; revision=7154
2003-02-14 19:51:54 +00:00
Guy Harris 44fed5407e From Olivier Biot:
- Move all static definitions from packet-wbxml.h to packet-wbxml.c
 - Comment out inclusion of packet-wbxml.h in packet-wbxml.c
 - Append WBXML + version + public ID to the Info column

Then, while we're at it, get rid of packet-wbxml.h (we can reinstate it
if there's any functionality to export other than the dissector) and get
rid of the include of packet-wbxml.h (and update comments not to refer
to it).

svn path=/trunk/; revision=7153
2003-02-14 19:39:54 +00:00
Guy Harris ead3ec5970 From Brad Hards: put the XID into the protocol tree with a length of 2,
and fix some typos in field names.

svn path=/trunk/; revision=7152
2003-02-14 07:20:40 +00:00
Guy Harris e126482bae Don't have "decode_UnknownServiceContext()" put the service context
ID subfields into the tree - do that in "decode_ServiceContextList()",
and put them under the item for the entire service context ID.  Given
that, we don't need to pass it the encapsulation byte order and
alignment information, either.

Don't have it fetch the sequence length, either; just pass it the
sequence length as an argument.

When we create an item for the service context ID, get a string for the
service context name based on the entire service context ID, not just on
the SCID.

After dissecting the service context data, advance the offset to point
past the end of the context_data.

svn path=/trunk/; revision=7151
2003-02-14 07:14:18 +00:00
Tim Potter 2ef4720071 More cleanups - nearly done!
svn path=/trunk/; revision=7150
2003-02-14 06:23:45 +00:00
Tim Potter fa9fac40e2 Move some constants here from packet-dcerpc-spoolss.c
svn path=/trunk/; revision=7149
2003-02-14 06:21:30 +00:00
Tim Potter a351c970c6 Display the policy handle name in COL_INFO for the ClosePolicy RPC.
Change the policy names slightly so they look nicer.

svn path=/trunk/; revision=7148
2003-02-14 06:19:54 +00:00
Tim Potter b99ad855f0 Display user name in COL_INFO for ServerAuthenticate2 request.
Add note about putting DOMAIN\Username in COL_INFO when dissecting
LOGIN_IDENTITY_INFO (part of SamLogon RPC).

svn path=/trunk/; revision=7147
2003-02-14 06:17:20 +00:00
Tim Potter c57fb295ab Put info level in COL_INFO for DsRoleGetDomInfo RPC.
svn path=/trunk/; revision=7146
2003-02-14 06:14:27 +00:00
Guy Harris ba6bb6d97d From Didier Gautheron:
further fixes to the TCP graph code's cross handling;

	fix to sequence number overflow problems.

svn path=/trunk/; revision=7145
2003-02-14 05:00:05 +00:00
Guy Harris e6b5a93461 Properly set the ACE type in the summary line for an ACE - and, while
we're at it, avoid going past the end of a packet.  Put the ACE type's
hex value into that line if it's an unknown type.

svn path=/trunk/; revision=7144
2003-02-14 04:54:47 +00:00
Guy Harris 22f0f2989e From Olivier Biot: README.win32 updates for Cygwin.
svn path=/trunk/; revision=7143
2003-02-14 01:01:26 +00:00
Jörg Mayer f1f8ade280 Comment out unused variables
svn path=/trunk/; revision=7142
2003-02-13 23:49:19 +00:00
Guy Harris 2a3681db95 From Craig Rodrigues and Bernd Becker (merger of their patches, from
Craig):

	- correct bitmask for hf_giop_iop_vscid and hf_giop_iop_scid,
	  reflecting the change to a 24bit vendor id and 8 bit service id
	- set the length of the "Service Context List" tree correctly
	  after dissecting.  The length was just being set to the end of
	  the tvb
	- do not exit the loop through the Service Context List with
	  return if the sequence length is 0, continue the loop instead.
	  This should fix a problem reported by Mika Korpela.
	  (see
	  http://www.ethereal.com/lists/ethereal-dev/200205/msg00234.html)

svn path=/trunk/; revision=7141
2003-02-13 23:18:59 +00:00
Guy Harris acf70fe535 Make doc/Makefile.nmake work in POSIXLY_CORRECT environment, as per
Santeri Paavolainen's changes to make doc/Makefile.am work in such an
environment.

Move the idl2eth rules above the mergecap rules, to match the way
doc/Makefile.am works.

svn path=/trunk/; revision=7140
2003-02-13 22:35:10 +00:00
Guy Harris e62ee5cf8b From Santeri Paavolainen: fix for the following problems:
- BRR packets were incorrectly labeled as BE packets
	- Pad1 options had their length handled incorrectly

svn path=/trunk/; revision=7139
2003-02-13 22:23:20 +00:00
Guy Harris a79c12635f From Didier Gautheron: fix up the handling of the cross.
svn path=/trunk/; revision=7138
2003-02-13 22:17:18 +00:00
Guy Harris 1bea0a66e8 From Olivier Biot:
Decoding of WML 1.0 and PROV 1.0.

	Now the following content types are decoded and rendered:
	  - WML: 1.0, 1.1, 1.2, 1.3
	  - SI: 1.0
	  - SL: 1.0
	  - CO: 1.0
	  - PROV: 1.0

svn path=/trunk/; revision=7137
2003-02-13 22:16:16 +00:00
Jörg Mayer 8f75637e6f Mark pinfo parameter as unused
svn path=/trunk/; revision=7136
2003-02-13 22:00:53 +00:00
Guy Harris eefaa8a339 Put in a missing comma in a list of strings, so we don't get two strings
concatenated.

svn path=/trunk/; revision=7135
2003-02-13 08:29:19 +00:00
Guy Harris c2594e7429 Fetch the time stamp into a gint32, as it's known to be 32 bits, and let
the call to "abs_time_secs_to_str()" convert it to a "time_t".

svn path=/trunk/; revision=7134
2003-02-13 03:05:14 +00:00
Guy Harris 5795b17d48 Cast "timeval" to "long", and print it with "%ld", to handle "time_t"
being an "int" or a "long".

svn path=/trunk/; revision=7133
2003-02-13 02:47:50 +00:00
Guy Harris 4f59075d6a From Craig Rodrigues: decode the priority value put into the service
context field by Real-time CORBA.

Update his e-mail address while we're at it.

svn path=/trunk/; revision=7132
2003-02-13 01:23:37 +00:00
Guy Harris 23feb04a83 From Jochen Friedrich:
Fixed handling of NLP header in SNA
	XID handoff table for LLC, and XID dissection for SNA format 3
	HPR optional segments in SNA
	Most important control vectors in SNA
	Route setup messages in SNA
	Additional LLC DSAPs for SNA

svn path=/trunk/; revision=7131
2003-02-13 00:47:42 +00:00
Guy Harris 8a0882dfd4 From Didier Gautheron: add AFP3 setforkparam 64 bits parameters.
svn path=/trunk/; revision=7130
2003-02-12 21:50:31 +00:00
Guy Harris 699e4314d5 From Olivier Biot:
add string table parsing and displaying;

	add registration to more content types;

	LITERAL tag indentation fix;

	add and a change in unrendered WBXML: from confusing "<Tag
	0x37>" type display to "<Tag_0x37>" (and same in attribute
	state).

svn path=/trunk/; revision=7129
2003-02-12 21:46:15 +00:00