Commit graph

72 commits

Author SHA1 Message Date
Anders Broman
84fb70ef42 call OID subdissector for private extensiions, fix makefiles.
svn path=/trunk/; revision=17772
2006-03-30 16:46:36 +00:00
Gerald Combs
f87b0f78ae Fix an off-by-one error.
svn path=/trunk/; revision=17771
2006-03-30 16:13:37 +00:00
Anders Broman
2bf7bd3a45 From Jacques, Olivier
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits.
It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function.

svn path=/trunk/; revision=17739
2006-03-27 18:48:33 +00:00
Anders Broman
7186d13653 Fix bug:
825 setup message has an error in gsm-a-dtap 

svn path=/trunk/; revision=17704
2006-03-23 16:59:48 +00:00
Anders Broman
f935a4f8f6 Fix http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=820
svn path=/trunk/; revision=17695
2006-03-22 17:10:19 +00:00
Anders Broman
74dd581db8 Remove c++ style comment.
svn path=/trunk/; revision=17352
2006-02-19 10:17:07 +00:00
Anders Broman
06d6295287 From Florent.Drouin@alcatel.fr
Add the same workaround used in packet-ftam.c for the bad handling of the asn "IMPLICIT SEQUENCE", in the packet-gsm_map-template.c. This patch concerns Map V3 messages, not correctly decoded with the previous workaround "offset=offset+2".

Change a parameter for Provide Roaming Number decoding.

Add a decoding fonction for "Channel needed" parameter to avoid a decoding error for Paging messages
with a change to actually dissct channel needed.

svn path=/trunk/; revision=17350
2006-02-18 23:29:51 +00:00
Anders Broman
25a7d62b92 BSSGP - Translate MCC and make MCC MNC etc vissible filters
GSMMAP - Small bugfix

svn path=/trunk/; revision=17132
2006-01-31 05:46:36 +00:00
Anders Broman
1c5874e2e3 Dissect CellGlobalIdOrServiceAreaIdOrLAI and RAIdentity
svn path=/trunk/; revision=17075
2006-01-22 21:16:33 +00:00
Anders Broman
f194c9eddb Dissect:
- PDPcontext
 - GSN-Address
 - QoS

svn path=/trunk/; revision=17063
2006-01-20 19:41:31 +00:00
Anders Broman
9d6de675a4 ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.

svn path=/trunk/; revision=17055
2006-01-19 18:20:14 +00:00
Jörg Mayer
f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Anders Broman
f9d87c5800 Get rid of some GCC warnings about unused code.
svn path=/trunk/; revision=16861
2005-12-19 19:36:32 +00:00
Luis Ontanon
bc84ba5de6 Have tcap subdissectors registering using functions provided by tcap and tcap manage ssn registration.
In packet-sccp.c avoid not having a binding.


svn path=/trunk/; revision=16834
2005-12-17 16:55:45 +00:00
Guy Harris
b45d2efe6d Regenerate with the latest asn2eth, to get FT_OID used, and to add #line.
svn path=/trunk/; revision=16736
2005-12-08 23:29:21 +00:00
Anders Broman
f082fe8ecf ISUP - Export functions used by INAP and Camel
Gsmmap - Export asn1 structs used by Camel
Camel - Use functions from GSMMAp and ISUP
INAP - Rewrite of the asn1 code to correspond more to CS1 data types
          Let ISUP and Q931 dissect apropriate stuff.

svn path=/trunk/; revision=16624
2005-11-29 17:23:50 +00:00
Anders Broman
b8d097b28b Update the Camel asn1 spec to 3GPP TS 29.078 version 6.4.0 and export needed stuff from gsmmap
svn path=/trunk/; revision=16587
2005-11-25 20:18:36 +00:00
Guy Harris
0e17a773b9 A loop processing all the bytes in a tvbuff from a given offset to the
end of the data in the tvbuff should stop when the offset is >= the
total amount of data in the tvbuff, not when it's > the total amount in
the tvbuff following the starting offset.

In "unpack_digits()", return a null string, not a null pointer, if
there's nothing left in the tvbuff starting at the starting offset, so
that the caller doesn't have to check for a null pointer, and return an
ep_alloc()ed buffer, so the caller doesn't have to worry about freeing
the result.

If we see a filler digit, don't advance the offset in the string buffer;
we want to put the terminating '\0' right after the character we just
put into the string.

Fuzzed against some GSM captures.

svn path=/trunk/; revision=16002
2005-09-25 09:32:01 +00:00
Guy Harris
ced076f8d4 OIDs are put into the protocol tree as strings containing a textual
representation of the OID, so the fields for them should be of type
FT_STRING.  This should fix bug 470.

svn path=/trunk/; revision=15945
2005-09-21 23:07:07 +00:00
Anders Broman
1bb6396a93 Fix bug #404 Decoding of MSISDN on GSM is incomplete.
svn path=/trunk/; revision=15906
2005-09-20 20:04:01 +00:00
Anders Broman
3b949ac5a4 From ouli:
- Add version 2 CancelLocation decoding

svn path=/trunk/; revision=15665
2005-09-02 05:46:10 +00:00
Anders Broman
1f0b3d1d38 Fix decoding of sendIdentificationArg/Res and ProvideSubscriberLocation
svn path=/trunk/; revision=15510
2005-08-22 16:19:31 +00:00
Ronnie Sahlberg
e88b3ccb32 remove sprintf from gsm_a
svn path=/trunk/; revision=15492
2005-08-21 01:52:09 +00:00
Anders Broman
206c6edb22 from Tomas Kukosa, remove a redundant g_strdup()
svn path=/trunk/; revision=15387
2005-08-17 09:43:16 +00:00
Ronnie Sahlberg
3c0f522818 updates from Anders B
Regenerate gsm ss and gsm map



svn path=/trunk/; revision=15259
2005-08-08 08:53:05 +00:00
Anders Broman
bfdffc2c80 Rewrite of MAP_dialouge asn1 code, export and use of functions from gsm_map.
svn path=/trunk/; revision=15106
2005-07-26 20:42:07 +00:00
Ronnie Sahlberg
0ca30abe65 change the symbol dissect_ber_CHOICE back into dissect_ber_choice
svn path=/trunk/; revision=14980
2005-07-21 21:12:09 +00:00
Anders Broman
05e8481eed Fix an unpack_digits off by one error.
svn path=/trunk/; revision=14954
2005-07-19 19:48:02 +00:00
Anders Broman
43e9a11b11 Dissect some more fields
svn path=/trunk/; revision=14897
2005-07-11 19:25:25 +00:00
Anders Broman
c50d7e229e Add some missing IMPLICIT tags, and use FN_PARS directive.
Add disection of some RR elements and command Handover.

svn path=/trunk/; revision=14878
2005-07-08 20:01:11 +00:00
Anders Broman
96389d268c Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
svn path=/trunk/; revision=14848
2005-07-04 19:07:02 +00:00
Anders Broman
359ada1199 Fix to SendAuthenticationInfoRes
svn path=/trunk/; revision=14808
2005-06-28 21:14:59 +00:00
Guy Harris
ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00
Anders Broman
1bad9775dd Add a signal
svn path=/trunk/; revision=14777
2005-06-26 11:03:39 +00:00
Ronnie Sahlberg
3a51ba4293 make dissect_ber_choice take a guint* that will return the
index of the branch taken or -1  to make prettifications easier to implement.


change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all
occurences of the use of this function

update asn2eth to use the new name/signature

update all occurences of this function to the new name and new signature.



svn path=/trunk/; revision=14758
2005-06-26 05:48:50 +00:00
Anders Broman
44d693bf55 Major rewrite to update to version TS 129 002 V6.9.0
svn path=/trunk/; revision=14749
2005-06-25 17:26:30 +00:00
Guy Harris
562efe2ce9 Regenerate - this squelches some compiler warnings.
svn path=/trunk/; revision=14647
2005-06-16 06:06:18 +00:00
Anders Broman
86a56ba7cc From Tim Endean:
- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags.
- Both ANSI and ITU variants supported without configuration.
- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first.


svn path=/trunk/; revision=14572
2005-06-07 05:49:06 +00:00
Anders Broman
7263d93115 From Tim Endean:
Ss-code is Optional in some cases.

svn path=/trunk/; revision=14371
2005-05-15 21:17:29 +00:00
Anders Broman
92b1092937 Reinsert Gerards patch (r14342) which was lost.
svn path=/trunk/; revision=14352
2005-05-11 22:20:11 +00:00
Anders Broman
eac5e05d3a pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages.
svn path=/trunk/; revision=14350
2005-05-11 22:00:50 +00:00
Anders Broman
88c39bc93b Fix dissection of mo-forwardSM
svn path=/trunk/; revision=14342
2005-05-10 20:09:09 +00:00
Gerald Combs
338bf987f6 Don't try to g_strdup() a null value. Fixes bug 128.
svn path=/trunk/; revision=14211
2005-04-28 03:41:05 +00:00
Ronnie Sahlberg
b95490206d from Olivier J
bugfix for IMPLICIT NULL in BER sequences
and gsmmap updates



svn path=/trunk/; revision=14160
2005-04-21 21:37:23 +00:00
Anders Broman
15d1745271 From Olivier Jacques:
- Add bearerServiceCodes decoding
- Fixed sendRoutingInfoForSM and reportSM-DeliveryStatus invoke decoding (argument mismatch)

svn path=/trunk/; revision=14091
2005-04-15 08:30:23 +00:00
Ronnie Sahlberg
305d4cc151 tiny bugfix for gsmmap
svn path=/trunk/; revision=14000
2005-04-01 11:12:32 +00:00
Anders Broman
caa56dfc55 From Jacques, Olivier: Length of digit_str wrongly calculated.
Free the string, fix dissection of some elements.

svn path=/trunk/; revision=13986
2005-03-31 18:41:44 +00:00
Anders Broman
2c8cf2ab42 Small bug fix
svn path=/trunk/; revision=13981
2005-03-30 19:10:26 +00:00
Guy Harris
9385c4b868 The "application_context_version" variables in the CAMEL and GSM MAP
dissectors aren't needed outside the dissectors, and having more than
one of them exported causes build problems, at least on OS X - make them
static.

Fix indentation.

svn path=/trunk/; revision=13951
2005-03-28 02:53:49 +00:00
Anders Broman
fe9a6628b8 From Jeff Morriss: use the new range preference type.
svn path=/trunk/; revision=13796
2005-03-17 22:08:50 +00:00