Commit graph

6961 commits

Author SHA1 Message Date
Bill Meier
c5ebd555b7 Trivial changes: comment and spacing
svn path=/trunk/; revision=26251
2008-09-23 00:45:05 +00:00
Bill Meier
5cba9cd3ae Fix minor bug: dissector_delete(...) should be "tcp" and not "udp".
svn path=/trunk/; revision=26250
2008-09-23 00:33:33 +00:00
Bill Meier
6aa5f8aa6a Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26246
2008-09-22 16:26:41 +00:00
Anders Broman
612463c139 Try to fix some "defined but not used" warnings.
svn path=/trunk/; revision=26243
2008-09-21 14:23:34 +00:00
Jaap Keuter
19e29e857e From Derek Morr:
The Kerberos dissector does not parse IPv6 addresses in AS-REQ messages.
Attached is a patch that adds IPv6 dissection support, and adds a new filter,
kerberos.addr_ipv6, which is analagous to the existing kerberos.addr_ip.

svn path=/trunk/; revision=26241
2008-09-21 13:55:32 +00:00
Guy Harris
dbf7b99e97 The Official Home of the AVS header spec appears to bhe the
linux-wlan-ng source tree; just insert it verbatim into a big honking
comment, rather than trying to play Find The URL with it.

svn path=/trunk/; revision=26239
2008-09-20 01:57:18 +00:00
Bill Meier
ca34becf82 Minor cleanup primarily related to proto_reg_handoff; spacing changes
svn path=/trunk/; revision=26237
2008-09-19 20:42:01 +00:00
Bill Meier
a3e6eb8071 Minor cleanup mostly related to proto_reg_handoff
svn path=/trunk/; revision=26236
2008-09-19 17:39:44 +00:00
Gerald Combs
80e94e3ec3 Move wtap_pcap_encap_to_wtap_encap and wtap_wtap_encap_to_pcap_encap to
libwsutil.

svn path=/trunk/; revision=26233
2008-09-19 16:26:37 +00:00
Stig Bjørlykke
bf24d9c3dc Dump the unsupported opcode for invoke result and invoke error,
as is done for invoke argument.

svn path=/trunk/; revision=26232
2008-09-19 15:28:43 +00:00
Jeff Morriss
ee75b3eeae If we get an LSSU of length 2, interpret the first octet of the SF field the
same as it would be for a LSSU of length 1 (see Q.703/11.1.2).  Since the
second octet is undefined just display it was a hex FT_UINT8.

svn path=/trunk/; revision=26230
2008-09-19 12:19:17 +00:00
Jeff Morriss
ad10542235 Correct the field lengths for the segmentation parameter (fixes the highlighting in the byte pane).
svn path=/trunk/; revision=26229
2008-09-19 12:17:32 +00:00
Gerald Combs
aac8e0d91d Fix a spelling error pointed out by Noam Rathaus.
svn path=/trunk/; revision=26228
2008-09-18 17:19:15 +00:00
Jeff Morriss
1882e64736 If we're dissecting for a read filter in the GUI [tshark assigns
frame numbers before running the read filter], don't do the TSN
analysis.  (We can't anyway because we don't have a valid frame
number...)

Without this change if you load a capture file in the
GUI while using a read filter, every SCTP TSN is marked as a
retransmission of that in frame 0.

svn path=/trunk/; revision=26226
2008-09-17 21:59:15 +00:00
Jeff Morriss
0b1c118f92 A couple of trivial indentation fixes
svn path=/trunk/; revision=26225
2008-09-17 15:54:55 +00:00
Bill Meier
9d203cb9c6 Fix some imdentation
svn path=/trunk/; revision=26223
2008-09-17 03:27:40 +00:00
Bill Meier
618f722102 Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26222
2008-09-17 03:21:55 +00:00
Jaap Keuter
cb477a2a4a From Vladimir Koutny:
The size of selected_registrar fiels in WPS IE should be 1b, not 2b 
(it is defined as BOOL in WPS specs).

svn path=/trunk/; revision=26214
2008-09-16 05:43:36 +00:00
Jaap Keuter
b95f7e92ae Fix for bug 2875:
Fix a final eth_fopen -> ws_fopen
When configuring with --without-zlib these functions need to have some parameters tagged _U_

svn path=/trunk/; revision=26212
2008-09-15 21:50:50 +00:00
Jeff Morriss
740a53095c Put Data dissection (if no subdissector is found) on the toplevel tree instead of within the SUA tree.
svn path=/trunk/; revision=26211
2008-09-15 20:35:02 +00:00
Jeff Morriss
f426f3363f If ANSI and national==0, decode the PC as ITU (not China). This fixes bug 2861.
svn path=/trunk/; revision=26210
2008-09-15 20:17:47 +00:00
Bill Meier
3ab617020d proto_reg_handoff: fix so port pref change works; gen'l cleanuop
svn path=/trunk/; revision=26208
2008-09-15 19:54:40 +00:00
Jaap Keuter
28c2ad711d From Michael Bernhard:
The dissector asserted displaying cookies in DTLS frames because it was registered as FT_NONE.

svn path=/trunk/; revision=26207
2008-09-15 19:49:43 +00:00
Bill Meier
771b90eba7 Fix compile error
svn path=/trunk/; revision=26206
2008-09-15 19:38:16 +00:00
Bill Meier
03187c631d Fix so pkt_ccc port pref works; proto_reg_handoff's: gen'l cleanup.
svn path=/trunk/; revision=26205
2008-09-15 19:33:38 +00:00
Bill Meier
e90ee620d6 'static initialized' --> 'static gboolean initialized'
svn path=/trunk/; revision=26204
2008-09-15 19:03:03 +00:00
Bill Meier
8735dea057 proto_reg_handoff: rework/cleanup; fix so ports properly deleted/added.
svn path=/trunk/; revision=26203
2008-09-15 18:58:03 +00:00
Bill Meier
4f2845d9a0 proto_reg-handoff: Fix to properly delete/add port when pref changed; cleanup.
svn path=/trunk/; revision=26202
2008-09-15 18:48:28 +00:00
Bill Meier
795f0f8abb Fix several definitions
svn path=/trunk/; revision=26201
2008-09-15 18:39:34 +00:00
Bill Meier
4a94cd780c Add prefs callback so tcp_port pref works; Cleanup proto_reg_handoff.
svn path=/trunk/; revision=26200
2008-09-15 18:34:05 +00:00
Bill Meier
8f7331be64 Fix some indentation; 'static int' --> 'static guint'
svn path=/trunk/; revision=26198
2008-09-15 16:51:23 +00:00
Bill Meier
9a6db6e945 proto_reg-handoff: Use dissector_add_handle instead of registering to port 0;
Also: minor cleanup related to proto_reg_handoff

svn path=/trunk/; revision=26197
2008-09-15 16:36:06 +00:00
Bill Meier
1e7e3cee51 Minor cleanup related to proto_reg_handoff
svn path=/trunk/; revision=26196
2008-09-15 15:38:34 +00:00
Stig Bjørlykke
2aee2b22f6 Do not flag a low TTL if sending to a multicast address (224.0.0.0/4).
svn path=/trunk/; revision=26195
2008-09-15 12:50:35 +00:00
Bill Meier
82affdc4df Fix indentation to be consistent
svn path=/trunk/; revision=26194
2008-09-15 02:05:26 +00:00
Anders Broman
aadfcc546c Allways show the Vendor OUI in the vedors specific IE.
svn path=/trunk/; revision=26193
2008-09-14 15:14:46 +00:00
Anders Broman
d7c62b2db5 Use the unmodified DialoguePDUs ASN1 file.
svn path=/trunk/; revision=26192
2008-09-14 14:42:39 +00:00
Anders Broman
14f76023b3 Remove the rest of the ANSI TCAP stuff.
svn path=/trunk/; revision=26191
2008-09-14 14:33:01 +00:00
Jaap Keuter
a83a87e9ca Fix for bug 2870:
Wrap dissect_q931_cause_ie() in a save version which clears the have_valid_q931_pi semaphore. This may remain set if a malformed q931 message causes an exception.

svn path=/trunk/; revision=26190
2008-09-14 13:09:14 +00:00
Anders Broman
eb9dc794b2 Start to get rid of the "old" ANSI TCAP stuff.
svn path=/trunk/; revision=26189
2008-09-13 16:38:21 +00:00
Anders Broman
16512c7b8c Use original UnidialoguePDUs.
svn path=/trunk/; revision=26188
2008-09-13 15:32:59 +00:00
Bill Meier
e344bc8f0f Small revisions related to proto_reg_handoff ....
svn path=/trunk/; revision=26185
2008-09-12 16:52:01 +00:00
Michael Tüxen
296be40635 Add support for
http://www.ietf.org/internet-drafts/draft-tuexen-tsvwg-sctp-sack-immediately-00.txt

svn path=/trunk/; revision=26184
2008-09-12 16:23:18 +00:00
Anders Broman
2382a8edaf Revert one of the changes.
svn path=/trunk/; revision=26183
2008-09-12 16:02:39 +00:00
Anders Broman
9bf8e1d741 Try to fix "defined but not used" warnings.
svn path=/trunk/; revision=26182
2008-09-12 09:11:28 +00:00
Anders Broman
021d8153b2 From Karl Heinz Wolf:
LoST Server Domain Name DHCPv4 Option (RFC 5223)

svn path=/trunk/; revision=26179
2008-09-11 20:44:19 +00:00
Anders Broman
f08f558eea Work around a problem with custom columns.
svn path=/trunk/; revision=26178
2008-09-11 19:34:29 +00:00
Anders Broman
8e5509273f "Response flags" in GIOP Request is misinterpreted
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800

svn path=/trunk/; revision=26177
2008-09-11 19:33:07 +00:00
Bill Meier
802f4452b4 Minor cleanup related to proto_reg_handoff ....
svn path=/trunk/; revision=26176
2008-09-11 14:07:02 +00:00
Guy Harris
7bdebbdb00 In the radio-information dissector, set the current protocol name before
calling the 802.11 dissector, so if we have a malformed frame or short
frame the right protocol name will be shown.

svn path=/trunk/; revision=26173
2008-09-10 21:48:15 +00:00
Bill Meier
961698e3e7 strncasecmp ==> g_ascii_strncasecmp
svn path=/trunk/; revision=26172
2008-09-10 12:57:48 +00:00
Jaap Keuter
890cbb15d1 Fix for bug 2859:
Skip data portion of unknown TLV.

Expand type interpretation and several other cleanups.

svn path=/trunk/; revision=26169
2008-09-09 21:17:17 +00:00
Bill Meier
7f2978acc8 From Pavol Rusnak: Add missing break statement....
svn path=/trunk/; revision=26166
2008-09-08 16:13:39 +00:00
Jaap Keuter
b6b59d1f99 From Neil Piercy:
The IP Address IE did not decode correctly - the address fetch did not skip the
Address Type field.

svn path=/trunk/; revision=26164
2008-09-08 06:02:35 +00:00
Anders Broman
17df3adc80 Udate tlv_type_names with values from http://www.iana.org/assignments/ldp-namespaces.
svn path=/trunk/; revision=26162
2008-09-07 17:18:49 +00:00
Anders Broman
2c68dca215 From Neil Piercy:
Empty GPRS LLC S frames cause truncated data exception
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2855

svn path=/trunk/; revision=26160
2008-09-07 13:36:56 +00:00
Guy Harris
9e82ae1e49 Move the advancement of the packet offset outside the "if (tree)".
This fixes bug 2856.

svn path=/trunk/; revision=26159
2008-09-07 08:44:47 +00:00
Guy Harris
e1d2a36b02 Clean up indetation.
If we're running in TShark, there's never a GUI; clean up comments.

Merge a couple of if statements together, as the "true" branch of the
second statement is executed only if the "true" branch of the first
statement is executed.

svn path=/trunk/; revision=26158
2008-09-07 03:13:10 +00:00
Guy Harris
dd317fd99c Style and indentation cleanups.
Don't initialize a variable that's set (in the handoff registration
routine) before being used.

Now that we're GLib 2.0-only, use g_ascii_isalpha() rather than rolling
our own.

svn path=/trunk/; revision=26157
2008-09-07 01:50:44 +00:00
Guy Harris
22b5159053 Add support for TLS-over-SMTP.
svn path=/trunk/; revision=26156
2008-09-07 01:28:43 +00:00
Guy Harris
93e12f5b69 Have a line_is_smtp_command() routine to check whether a line is an SMTP
command, and use that in the parsing loop (that means we don't have to
treat 4-character commands and non-4-character commands separately).

svn path=/trunk/; revision=26155
2008-09-06 23:58:23 +00:00
Guy Harris
73e36ab9da Add some comments.
svn path=/trunk/; revision=26153
2008-09-06 22:33:22 +00:00
Anders Broman
d1ea868c27 Bucket Leak Rate decoded incorrectly as bytes instead of bits
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2849

svn path=/trunk/; revision=26147
2008-09-06 11:45:08 +00:00
Anders Broman
7530143278 Add extended cap decoding.
svn path=/trunk/; revision=26145
2008-09-05 16:04:02 +00:00
Guy Harris
b7d8597ec3 Move another comment next to the code to which it refers.
svn path=/trunk/; revision=26144
2008-09-05 09:51:13 +00:00
Guy Harris
e707fb415f Move a comment to the right place.
svn path=/trunk/; revision=26143
2008-09-05 09:28:08 +00:00
Guy Harris
19d3eb7004 Clean up indentation.
svn path=/trunk/; revision=26142
2008-09-05 09:07:46 +00:00
Anders Broman
ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Guy Harris
6321274b52 Mark unused argument as such.
Style changes.

svn path=/trunk/; revision=26139
2008-09-04 21:21:27 +00:00
Anders Broman
0b53441f69 Modified patch from Siva Jupudi adding support for
WAVE Service information element Dissection - IEEE 802.11p Draft 4.0

svn path=/trunk/; revision=26138
2008-09-04 20:54:22 +00:00
Guy Harris
5a97fd382f That #include is necessary to get epan_strcasestr() declared;
unfortunately, that didn't show up in a build, as this file isn't yet
clean and isn't yet built with -Werror.

svn path=/trunk/; revision=26135
2008-09-03 23:51:26 +00:00
Guy Harris
9d1b5335ac g_ascii_strdown() and g_ascii_strup(), unlike g_strdown() and g_strup(),
do *not* modify the string handed to them - they g_mallocate a new
string and return it.

Create routines that *do* ASCII-only case mapping in place, and use them
instead.

Clean up indentation.

svn path=/trunk/; revision=26131
2008-09-03 19:14:52 +00:00
Anders Broman
e708889484 Try to fix unused code warnings(hack).
svn path=/trunk/; revision=26129
2008-09-03 17:03:30 +00:00
Bill Meier
419e3a47f6 Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26128
2008-09-03 16:42:35 +00:00
Jaap Keuter
7116bc941b Made FCS calculation and checking code work on GCC 4.3.1.
Made FCS check actually mean something.

svn path=/trunk/; revision=26125
2008-09-03 05:56:30 +00:00
Bill Meier
8d9c5d9b2b Cleanup related to prefs & proto_reg_handoff
svn path=/trunk/; revision=26124
2008-09-02 21:40:46 +00:00
Anders Broman
80b87dfaf3 Try to fix unused code warnings.
svn path=/trunk/; revision=26122
2008-09-02 19:42:30 +00:00
Bill Meier
40bd43db83 Minor cleanup (mostly related to proto_reg_handoff...)
svn path=/trunk/; revision=26121
2008-09-02 19:08:29 +00:00
Anders Broman
6c7b56081c Handle extension header.
svn path=/trunk/; revision=26119
2008-09-02 18:27:33 +00:00
Bill Meier
afd857957a Fix a few Emacs "file variables" to have "safe" values.
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t
Also: fix a typo: set-tabs-mode --> indent-tabs-mode

svn path=/trunk/; revision=26113
2008-09-02 11:17:03 +00:00
Guy Harris
dd190f38e5 OK, let's see if the x509sat dissector is clean.
svn path=/trunk/; revision=26112
2008-09-02 06:44:41 +00:00
Anders Broman
8970b4524d Try to fix unused code warnings.
svn path=/trunk/; revision=26111
2008-09-02 06:04:25 +00:00
Anders Broman
9d0a401a12 Try to fix unused code warnings.
svn path=/trunk/; revision=26110
2008-09-02 05:43:28 +00:00
Anders Broman
a517a46fa7 Try to fix unused code warnings.
svn path=/trunk/; revision=26109
2008-09-01 21:10:28 +00:00
Anders Broman
1a109ff02c Update to use unchanged asn1 files and X.501:08/2005.
Hopefullly without breaking to many things.

svn path=/trunk/; revision=26108
2008-09-01 20:29:01 +00:00
Anders Broman
3d07d2bee8 Try to fix "defined but not used" warnings.
svn path=/trunk/; revision=26107
2008-08-31 21:37:16 +00:00
Anders Broman
c7b010d246 Remove test code for depreciated OID.
svn path=/trunk/; revision=26106
2008-08-31 21:11:32 +00:00
Anders Broman
47d612ccc9 Update to X.509:08/2005.
svn path=/trunk/; revision=26105
2008-08-31 21:00:06 +00:00
Anders Broman
48dbffeda4 OID 1.3.6.1.5.5.7.8.5 (id-on-xmppAddr) not recognized by BER dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2835

svn path=/trunk/; revision=26104
2008-08-31 12:55:45 +00:00
Guy Harris
56ae1ea2f7 Give "initialized" the right data type.
svn path=/trunk/; revision=26101
2008-08-27 22:46:03 +00:00
Bill Meier
32dc6c98e4 If port pref changed, delete registration for previous port
svn path=/trunk/; revision=26099
2008-08-27 19:47:21 +00:00
Guy Harris
317201b985 Give macros and libraries names that imply that clean dissectors are the
normal case, and dissectors with warnings are the exception; the
ultimate goal is to have only clean dissectors.

Move a bunch of now-cleaned-up dissectors into the "clean" category.

Fix a comment.

svn path=/trunk/; revision=26096
2008-08-26 03:45:42 +00:00
Guy Harris
f0acec0696 Fix some macro name errors.
svn path=/trunk/; revision=26092
2008-08-26 01:32:15 +00:00
Bill Meier
b52d95d591 #include <emem.h> not req'd
svn path=/trunk/; revision=26091
2008-08-26 01:28:50 +00:00
Guy Harris
d7a51fc7de Get rid of an unused variable in the P7 dissector.
Create a set of warning-clean ASN.1 dissectors and build them with
-Werror, to try to prevent errors creeping back in.  Put the P7
dissector there.

svn path=/trunk/; revision=26090
2008-08-26 01:04:39 +00:00
Bill Meier
77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Anders Broman
74efeaae80 Add Answer or Request to the Command name in the info column depending on
if the R bit is set or not.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2828

svn path=/trunk/; revision=26088
2008-08-25 21:15:55 +00:00
Bill Meier
aac2a36133 #include <prefs.h> not req'd; Fix indentation to be conistent
svn path=/trunk/; revision=26086
2008-08-25 20:41:05 +00:00
Anders Broman
798fe6acca From Andrei Slavoiu:
TS 29.060 v7.8.0 and later specify new flags in the Common Flags IE:
bit 5 - No QoS Negotiation
bit 6 - NRSN
bit 7 - Upgrade QoS Supported

The current Wireshark implementation has bits 5 and 6 reversed. Attached patch
fixes this issue.

svn path=/trunk/; revision=26084
2008-08-25 20:05:26 +00:00
Bill Meier
5f26848657 prefs_register_protocol not req'd since no prefs; simplify reg_handoff & do minor cleanup
svn path=/trunk/; revision=26081
2008-08-25 19:53:32 +00:00